mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
@ 2012-01-31 20:51 Marek Belisko
  2012-01-31 20:51 ` [PATCH 2/2] pandaboard: Add gpmc_generic_init to board init Marek Belisko
  2012-02-01  9:32 ` [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage Premi, Sanjeev
  0 siblings, 2 replies; 12+ messages in thread
From: Marek Belisko @ 2012-01-31 20:51 UTC (permalink / raw)
  To: barebox; +Cc: Marek Belisko

Build for omap platform by default.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
 arch/arm/boards/beagle/board.c          |    4 ++--
 arch/arm/boards/omap343xdsp/board.c     |    2 --
 arch/arm/boards/omap3evm/board.c        |    3 +--
 arch/arm/boards/phycard-a-l1/pca-a-l1.c |    3 ---
 arch/arm/configs/panda_xload_defconfig  |    1 -
 arch/arm/configs/phycard_a_l1_defconfig |    1 -
 arch/arm/mach-omap/Kconfig              |   10 ----------
 arch/arm/mach-omap/Makefile             |    3 +--
 drivers/mtd/nand/Kconfig                |    1 -
 9 files changed, 4 insertions(+), 24 deletions(-)

diff --git a/arch/arm/boards/beagle/board.c b/arch/arm/boards/beagle/board.c
index faeaf8e..caeb578 100644
--- a/arch/arm/boards/beagle/board.c
+++ b/arch/arm/boards/beagle/board.c
@@ -302,10 +302,10 @@ static int beagle_devices_init(void)
 		add_usb_ehci_device(-1, OMAP_EHCI_BASE,
 				    OMAP_EHCI_BASE + 0x10, &ehci_pdata);
 #endif /* CONFIG_USB_EHCI_OMAP */
-#ifdef CONFIG_OMAP_GPMC
+
 	/* WP is made high and WAIT1 active Low */
 	gpmc_generic_init(0x10);
-#endif
+
 	gpmc_generic_nand_devices_init(0, 16, OMAP_ECC_HAMMING_CODE_HW_ROMCODE);
 
 	add_generic_device("omap-hsmmc", -1, NULL, OMAP_MMC1_BASE, SZ_4K,
diff --git a/arch/arm/boards/omap343xdsp/board.c b/arch/arm/boards/omap343xdsp/board.c
index 4ad6f13..4cf6f31 100644
--- a/arch/arm/boards/omap343xdsp/board.c
+++ b/arch/arm/boards/omap343xdsp/board.c
@@ -641,10 +641,8 @@ mem_initcall(sdp3430_mem_init);
 
 static int sdp3430_devices_init(void)
 {
-#ifdef CONFIG_OMAP_GPMC
 	/* WP is made high and WAIT1 active Low */
 	gpmc_generic_init(0x10);
-#endif
 
 	return 0;
 }
diff --git a/arch/arm/boards/omap3evm/board.c b/arch/arm/boards/omap3evm/board.c
index fdd5227..ffcb6a6 100644
--- a/arch/arm/boards/omap3evm/board.c
+++ b/arch/arm/boards/omap3evm/board.c
@@ -253,12 +253,11 @@ mem_initcall(omap3evm_mem_init);
 
 static int omap3evm_init_devices(void)
 {
-#ifdef CONFIG_OMAP_GPMC
 	/*
 	 * WP is made high and WAIT1 active Low
 	 */
 	gpmc_generic_init(0x10);
-#endif
+
 #ifdef CONFIG_MCI_OMAP_HSMMC
 	add_generic_device("omap-hsmmc", -1, NULL, OMAP_MMC1_BASE, SZ_4K,
 				IORESOURCE_MEM, NULL);
diff --git a/arch/arm/boards/phycard-a-l1/pca-a-l1.c b/arch/arm/boards/phycard-a-l1/pca-a-l1.c
index f7d3185..7a1196e 100644
--- a/arch/arm/boards/phycard-a-l1/pca-a-l1.c
+++ b/arch/arm/boards/phycard-a-l1/pca-a-l1.c
@@ -288,13 +288,10 @@ static void pcaal1_setup_net_chip(void)
 
 static int pcaal1_mem_init(void)
 {
-
-#ifdef CONFIG_OMAP_GPMC
 	/*
 	 * WP is made high and WAIT1 active Low
 	 */
 	gpmc_generic_init(0x10);
-#endif
 
 	arm_add_mem_device("ram0", OMAP_SDRC_CS0, get_sdr_cs_size(SDRC_CS0_OSET));
 
diff --git a/arch/arm/configs/panda_xload_defconfig b/arch/arm/configs/panda_xload_defconfig
index f8f0ae9..bdfbeb9 100644
--- a/arch/arm/configs/panda_xload_defconfig
+++ b/arch/arm/configs/panda_xload_defconfig
@@ -1,6 +1,5 @@
 CONFIG_ARCH_OMAP=y
 CONFIG_ARCH_OMAP4=y
-# CONFIG_OMAP_GPMC is not set
 CONFIG_OMAP_BUILD_IFT=y
 CONFIG_AEABI=y
 # CONFIG_CMD_ARM_CPUINFO is not set
diff --git a/arch/arm/configs/phycard_a_l1_defconfig b/arch/arm/configs/phycard_a_l1_defconfig
index 95dffbb..9ccf43d 100644
--- a/arch/arm/configs/phycard_a_l1_defconfig
+++ b/arch/arm/configs/phycard_a_l1_defconfig
@@ -11,7 +11,6 @@ CONFIG_OMAP_CLOCK_ALL=y
 CONFIG_OMAP_CLOCK_SOURCE_S32K=y
 CONFIG_OMAP3_CLOCK_CONFIG=y
 CONFIG_OMAP3_COPY_CLOCK_SRAM=n
-CONFIG_OMAP_GPMC=y
 CONFIG_MACH_PCAAL1=y
 CONFIG_HAS_OMAP_NAND=y
 CONFIG_AEABI=y
diff --git a/arch/arm/mach-omap/Kconfig b/arch/arm/mach-omap/Kconfig
index 50f53dd..11b9661 100644
--- a/arch/arm/mach-omap/Kconfig
+++ b/arch/arm/mach-omap/Kconfig
@@ -77,16 +77,6 @@ config OMAP3_CLOCK_CONFIG
 	help
 	  Say Y here if you like to have OMAP3 Clock configuration done.
 
-config OMAP_GPMC
-	prompt "Support for GPMC configuration"
-	bool
-	depends on  (ARCH_OMAP2 || ARCH_OMAP3 || ARCH_OMAP4)
-	default y
-	help
-	  Enable this if you use Texas Instrument's General purpose Memory
-	  Controller(GPMC). GPMC allows you to configure devices such as NOR,
-	  NAND, OneNAND etc.
-
 config OMAP_BUILD_IFT
 	prompt "build ift binary"
 	bool
diff --git a/arch/arm/mach-omap/Makefile b/arch/arm/mach-omap/Makefile
index 87078ae..26d3f7d 100644
--- a/arch/arm/mach-omap/Makefile
+++ b/arch/arm/mach-omap/Makefile
@@ -24,7 +24,6 @@ obj-$(CONFIG_OMAP_CLOCK_SOURCE_S32K) += s32k_clksource.o
 obj-$(CONFIG_ARCH_OMAP3) += omap3_core.o omap3_generic.o auxcr.o
 obj-$(CONFIG_ARCH_OMAP4) += omap4_generic.o omap4_clock.o
 obj-$(CONFIG_OMAP3_CLOCK_CONFIG) += omap3_clock.o
-obj-$(CONFIG_OMAP_GPMC) += gpmc.o devices-gpmc-nand.o
 obj-$(CONFIG_SHELL_NONE) += xload.o
 obj-$(CONFIG_I2C_TWL6030) += omap4_twl6030_mmc.o
-obj-y += gpio.o
+obj-y += gpio.o gpmc.o devices-gpmc-nand.o
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 926a64b..d846ce0 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -55,7 +55,6 @@ config NAND_IMX
 
 config NAND_OMAP_GPMC
 	tristate "NAND Flash Support for GPMC based OMAP platforms"
-	depends on OMAP_GPMC
 	help
 	 Support for NAND flash using GPMC. GPMC is a common memory
 	 interface found on Texas Instrument's OMAP platforms
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 2/2] pandaboard: Add gpmc_generic_init to board init.
  2012-01-31 20:51 [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage Marek Belisko
@ 2012-01-31 20:51 ` Marek Belisko
  2012-03-02  8:04   ` Jan Weitzel
  2012-02-01  9:32 ` [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage Premi, Sanjeev
  1 sibling, 1 reply; 12+ messages in thread
From: Marek Belisko @ 2012-01-31 20:51 UTC (permalink / raw)
  To: barebox; +Cc: Marek Belisko

We need to setup generic gpmc otherwise kernel panic during boot.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
 arch/arm/boards/panda/board.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boards/panda/board.c b/arch/arm/boards/panda/board.c
index be3ad77..1c71545 100644
--- a/arch/arm/boards/panda/board.c
+++ b/arch/arm/boards/panda/board.c
@@ -20,6 +20,7 @@
 #include <mach/gpio.h>
 #include <environment.h>
 #include <mach/xload.h>
+#include <mach/gpmc.h>
 
 static int board_revision;
 
@@ -137,6 +138,8 @@ static int panda_devices_init(void)
 			   IORESOURCE_MEM, NULL);
 	panda_ehci_init();
 
+	gpmc_generic_init(0x00);
+
 	armlinux_set_bootparams((void *)0x80000100);
 	armlinux_set_architecture(MACH_TYPE_OMAP4_PANDA);
 
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
  2012-01-31 20:51 [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage Marek Belisko
  2012-01-31 20:51 ` [PATCH 2/2] pandaboard: Add gpmc_generic_init to board init Marek Belisko
@ 2012-02-01  9:32 ` Premi, Sanjeev
  2012-02-01 10:16   ` Belisko Marek
  1 sibling, 1 reply; 12+ messages in thread
From: Premi, Sanjeev @ 2012-02-01  9:32 UTC (permalink / raw)
  To: Marek Belisko, barebox

> -----Original Message-----
> From: barebox-bounces@lists.infradead.org 
> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of 
> Marek Belisko
> Sent: Wednesday, February 01, 2012 2:21 AM
> To: barebox@lists.infradead.org
> Cc: Marek Belisko
> Subject: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> 
> Build for omap platform by default.
> 
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
>  arch/arm/boards/beagle/board.c          |    4 ++--
>  arch/arm/boards/omap343xdsp/board.c     |    2 --
>  arch/arm/boards/omap3evm/board.c        |    3 +--
>  arch/arm/boards/phycard-a-l1/pca-a-l1.c |    3 ---
>  arch/arm/configs/panda_xload_defconfig  |    1 -
>  arch/arm/configs/phycard_a_l1_defconfig |    1 -
>  arch/arm/mach-omap/Kconfig              |   10 ----------
>  arch/arm/mach-omap/Makefile             |    3 +--
>  drivers/mtd/nand/Kconfig                |    1 -
>  9 files changed, 4 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm/boards/beagle/board.c 
> b/arch/arm/boards/beagle/board.c
> index faeaf8e..caeb578 100644
> --- a/arch/arm/boards/beagle/board.c
> +++ b/arch/arm/boards/beagle/board.c
> @@ -302,10 +302,10 @@ static int beagle_devices_init(void)
>  		add_usb_ehci_device(-1, OMAP_EHCI_BASE,
>  				    OMAP_EHCI_BASE + 0x10, &ehci_pdata);
>  #endif /* CONFIG_USB_EHCI_OMAP */
> -#ifdef CONFIG_OMAP_GPMC
> +
>  	/* WP is made high and WAIT1 active Low */
>  	gpmc_generic_init(0x10);
> -#endif
> +
>  	gpmc_generic_nand_devices_init(0, 16, 
> OMAP_ECC_HAMMING_CODE_HW_ROMCODE);
>  
>  	add_generic_device("omap-hsmmc", -1, NULL, 
> OMAP_MMC1_BASE, SZ_4K,
> diff --git a/arch/arm/boards/omap343xdsp/board.c 
> b/arch/arm/boards/omap343xdsp/board.c
> index 4ad6f13..4cf6f31 100644
> --- a/arch/arm/boards/omap343xdsp/board.c
> +++ b/arch/arm/boards/omap343xdsp/board.c
> @@ -641,10 +641,8 @@ mem_initcall(sdp3430_mem_init);
>  
>  static int sdp3430_devices_init(void)
>  {
> -#ifdef CONFIG_OMAP_GPMC
>  	/* WP is made high and WAIT1 active Low */
>  	gpmc_generic_init(0x10);
> -#endif
>  
>  	return 0;
>  }
> diff --git a/arch/arm/boards/omap3evm/board.c 
> b/arch/arm/boards/omap3evm/board.c
> index fdd5227..ffcb6a6 100644
> --- a/arch/arm/boards/omap3evm/board.c
> +++ b/arch/arm/boards/omap3evm/board.c
> @@ -253,12 +253,11 @@ mem_initcall(omap3evm_mem_init);
>  
>  static int omap3evm_init_devices(void)
>  {
> -#ifdef CONFIG_OMAP_GPMC
>  	/*
>  	 * WP is made high and WAIT1 active Low
>  	 */
>  	gpmc_generic_init(0x10);
> -#endif
> +
>  #ifdef CONFIG_MCI_OMAP_HSMMC
>  	add_generic_device("omap-hsmmc", -1, NULL, 
> OMAP_MMC1_BASE, SZ_4K,
>  				IORESOURCE_MEM, NULL);
> diff --git a/arch/arm/boards/phycard-a-l1/pca-a-l1.c 
> b/arch/arm/boards/phycard-a-l1/pca-a-l1.c
> index f7d3185..7a1196e 100644
> --- a/arch/arm/boards/phycard-a-l1/pca-a-l1.c
> +++ b/arch/arm/boards/phycard-a-l1/pca-a-l1.c
> @@ -288,13 +288,10 @@ static void pcaal1_setup_net_chip(void)
>  
>  static int pcaal1_mem_init(void)
>  {
> -
> -#ifdef CONFIG_OMAP_GPMC
>  	/*
>  	 * WP is made high and WAIT1 active Low
>  	 */
>  	gpmc_generic_init(0x10);
> -#endif
>  
>  	arm_add_mem_device("ram0", OMAP_SDRC_CS0, 
> get_sdr_cs_size(SDRC_CS0_OSET));
>  
> diff --git a/arch/arm/configs/panda_xload_defconfig 
> b/arch/arm/configs/panda_xload_defconfig
> index f8f0ae9..bdfbeb9 100644
> --- a/arch/arm/configs/panda_xload_defconfig
> +++ b/arch/arm/configs/panda_xload_defconfig
> @@ -1,6 +1,5 @@
>  CONFIG_ARCH_OMAP=y
>  CONFIG_ARCH_OMAP4=y
> -# CONFIG_OMAP_GPMC is not set
>  CONFIG_OMAP_BUILD_IFT=y
>  CONFIG_AEABI=y
>  # CONFIG_CMD_ARM_CPUINFO is not set
> diff --git a/arch/arm/configs/phycard_a_l1_defconfig 
> b/arch/arm/configs/phycard_a_l1_defconfig
> index 95dffbb..9ccf43d 100644
> --- a/arch/arm/configs/phycard_a_l1_defconfig
> +++ b/arch/arm/configs/phycard_a_l1_defconfig
> @@ -11,7 +11,6 @@ CONFIG_OMAP_CLOCK_ALL=y
>  CONFIG_OMAP_CLOCK_SOURCE_S32K=y
>  CONFIG_OMAP3_CLOCK_CONFIG=y
>  CONFIG_OMAP3_COPY_CLOCK_SRAM=n
> -CONFIG_OMAP_GPMC=y
>  CONFIG_MACH_PCAAL1=y
>  CONFIG_HAS_OMAP_NAND=y
>  CONFIG_AEABI=y
> diff --git a/arch/arm/mach-omap/Kconfig b/arch/arm/mach-omap/Kconfig
> index 50f53dd..11b9661 100644
> --- a/arch/arm/mach-omap/Kconfig
> +++ b/arch/arm/mach-omap/Kconfig
> @@ -77,16 +77,6 @@ config OMAP3_CLOCK_CONFIG
>  	help
>  	  Say Y here if you like to have OMAP3 Clock configuration done.
>  
> -config OMAP_GPMC
> -	prompt "Support for GPMC configuration"
> -	bool
> -	depends on  (ARCH_OMAP2 || ARCH_OMAP3 || ARCH_OMAP4)
> -	default y
> -	help
> -	  Enable this if you use Texas Instrument's General 
> purpose Memory
> -	  Controller(GPMC). GPMC allows you to configure 
> devices such as NOR,
> -	  NAND, OneNAND etc.
> -
>  config OMAP_BUILD_IFT
>  	prompt "build ift binary"
>  	bool
> diff --git a/arch/arm/mach-omap/Makefile b/arch/arm/mach-omap/Makefile
> index 87078ae..26d3f7d 100644
> --- a/arch/arm/mach-omap/Makefile
> +++ b/arch/arm/mach-omap/Makefile
> @@ -24,7 +24,6 @@ obj-$(CONFIG_OMAP_CLOCK_SOURCE_S32K) += 
> s32k_clksource.o
>  obj-$(CONFIG_ARCH_OMAP3) += omap3_core.o omap3_generic.o auxcr.o
>  obj-$(CONFIG_ARCH_OMAP4) += omap4_generic.o omap4_clock.o
>  obj-$(CONFIG_OMAP3_CLOCK_CONFIG) += omap3_clock.o
> -obj-$(CONFIG_OMAP_GPMC) += gpmc.o devices-gpmc-nand.o
>  obj-$(CONFIG_SHELL_NONE) += xload.o
>  obj-$(CONFIG_I2C_TWL6030) += omap4_twl6030_mmc.o
> -obj-y += gpio.o
> +obj-y += gpio.o gpmc.o devices-gpmc-nand.o
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 926a64b..d846ce0 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -55,7 +55,6 @@ config NAND_IMX
>  
>  config NAND_OMAP_GPMC
>  	tristate "NAND Flash Support for GPMC based OMAP platforms"
> -	depends on OMAP_GPMC
>  	help
>  	 Support for NAND flash using GPMC. GPMC is a common memory
>  	 interface found on Texas Instrument's OMAP platforms
> -- 

The config option helps in reducing the extra code being built into
the "xload" configurations - where the size matters.

Instead of making this change, I suggest you add this in the defconfig
for pandaboard:
CONFIG_OMAP_GPMC=y

It is much smaller change.

~sanjeev

> 1.7.5.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
  2012-02-01  9:32 ` [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage Premi, Sanjeev
@ 2012-02-01 10:16   ` Belisko Marek
  2012-02-01 11:05     ` Premi, Sanjeev
  0 siblings, 1 reply; 12+ messages in thread
From: Belisko Marek @ 2012-02-01 10:16 UTC (permalink / raw)
  To: Premi, Sanjeev; +Cc: barebox

On Wed, Feb 1, 2012 at 10:32 AM, Premi, Sanjeev <premi@ti.com> wrote:
>> -----Original Message-----
>> From: barebox-bounces@lists.infradead.org
>> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of
>> Marek Belisko
>> Sent: Wednesday, February 01, 2012 2:21 AM
>> To: barebox@lists.infradead.org
>> Cc: Marek Belisko
>> Subject: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
>>
>> Build for omap platform by default.
>>
>> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> ---
>>  arch/arm/boards/beagle/board.c          |    4 ++--
>>  arch/arm/boards/omap343xdsp/board.c     |    2 --
>>  arch/arm/boards/omap3evm/board.c        |    3 +--
>>  arch/arm/boards/phycard-a-l1/pca-a-l1.c |    3 ---
>>  arch/arm/configs/panda_xload_defconfig  |    1 -
>>  arch/arm/configs/phycard_a_l1_defconfig |    1 -
>>  arch/arm/mach-omap/Kconfig              |   10 ----------
>>  arch/arm/mach-omap/Makefile             |    3 +--
>>  drivers/mtd/nand/Kconfig                |    1 -
>>  9 files changed, 4 insertions(+), 24 deletions(-)
>>
>> diff --git a/arch/arm/boards/beagle/board.c
>> b/arch/arm/boards/beagle/board.c
>> index faeaf8e..caeb578 100644
>> --- a/arch/arm/boards/beagle/board.c
>> +++ b/arch/arm/boards/beagle/board.c
>> @@ -302,10 +302,10 @@ static int beagle_devices_init(void)
>>               add_usb_ehci_device(-1, OMAP_EHCI_BASE,
>>                                   OMAP_EHCI_BASE + 0x10, &ehci_pdata);
>>  #endif /* CONFIG_USB_EHCI_OMAP */
>> -#ifdef CONFIG_OMAP_GPMC
>> +
>>       /* WP is made high and WAIT1 active Low */
>>       gpmc_generic_init(0x10);
>> -#endif
>> +
>>       gpmc_generic_nand_devices_init(0, 16,
>> OMAP_ECC_HAMMING_CODE_HW_ROMCODE);
>>
>>       add_generic_device("omap-hsmmc", -1, NULL,
>> OMAP_MMC1_BASE, SZ_4K,
>> diff --git a/arch/arm/boards/omap343xdsp/board.c
>> b/arch/arm/boards/omap343xdsp/board.c
>> index 4ad6f13..4cf6f31 100644
>> --- a/arch/arm/boards/omap343xdsp/board.c
>> +++ b/arch/arm/boards/omap343xdsp/board.c
>> @@ -641,10 +641,8 @@ mem_initcall(sdp3430_mem_init);
>>
>>  static int sdp3430_devices_init(void)
>>  {
>> -#ifdef CONFIG_OMAP_GPMC
>>       /* WP is made high and WAIT1 active Low */
>>       gpmc_generic_init(0x10);
>> -#endif
>>
>>       return 0;
>>  }
>> diff --git a/arch/arm/boards/omap3evm/board.c
>> b/arch/arm/boards/omap3evm/board.c
>> index fdd5227..ffcb6a6 100644
>> --- a/arch/arm/boards/omap3evm/board.c
>> +++ b/arch/arm/boards/omap3evm/board.c
>> @@ -253,12 +253,11 @@ mem_initcall(omap3evm_mem_init);
>>
>>  static int omap3evm_init_devices(void)
>>  {
>> -#ifdef CONFIG_OMAP_GPMC
>>       /*
>>        * WP is made high and WAIT1 active Low
>>        */
>>       gpmc_generic_init(0x10);
>> -#endif
>> +
>>  #ifdef CONFIG_MCI_OMAP_HSMMC
>>       add_generic_device("omap-hsmmc", -1, NULL,
>> OMAP_MMC1_BASE, SZ_4K,
>>                               IORESOURCE_MEM, NULL);
>> diff --git a/arch/arm/boards/phycard-a-l1/pca-a-l1.c
>> b/arch/arm/boards/phycard-a-l1/pca-a-l1.c
>> index f7d3185..7a1196e 100644
>> --- a/arch/arm/boards/phycard-a-l1/pca-a-l1.c
>> +++ b/arch/arm/boards/phycard-a-l1/pca-a-l1.c
>> @@ -288,13 +288,10 @@ static void pcaal1_setup_net_chip(void)
>>
>>  static int pcaal1_mem_init(void)
>>  {
>> -
>> -#ifdef CONFIG_OMAP_GPMC
>>       /*
>>        * WP is made high and WAIT1 active Low
>>        */
>>       gpmc_generic_init(0x10);
>> -#endif
>>
>>       arm_add_mem_device("ram0", OMAP_SDRC_CS0,
>> get_sdr_cs_size(SDRC_CS0_OSET));
>>
>> diff --git a/arch/arm/configs/panda_xload_defconfig
>> b/arch/arm/configs/panda_xload_defconfig
>> index f8f0ae9..bdfbeb9 100644
>> --- a/arch/arm/configs/panda_xload_defconfig
>> +++ b/arch/arm/configs/panda_xload_defconfig
>> @@ -1,6 +1,5 @@
>>  CONFIG_ARCH_OMAP=y
>>  CONFIG_ARCH_OMAP4=y
>> -# CONFIG_OMAP_GPMC is not set
>>  CONFIG_OMAP_BUILD_IFT=y
>>  CONFIG_AEABI=y
>>  # CONFIG_CMD_ARM_CPUINFO is not set
>> diff --git a/arch/arm/configs/phycard_a_l1_defconfig
>> b/arch/arm/configs/phycard_a_l1_defconfig
>> index 95dffbb..9ccf43d 100644
>> --- a/arch/arm/configs/phycard_a_l1_defconfig
>> +++ b/arch/arm/configs/phycard_a_l1_defconfig
>> @@ -11,7 +11,6 @@ CONFIG_OMAP_CLOCK_ALL=y
>>  CONFIG_OMAP_CLOCK_SOURCE_S32K=y
>>  CONFIG_OMAP3_CLOCK_CONFIG=y
>>  CONFIG_OMAP3_COPY_CLOCK_SRAM=n
>> -CONFIG_OMAP_GPMC=y
>>  CONFIG_MACH_PCAAL1=y
>>  CONFIG_HAS_OMAP_NAND=y
>>  CONFIG_AEABI=y
>> diff --git a/arch/arm/mach-omap/Kconfig b/arch/arm/mach-omap/Kconfig
>> index 50f53dd..11b9661 100644
>> --- a/arch/arm/mach-omap/Kconfig
>> +++ b/arch/arm/mach-omap/Kconfig
>> @@ -77,16 +77,6 @@ config OMAP3_CLOCK_CONFIG
>>       help
>>         Say Y here if you like to have OMAP3 Clock configuration done.
>>
>> -config OMAP_GPMC
>> -     prompt "Support for GPMC configuration"
>> -     bool
>> -     depends on  (ARCH_OMAP2 || ARCH_OMAP3 || ARCH_OMAP4)
>> -     default y
>> -     help
>> -       Enable this if you use Texas Instrument's General
>> purpose Memory
>> -       Controller(GPMC). GPMC allows you to configure
>> devices such as NOR,
>> -       NAND, OneNAND etc.
>> -
>>  config OMAP_BUILD_IFT
>>       prompt "build ift binary"
>>       bool
>> diff --git a/arch/arm/mach-omap/Makefile b/arch/arm/mach-omap/Makefile
>> index 87078ae..26d3f7d 100644
>> --- a/arch/arm/mach-omap/Makefile
>> +++ b/arch/arm/mach-omap/Makefile
>> @@ -24,7 +24,6 @@ obj-$(CONFIG_OMAP_CLOCK_SOURCE_S32K) +=
>> s32k_clksource.o
>>  obj-$(CONFIG_ARCH_OMAP3) += omap3_core.o omap3_generic.o auxcr.o
>>  obj-$(CONFIG_ARCH_OMAP4) += omap4_generic.o omap4_clock.o
>>  obj-$(CONFIG_OMAP3_CLOCK_CONFIG) += omap3_clock.o
>> -obj-$(CONFIG_OMAP_GPMC) += gpmc.o devices-gpmc-nand.o
>>  obj-$(CONFIG_SHELL_NONE) += xload.o
>>  obj-$(CONFIG_I2C_TWL6030) += omap4_twl6030_mmc.o
>> -obj-y += gpio.o
>> +obj-y += gpio.o gpmc.o devices-gpmc-nand.o
>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index 926a64b..d846ce0 100644
>> --- a/drivers/mtd/nand/Kconfig
>> +++ b/drivers/mtd/nand/Kconfig
>> @@ -55,7 +55,6 @@ config NAND_IMX
>>
>>  config NAND_OMAP_GPMC
>>       tristate "NAND Flash Support for GPMC based OMAP platforms"
>> -     depends on OMAP_GPMC
>>       help
>>        Support for NAND flash using GPMC. GPMC is a common memory
>>        interface found on Texas Instrument's OMAP platforms
>> --
>
> The config option helps in reducing the extra code being built into
> the "xload" configurations - where the size matters.
>
> Instead of making this change, I suggest you add this in the defconfig
> for pandaboard:
> CONFIG_OMAP_GPMC=y
>
> It is much smaller change.
GPMC is common for omap platform so I don't see a benefit to add user
possibility to disable it and
then make his board un-bootable. Solution was proposed by Sascha :
http://www.spinics.net/lists/u-boot-v2/msg05897.html

>
> ~sanjeev
>
>> 1.7.5.4
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>

regards,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
  2012-02-01 10:16   ` Belisko Marek
@ 2012-02-01 11:05     ` Premi, Sanjeev
  2012-02-01 11:09       ` Belisko Marek
  2012-02-01 13:51       ` Sascha Hauer
  0 siblings, 2 replies; 12+ messages in thread
From: Premi, Sanjeev @ 2012-02-01 11:05 UTC (permalink / raw)
  To: Belisko Marek; +Cc: barebox


> -----Original Message-----
> From: Belisko Marek [mailto:marek.belisko@gmail.com] 
> Sent: Wednesday, February 01, 2012 3:46 PM
> To: Premi, Sanjeev
> Cc: barebox@lists.infradead.org
> Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> 
> On Wed, Feb 1, 2012 at 10:32 AM, Premi, Sanjeev <premi@ti.com> wrote:
> >> -----Original Message-----
> >> From: barebox-bounces@lists.infradead.org
> >> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of
> >> Marek Belisko
> >> Sent: Wednesday, February 01, 2012 2:21 AM
> >> To: barebox@lists.infradead.org
> >> Cc: Marek Belisko
> >> Subject: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> >>
> >> Build for omap platform by default.
> >>
> >> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> >> ---
> >>  arch/arm/boards/beagle/board.c          |    4 ++--
> >>  arch/arm/boards/omap343xdsp/board.c     |    2 --
> >>  arch/arm/boards/omap3evm/board.c        |    3 +--
> >>  arch/arm/boards/phycard-a-l1/pca-a-l1.c |    3 ---
> >>  arch/arm/configs/panda_xload_defconfig  |    1 -
> >>  arch/arm/configs/phycard_a_l1_defconfig |    1 -
> >>  arch/arm/mach-omap/Kconfig              |   10 ----------
> >>  arch/arm/mach-omap/Makefile             |    3 +--
> >>  drivers/mtd/nand/Kconfig                |    1 -
> >>  9 files changed, 4 insertions(+), 24 deletions(-)
> >>

[snip]...[snip]

> > The config option helps in reducing the extra code being built into
> > the "xload" configurations - where the size matters.
> >
> > Instead of making this change, I suggest you add this in 
> the defconfig
> > for pandaboard:
> > CONFIG_OMAP_GPMC=y
> >
> > It is much smaller change.
> GPMC is common for omap platform so I don't see a benefit to add user
> possibility to disable it and
> then make his board un-bootable. Solution was proposed by Sascha :
> http://www.spinics.net/lists/u-boot-v2/msg05897.html

I missed this discussion, but if in the early boot stages we aren't
concerned about the devices on GPMC, then we shouldn't be initializing it.

I don't have code in front of me, so can't say whether this is the
case for xload configurations today - but I am assuming this was the
original intent of having this option.

On OMAP3EVM, GPMC needs to be configured only if NAND and Ethernet are
used. Else, the init can easily be skipped.

In patch 2/2 you mentioned about the kernel crash.
Can you share the crash log?
(or point me to a post which already has it)

~sanjeev

> 
> >
> > ~sanjeev
> >
> >> 1.7.5.4
> >>
> >>
> >> _______________________________________________
> >> barebox mailing list
> >> barebox@lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/barebox
> >>
> 
> regards,
> 
> marek
> 
> -- 
> as simple and primitive as possible
> -------------------------------------------------
> Marek Belisko - OPEN-NANDRA
> Freelance Developer
> 
> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> Tel: +421 915 052 184
> skype: marekwhite
> twitter: #opennandra
> web: http://open-nandra.com
> 
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
  2012-02-01 11:05     ` Premi, Sanjeev
@ 2012-02-01 11:09       ` Belisko Marek
  2012-02-01 13:52         ` Premi, Sanjeev
  2012-02-01 13:51       ` Sascha Hauer
  1 sibling, 1 reply; 12+ messages in thread
From: Belisko Marek @ 2012-02-01 11:09 UTC (permalink / raw)
  To: Premi, Sanjeev; +Cc: barebox

On Wed, Feb 1, 2012 at 12:05 PM, Premi, Sanjeev <premi@ti.com> wrote:
>
>> -----Original Message-----
>> From: Belisko Marek [mailto:marek.belisko@gmail.com]
>> Sent: Wednesday, February 01, 2012 3:46 PM
>> To: Premi, Sanjeev
>> Cc: barebox@lists.infradead.org
>> Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
>>
>> On Wed, Feb 1, 2012 at 10:32 AM, Premi, Sanjeev <premi@ti.com> wrote:
>> >> -----Original Message-----
>> >> From: barebox-bounces@lists.infradead.org
>> >> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of
>> >> Marek Belisko
>> >> Sent: Wednesday, February 01, 2012 2:21 AM
>> >> To: barebox@lists.infradead.org
>> >> Cc: Marek Belisko
>> >> Subject: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
>> >>
>> >> Build for omap platform by default.
>> >>
>> >> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> >> ---
>> >>  arch/arm/boards/beagle/board.c          |    4 ++--
>> >>  arch/arm/boards/omap343xdsp/board.c     |    2 --
>> >>  arch/arm/boards/omap3evm/board.c        |    3 +--
>> >>  arch/arm/boards/phycard-a-l1/pca-a-l1.c |    3 ---
>> >>  arch/arm/configs/panda_xload_defconfig  |    1 -
>> >>  arch/arm/configs/phycard_a_l1_defconfig |    1 -
>> >>  arch/arm/mach-omap/Kconfig              |   10 ----------
>> >>  arch/arm/mach-omap/Makefile             |    3 +--
>> >>  drivers/mtd/nand/Kconfig                |    1 -
>> >>  9 files changed, 4 insertions(+), 24 deletions(-)
>> >>
>
> [snip]...[snip]
>
>> > The config option helps in reducing the extra code being built into
>> > the "xload" configurations - where the size matters.
>> >
>> > Instead of making this change, I suggest you add this in
>> the defconfig
>> > for pandaboard:
>> > CONFIG_OMAP_GPMC=y
>> >
>> > It is much smaller change.
>> GPMC is common for omap platform so I don't see a benefit to add user
>> possibility to disable it and
>> then make his board un-bootable. Solution was proposed by Sascha :
>> http://www.spinics.net/lists/u-boot-v2/msg05897.html
>
> I missed this discussion, but if in the early boot stages we aren't
> concerned about the devices on GPMC, then we shouldn't be initializing it.
>
> I don't have code in front of me, so can't say whether this is the
> case for xload configurations today - but I am assuming this was the
> original intent of having this option.
>
> On OMAP3EVM, GPMC needs to be configured only if NAND and Ethernet are
> used. Else, the init can easily be skipped.
>
> In patch 2/2 you mentioned about the kernel crash.
> Can you share the crash log?
> (or point me to a post which already has it)
Crash is here:
http://www.spinics.net/lists/u-boot-v2/msg05887.html
>
> ~sanjeev
>
>>
>> >
>> > ~sanjeev
>> >
>> >> 1.7.5.4
>> >>
>> >>
>> >> _______________________________________________
>> >> barebox mailing list
>> >> barebox@lists.infradead.org
>> >> http://lists.infradead.org/mailman/listinfo/barebox
>> >>
>>
>> regards,
>>
>> marek
>>
>> --
>> as simple and primitive as possible
>> -------------------------------------------------
>> Marek Belisko - OPEN-NANDRA
>> Freelance Developer
>>
>> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
>> Tel: +421 915 052 184
>> skype: marekwhite
>> twitter: #opennandra
>> web: http://open-nandra.com
>>

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
  2012-02-01 11:05     ` Premi, Sanjeev
  2012-02-01 11:09       ` Belisko Marek
@ 2012-02-01 13:51       ` Sascha Hauer
  2012-02-01 14:10         ` Premi, Sanjeev
  1 sibling, 1 reply; 12+ messages in thread
From: Sascha Hauer @ 2012-02-01 13:51 UTC (permalink / raw)
  To: Premi, Sanjeev; +Cc: barebox

On Wed, Feb 01, 2012 at 11:05:20AM +0000, Premi, Sanjeev wrote:
> 
> > -----Original Message-----
> > From: Belisko Marek [mailto:marek.belisko@gmail.com] 
> > Sent: Wednesday, February 01, 2012 3:46 PM
> > To: Premi, Sanjeev
> > Cc: barebox@lists.infradead.org
> > Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> > 
> > On Wed, Feb 1, 2012 at 10:32 AM, Premi, Sanjeev <premi@ti.com> wrote:
> > >> -----Original Message-----
> > >> From: barebox-bounces@lists.infradead.org
> > >> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of
> > >> Marek Belisko
> > >> Sent: Wednesday, February 01, 2012 2:21 AM
> > >> To: barebox@lists.infradead.org
> > >> Cc: Marek Belisko
> > >> Subject: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> > >>
> > >> Build for omap platform by default.
> > >>
> > >> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> > >> ---
> > >>  arch/arm/boards/beagle/board.c          |    4 ++--
> > >>  arch/arm/boards/omap343xdsp/board.c     |    2 --
> > >>  arch/arm/boards/omap3evm/board.c        |    3 +--
> > >>  arch/arm/boards/phycard-a-l1/pca-a-l1.c |    3 ---
> > >>  arch/arm/configs/panda_xload_defconfig  |    1 -
> > >>  arch/arm/configs/phycard_a_l1_defconfig |    1 -
> > >>  arch/arm/mach-omap/Kconfig              |   10 ----------
> > >>  arch/arm/mach-omap/Makefile             |    3 +--
> > >>  drivers/mtd/nand/Kconfig                |    1 -
> > >>  9 files changed, 4 insertions(+), 24 deletions(-)
> > >>
> 
> [snip]...[snip]
> 
> > > The config option helps in reducing the extra code being built into
> > > the "xload" configurations - where the size matters.
> > >
> > > Instead of making this change, I suggest you add this in 
> > the defconfig
> > > for pandaboard:
> > > CONFIG_OMAP_GPMC=y
> > >
> > > It is much smaller change.

Yes, the change is smaller, but we show an option to the user which
he better not changes. It's better to just not ask questions which
have only one reasonable answer.

> > GPMC is common for omap platform so I don't see a benefit to add user
> > possibility to disable it and
> > then make his board un-bootable. Solution was proposed by Sascha :
> > http://www.spinics.net/lists/u-boot-v2/msg05897.html
> 
> I missed this discussion, but if in the early boot stages we aren't
> concerned about the devices on GPMC, then we shouldn't be initializing it.

I generally agree, but we are talking about a few writel here, it
shouldn't add more than a few bytes to the binary.

> 
> I don't have code in front of me, so can't say whether this is the
> case for xload configurations today - but I am assuming this was the
> original intent of having this option.
> 
> On OMAP3EVM, GPMC needs to be configured only if NAND and Ethernet are
> used. Else, the init can easily be skipped.
> 
> In patch 2/2 you mentioned about the kernel crash.
> Can you share the crash log?
> (or point me to a post which already has it)

The right(tm) fix is probably to fix this in the Kernel to not depend
on the bootloader.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
  2012-02-01 11:09       ` Belisko Marek
@ 2012-02-01 13:52         ` Premi, Sanjeev
  0 siblings, 0 replies; 12+ messages in thread
From: Premi, Sanjeev @ 2012-02-01 13:52 UTC (permalink / raw)
  To: Belisko Marek; +Cc: barebox

> -----Original Message-----
> From: Belisko Marek [mailto:marek.belisko@gmail.com] 
> Sent: Wednesday, February 01, 2012 4:40 PM
> To: Premi, Sanjeev
> Cc: barebox@lists.infradead.org
> Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> 
> On Wed, Feb 1, 2012 at 12:05 PM, Premi, Sanjeev <premi@ti.com> wrote:
> >
> >> -----Original Message-----
> >> From: Belisko Marek [mailto:marek.belisko@gmail.com]
> >> Sent: Wednesday, February 01, 2012 3:46 PM
> >> To: Premi, Sanjeev
> >> Cc: barebox@lists.infradead.org
> >> Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> >>
> >> On Wed, Feb 1, 2012 at 10:32 AM, Premi, Sanjeev 
> <premi@ti.com> wrote:
> >> >> -----Original Message-----
> >> >> From: barebox-bounces@lists.infradead.org
> >> >> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of
> >> >> Marek Belisko
> >> >> Sent: Wednesday, February 01, 2012 2:21 AM
> >> >> To: barebox@lists.infradead.org
> >> >> Cc: Marek Belisko
> >> >> Subject: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> >> >>
> >> >> Build for omap platform by default.
> >> >>
> >> >> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> >> >> ---
> >> >>  arch/arm/boards/beagle/board.c          |    4 ++--
> >> >>  arch/arm/boards/omap343xdsp/board.c     |    2 --
> >> >>  arch/arm/boards/omap3evm/board.c        |    3 +--
> >> >>  arch/arm/boards/phycard-a-l1/pca-a-l1.c |    3 ---
> >> >>  arch/arm/configs/panda_xload_defconfig  |    1 -
> >> >>  arch/arm/configs/phycard_a_l1_defconfig |    1 -
> >> >>  arch/arm/mach-omap/Kconfig              |   10 ----------
> >> >>  arch/arm/mach-omap/Makefile             |    3 +--
> >> >>  drivers/mtd/nand/Kconfig                |    1 -
> >> >>  9 files changed, 4 insertions(+), 24 deletions(-)
> >> >>
> >
> > [snip]...[snip]
> >
> >> > The config option helps in reducing the extra code being 
> built into
> >> > the "xload" configurations - where the size matters.
> >> >
> >> > Instead of making this change, I suggest you add this in
> >> the defconfig
> >> > for pandaboard:
> >> > CONFIG_OMAP_GPMC=y
> >> >
> >> > It is much smaller change.
> >> GPMC is common for omap platform so I don't see a benefit 
> to add user
> >> possibility to disable it and
> >> then make his board un-bootable. Solution was proposed by Sascha :
> >> http://www.spinics.net/lists/u-boot-v2/msg05897.html
> >
> > I missed this discussion, but if in the early boot stages we aren't
> > concerned about the devices on GPMC, then we shouldn't be 
> initializing it.
> >
> > I don't have code in front of me, so can't say whether this is the
> > case for xload configurations today - but I am assuming this was the
> > original intent of having this option.
> >
> > On OMAP3EVM, GPMC needs to be configured only if NAND and 
> Ethernet are
> > used. Else, the init can easily be skipped.
> >
> > In patch 2/2 you mentioned about the kernel crash.
> > Can you share the crash log?
> > (or point me to a post which already has it)
> Crash is here:
> http://www.spinics.net/lists/u-boot-v2/msg05887.html

I can't be very certain without trying, but I suspect
that the crash is due the BUG() in this snippet 
[function gpmc_mem_init]:

        /* Reserve all regions that has been set up by bootloader */
        for (cs = 0; cs < GPMC_CS_NUM; cs++) {
                u32 base, size;

                if (!gpmc_cs_mem_enabled(cs))
                        continue;
                gpmc_cs_get_memconf(cs, &base, &size);
                if (gpmc_cs_insert_mem(cs, base, size) < 0)
                        BUG();
        }

In barebox, gpmc_generic_init(0x00) is makes GPMC_CONFIG
as 0x00 and sets GPMC_CONFIG7_i (i = 0 to 7) as 0x00
making CS0 "disabled" - which is enabled on reset for OMAP3
(expect same for OMAP4 as well). All other CS are "disabled"
on reset.

This disables CS0 as well, making gpmc_cs_mem_enabled(cs)
return false. (May be expected for Pandaboard).

If so, I still feel, the code could easily be left out from
the xload configs. But if it has to included, 136 bytes from
gpmc.o may not be as big penalty.

~sanjeev


> >
> > ~sanjeev
> >
> >>
> >> >
> >> > ~sanjeev
> >> >
> >> >> 1.7.5.4
> >> >>
> >> >>
> >> >> _______________________________________________
> >> >> barebox mailing list
> >> >> barebox@lists.infradead.org
> >> >> http://lists.infradead.org/mailman/listinfo/barebox
> >> >>
> >>
> >> regards,
> >>
> >> marek
> >>
> >> --
> >> as simple and primitive as possible
> >> -------------------------------------------------
> >> Marek Belisko - OPEN-NANDRA
> >> Freelance Developer
> >>
> >> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> >> Tel: +421 915 052 184
> >> skype: marekwhite
> >> twitter: #opennandra
> >> web: http://open-nandra.com
> >>
> 
> marek
> 
> -- 
> as simple and primitive as possible
> -------------------------------------------------
> Marek Belisko - OPEN-NANDRA
> Freelance Developer
> 
> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> Tel: +421 915 052 184
> skype: marekwhite
> twitter: #opennandra
> web: http://open-nandra.com
> 
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
  2012-02-01 13:51       ` Sascha Hauer
@ 2012-02-01 14:10         ` Premi, Sanjeev
  2012-02-07 20:22           ` Belisko Marek
  0 siblings, 1 reply; 12+ messages in thread
From: Premi, Sanjeev @ 2012-02-01 14:10 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

> -----Original Message-----
> From: Sascha Hauer [mailto:s.hauer@pengutronix.de] 
> Sent: Wednesday, February 01, 2012 7:22 PM
> To: Premi, Sanjeev
> Cc: Belisko Marek; barebox@lists.infradead.org
> Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> 
> On Wed, Feb 01, 2012 at 11:05:20AM +0000, Premi, Sanjeev wrote:
> > 
> > > -----Original Message-----
> > > From: Belisko Marek [mailto:marek.belisko@gmail.com] 
> > > Sent: Wednesday, February 01, 2012 3:46 PM
> > > To: Premi, Sanjeev
> > > Cc: barebox@lists.infradead.org
> > > Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> > > 
> > > On Wed, Feb 1, 2012 at 10:32 AM, Premi, Sanjeev 
> <premi@ti.com> wrote:
> > > >> -----Original Message-----
> > > >> From: barebox-bounces@lists.infradead.org
> > > >> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of
> > > >> Marek Belisko
> > > >> Sent: Wednesday, February 01, 2012 2:21 AM
> > > >> To: barebox@lists.infradead.org
> > > >> Cc: Marek Belisko
> > > >> Subject: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
> > > >>
> > > >> Build for omap platform by default.
> > > >>
> > > >> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> > > >> ---
> > > >>  arch/arm/boards/beagle/board.c          |    4 ++--
> > > >>  arch/arm/boards/omap343xdsp/board.c     |    2 --
> > > >>  arch/arm/boards/omap3evm/board.c        |    3 +--
> > > >>  arch/arm/boards/phycard-a-l1/pca-a-l1.c |    3 ---
> > > >>  arch/arm/configs/panda_xload_defconfig  |    1 -
> > > >>  arch/arm/configs/phycard_a_l1_defconfig |    1 -
> > > >>  arch/arm/mach-omap/Kconfig              |   10 ----------
> > > >>  arch/arm/mach-omap/Makefile             |    3 +--
> > > >>  drivers/mtd/nand/Kconfig                |    1 -
> > > >>  9 files changed, 4 insertions(+), 24 deletions(-)
> > > >>
> > 
> > [snip]...[snip]
> > 
> > > > The config option helps in reducing the extra code 
> being built into
> > > > the "xload" configurations - where the size matters.
> > > >
> > > > Instead of making this change, I suggest you add this in 
> > > the defconfig
> > > > for pandaboard:
> > > > CONFIG_OMAP_GPMC=y
> > > >
> > > > It is much smaller change.
> 
> Yes, the change is smaller, but we show an option to the user which
> he better not changes. It's better to just not ask questions which
> have only one reasonable answer.
> 
> > > GPMC is common for omap platform so I don't see a benefit 
> to add user
> > > possibility to disable it and
> > > then make his board un-bootable. Solution was proposed by Sascha :
> > > http://www.spinics.net/lists/u-boot-v2/msg05897.html
> > 
> > I missed this discussion, but if in the early boot stages we aren't
> > concerned about the devices on GPMC, then we shouldn't be 
> initializing it.
> 
> I generally agree, but we are talking about a few writel here, it
> shouldn't add more than a few bytes to the binary.
> 
> > 
> > I don't have code in front of me, so can't say whether this is the
> > case for xload configurations today - but I am assuming this was the
> > original intent of having this option.
> > 
> > On OMAP3EVM, GPMC needs to be configured only if NAND and 
> Ethernet are
> > used. Else, the init can easily be skipped.
> > 
> > In patch 2/2 you mentioned about the kernel crash.
> > Can you share the crash log?
> > (or point me to a post which already has it)
> 
> The right(tm) fix is probably to fix this in the Kernel to not depend
> on the bootloader.

Agree.

> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                  
>            |
> Industrial Linux Solutions                 | 
> http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: 
> +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   
> +49-5121-206917-5555 |
> 
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
  2012-02-01 14:10         ` Premi, Sanjeev
@ 2012-02-07 20:22           ` Belisko Marek
  0 siblings, 0 replies; 12+ messages in thread
From: Belisko Marek @ 2012-02-07 20:22 UTC (permalink / raw)
  To: Premi, Sanjeev; +Cc: barebox

On Wed, Feb 1, 2012 at 3:10 PM, Premi, Sanjeev <premi@ti.com> wrote:
>> -----Original Message-----
>> From: Sascha Hauer [mailto:s.hauer@pengutronix.de]
>> Sent: Wednesday, February 01, 2012 7:22 PM
>> To: Premi, Sanjeev
>> Cc: Belisko Marek; barebox@lists.infradead.org
>> Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
>>
>> On Wed, Feb 01, 2012 at 11:05:20AM +0000, Premi, Sanjeev wrote:
>> >
>> > > -----Original Message-----
>> > > From: Belisko Marek [mailto:marek.belisko@gmail.com]
>> > > Sent: Wednesday, February 01, 2012 3:46 PM
>> > > To: Premi, Sanjeev
>> > > Cc: barebox@lists.infradead.org
>> > > Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
>> > >
>> > > On Wed, Feb 1, 2012 at 10:32 AM, Premi, Sanjeev
>> <premi@ti.com> wrote:
>> > > >> -----Original Message-----
>> > > >> From: barebox-bounces@lists.infradead.org
>> > > >> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of
>> > > >> Marek Belisko
>> > > >> Sent: Wednesday, February 01, 2012 2:21 AM
>> > > >> To: barebox@lists.infradead.org
>> > > >> Cc: Marek Belisko
>> > > >> Subject: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
>> > > >>
>> > > >> Build for omap platform by default.
>> > > >>
>> > > >> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> > > >> ---
>> > > >>  arch/arm/boards/beagle/board.c          |    4 ++--
>> > > >>  arch/arm/boards/omap343xdsp/board.c     |    2 --
>> > > >>  arch/arm/boards/omap3evm/board.c        |    3 +--
>> > > >>  arch/arm/boards/phycard-a-l1/pca-a-l1.c |    3 ---
>> > > >>  arch/arm/configs/panda_xload_defconfig  |    1 -
>> > > >>  arch/arm/configs/phycard_a_l1_defconfig |    1 -
>> > > >>  arch/arm/mach-omap/Kconfig              |   10 ----------
>> > > >>  arch/arm/mach-omap/Makefile             |    3 +--
>> > > >>  drivers/mtd/nand/Kconfig                |    1 -
>> > > >>  9 files changed, 4 insertions(+), 24 deletions(-)
>> > > >>
>> >
>> > [snip]...[snip]
>> >
>> > > > The config option helps in reducing the extra code
>> being built into
>> > > > the "xload" configurations - where the size matters.
>> > > >
>> > > > Instead of making this change, I suggest you add this in
>> > > the defconfig
>> > > > for pandaboard:
>> > > > CONFIG_OMAP_GPMC=y
>> > > >
>> > > > It is much smaller change.
>>
>> Yes, the change is smaller, but we show an option to the user which
>> he better not changes. It's better to just not ask questions which
>> have only one reasonable answer.
>>
>> > > GPMC is common for omap platform so I don't see a benefit
>> to add user
>> > > possibility to disable it and
>> > > then make his board un-bootable. Solution was proposed by Sascha :
>> > > http://www.spinics.net/lists/u-boot-v2/msg05897.html
>> >
>> > I missed this discussion, but if in the early boot stages we aren't
>> > concerned about the devices on GPMC, then we shouldn't be
>> initializing it.
>>
>> I generally agree, but we are talking about a few writel here, it
>> shouldn't add more than a few bytes to the binary.
>>
>> >
>> > I don't have code in front of me, so can't say whether this is the
>> > case for xload configurations today - but I am assuming this was the
>> > original intent of having this option.
>> >
>> > On OMAP3EVM, GPMC needs to be configured only if NAND and
>> Ethernet are
>> > used. Else, the init can easily be skipped.
>> >
>> > In patch 2/2 you mentioned about the kernel crash.
>> > Can you share the crash log?
>> > (or point me to a post which already has it)
>>
>> The right(tm) fix is probably to fix this in the Kernel to not depend
>> on the bootloader.
>
> Agree.
Well I can send patch for kernel but not sure what should be changed ;).
Could anybody do this or give me a hint about solution?
Thanks.
>
>>
>> Sascha
>>
>> --
>> Pengutronix e.K.                           |
>>            |
>> Industrial Linux Solutions                 |
>> http://www.pengutronix.de/  |
>> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone:
>> +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:
>> +49-5121-206917-5555 |
>>

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] pandaboard: Add gpmc_generic_init to board init.
  2012-01-31 20:51 ` [PATCH 2/2] pandaboard: Add gpmc_generic_init to board init Marek Belisko
@ 2012-03-02  8:04   ` Jan Weitzel
  2012-03-03 12:11     ` Belisko Marek
  0 siblings, 1 reply; 12+ messages in thread
From: Jan Weitzel @ 2012-03-02  8:04 UTC (permalink / raw)
  To: Marek Belisko; +Cc: barebox

Am Dienstag, den 31.01.2012, 21:51 +0100 schrieb Marek Belisko:
> We need to setup generic gpmc otherwise kernel panic during boot.
> 
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
>  arch/arm/boards/panda/board.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boards/panda/board.c b/arch/arm/boards/panda/board.c
> index be3ad77..1c71545 100644
> --- a/arch/arm/boards/panda/board.c
> +++ b/arch/arm/boards/panda/board.c
> @@ -20,6 +20,7 @@
>  #include <mach/gpio.h>
>  #include <environment.h>
>  #include <mach/xload.h>
> +#include <mach/gpmc.h>
>  
>  static int board_revision;
>  
> @@ -137,6 +138,8 @@ static int panda_devices_init(void)
>  			   IORESOURCE_MEM, NULL);
>  	panda_ehci_init();
>  
> +	gpmc_generic_init(0x00);
> +

3.3.0-rc5 is still not booting without this patch. Using panda_defconfig
implicitly select CONFIG_OMAP_GPMC.

>  	armlinux_set_bootparams((void *)0x80000100);
>  	armlinux_set_architecture(MACH_TYPE_OMAP4_PANDA);
>  



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] pandaboard: Add gpmc_generic_init to board init.
  2012-03-02  8:04   ` Jan Weitzel
@ 2012-03-03 12:11     ` Belisko Marek
  0 siblings, 0 replies; 12+ messages in thread
From: Belisko Marek @ 2012-03-03 12:11 UTC (permalink / raw)
  To: J.Weitzel; +Cc: barebox

On Fri, Mar 2, 2012 at 9:04 AM, Jan Weitzel <J.Weitzel@phytec.de> wrote:
> Am Dienstag, den 31.01.2012, 21:51 +0100 schrieb Marek Belisko:
>> We need to setup generic gpmc otherwise kernel panic during boot.
>>
>> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> ---
>>  arch/arm/boards/panda/board.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boards/panda/board.c b/arch/arm/boards/panda/board.c
>> index be3ad77..1c71545 100644
>> --- a/arch/arm/boards/panda/board.c
>> +++ b/arch/arm/boards/panda/board.c
>> @@ -20,6 +20,7 @@
>>  #include <mach/gpio.h>
>>  #include <environment.h>
>>  #include <mach/xload.h>
>> +#include <mach/gpmc.h>
>>
>>  static int board_revision;
>>
>> @@ -137,6 +138,8 @@ static int panda_devices_init(void)
>>                          IORESOURCE_MEM, NULL);
>>       panda_ehci_init();
>>
>> +     gpmc_generic_init(0x00);
>> +
>
> 3.3.0-rc5 is still not booting without this patch. Using panda_defconfig
> implicitly select CONFIG_OMAP_GPMC.
There was discussion to fix kernel instead fixing barebox:
http://lists.infradead.org/pipermail/barebox/2012-February/005946.html
I don't have time to take a look and post proper fix so still using
that path in barebox.
Sorry.
>
>>       armlinux_set_bootparams((void *)0x80000100);
>>       armlinux_set_architecture(MACH_TYPE_OMAP4_PANDA);
>>
>
>

regards,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2012-03-03 12:11 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-31 20:51 [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage Marek Belisko
2012-01-31 20:51 ` [PATCH 2/2] pandaboard: Add gpmc_generic_init to board init Marek Belisko
2012-03-02  8:04   ` Jan Weitzel
2012-03-03 12:11     ` Belisko Marek
2012-02-01  9:32 ` [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage Premi, Sanjeev
2012-02-01 10:16   ` Belisko Marek
2012-02-01 11:05     ` Premi, Sanjeev
2012-02-01 11:09       ` Belisko Marek
2012-02-01 13:52         ` Premi, Sanjeev
2012-02-01 13:51       ` Sascha Hauer
2012-02-01 14:10         ` Premi, Sanjeev
2012-02-07 20:22           ` Belisko Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox