Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.

[Belisko Marek <marek.belisko@gmail.com>]

On Wed, Feb 1, 2012 at 12:05 PM, Premi, Sanjeev <premi@ti.com> wrote:
>
>> -----Original Message-----
>> From: Belisko Marek [mailto:marek.belisko@gmail.com]
>> Sent: Wednesday, February 01, 2012 3:46 PM
>> To: Premi, Sanjeev
>> Cc: barebox@lists.infradead.org
>> Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
>>
>> On Wed, Feb 1, 2012 at 10:32 AM, Premi, Sanjeev <premi@ti.com> wrote:
>> >> -----Original Message-----
>> >> From: barebox-bounces@lists.infradead.org
>> >> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of
>> >> Marek Belisko
>> >> Sent: Wednesday, February 01, 2012 2:21 AM
>> >> To: barebox@lists.infradead.org
>> >> Cc: Marek Belisko
>> >> Subject: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage.
>> >>
>> >> Build for omap platform by default.
>> >>
>> >> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> >> ---
>> >>  arch/arm/boards/beagle/board.c          |    4 ++--
>> >>  arch/arm/boards/omap343xdsp/board.c     |    2 --
>> >>  arch/arm/boards/omap3evm/board.c        |    3 +--
>> >>  arch/arm/boards/phycard-a-l1/pca-a-l1.c |    3 ---
>> >>  arch/arm/configs/panda_xload_defconfig  |    1 -
>> >>  arch/arm/configs/phycard_a_l1_defconfig |    1 -
>> >>  arch/arm/mach-omap/Kconfig              |   10 ----------
>> >>  arch/arm/mach-omap/Makefile             |    3 +--
>> >>  drivers/mtd/nand/Kconfig                |    1 -
>> >>  9 files changed, 4 insertions(+), 24 deletions(-)
>> >>
>
> [snip]...[snip]
>
>> > The config option helps in reducing the extra code being built into
>> > the "xload" configurations - where the size matters.
>> >
>> > Instead of making this change, I suggest you add this in
>> the defconfig
>> > for pandaboard:
>> > CONFIG_OMAP_GPMC=y
>> >
>> > It is much smaller change.
>> GPMC is common for omap platform so I don't see a benefit to add user
>> possibility to disable it and
>> then make his board un-bootable. Solution was proposed by Sascha :
>> http://www.spinics.net/lists/u-boot-v2/msg05897.html
>
> I missed this discussion, but if in the early boot stages we aren't
> concerned about the devices on GPMC, then we shouldn't be initializing it.
>
> I don't have code in front of me, so can't say whether this is the
> case for xload configurations today - but I am assuming this was the
> original intent of having this option.
>
> On OMAP3EVM, GPMC needs to be configured only if NAND and Ethernet are
> used. Else, the init can easily be skipped.
>
> In patch 2/2 you mentioned about the kernel crash.
> Can you share the crash log?
> (or point me to a post which already has it)
Crash is here:
http://www.spinics.net/lists/u-boot-v2/msg05887.html
>
> ~sanjeev
>
>>
>> >
>> > ~sanjeev
>> >
>> >> 1.7.5.4
>> >>
>> >>
>> >> _______________________________________________
>> >> barebox mailing list
>> >> barebox@lists.infradead.org
>> >> http://lists.infradead.org/mailman/listinfo/barebox
>> >>
>>
>> regards,
>>
>> marek
>>
>> --
>> as simple and primitive as possible
>> -------------------------------------------------
>> Marek Belisko - OPEN-NANDRA
>> Freelance Developer
>>
>> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
>> Tel: +421 915 052 184
>> skype: marekwhite
>> twitter: #opennandra
>> web: http://open-nandra.com
>>

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox