mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox <barebox@lists.infradead.org>, Marc Reilly <marc@cpdesign.com>
Subject: Re: [PATCH 7/9] barebox-data: add barebox-data sections
Date: Mon, 14 Jan 2013 11:39:23 +0100	[thread overview]
Message-ID: <CAB_54W4SYhtjcBgCdt20S7gACPXRn9a0Ogb1YO8R0By8skmq2w@mail.gmail.com> (raw)
In-Reply-To: <20130114095159.GE1906@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 2658 bytes --]

Hi,

You are right! Sry, about that.
I checked both values for regions overlapping with iomem. Both doesn't
overlapped(because align) but etext = .; is right.
Otherwise (for example in arm) "barebox" region is placed a little bit
in "barebox-data" region.

I draw a little graphics(some time ago) to demonstrate which variable from
which managment structure calc with 'inclusive' or 'exclusive' byte for
end-address. I attach them to this mail.


2013/1/14 Sascha Hauer <s.hauer@pengutronix.de>

> On Sun, Jan 13, 2013 at 06:42:21PM +0100, Alexander Aring wrote:
> > Add barebox-data section in arm branch to get complete
> > barebox regions in sdram regions tree.
> >
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> >  arch/arm/lib/barebox.lds.S                       | 6 +++++-
> >  arch/blackfin/boards/ipe337/barebox.lds.S        | 6 +++++-
> >  arch/mips/lib/barebox.lds.S                      | 5 ++++-
> >  arch/nios2/cpu/barebox.lds.S                     | 5 +++--
> >  arch/ppc/boards/freescale-p2020rdb/barebox.lds.S | 6 ++++--
> >  arch/ppc/boards/pcm030/barebox.lds.S             | 5 +++--
> >  arch/x86/lib/barebox.lds.S                       | 5 ++++-
> >  common/memory.c                                  | 4 ++++
> >  include/asm-generic/sections.h                   | 1 +
> >  9 files changed, 33 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm/lib/barebox.lds.S b/arch/arm/lib/barebox.lds.S
> > index bac1a04..6cad804 100644
> > --- a/arch/arm/lib/barebox.lds.S
> > +++ b/arch/arm/lib/barebox.lds.S
> > @@ -65,7 +65,9 @@ SECTIONS
> >               __stop_unwind_tab = .;
> >       }
> >  #endif
> > -     _etext = .;                     /* End of text and rodata section
> */
> > +     _etext = . - 1;                 /* End of text and rodata section
> */
>
> Is this correct? In 2/9 you explained that etext points to the next free
> memory location rather than to the last byte in the text segment. 2/9
> fixes the request_sdram_region call accordingly. Now it is changed to be
> the last byte of the text segment?
>
> > +
> > +     _sdata = .;
> >
> >       . = ALIGN(4);
> >       .data : { *(.data*) }
> > @@ -87,6 +89,8 @@ SECTIONS
> >       __usymtab : { BAREBOX_SYMS }
> >       __usymtab_end = .;
> >
> > +     _edata = . - 1;
>
> Should probably also be _edata = .;
>
> Sascha
>
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>

[-- Attachment #1.2: Type: text/html, Size: 3824 bytes --]

[-- Attachment #2: barebox_address.png --]
[-- Type: image/png, Size: 79356 bytes --]

[-- Attachment #3: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-01-14 10:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13 17:42 [PATCH 0/9] reimplement memtest command Alexander Aring
2013-01-13 17:42 ` [PATCH 1/9] meminfo: fix missing include Alexander Aring
2013-01-13 17:42 ` [PATCH 2/9] memory: fix size address calculation Alexander Aring
2013-01-13 17:42 ` [PATCH 3/9] meminfo: fix display of allocated addresses Alexander Aring
2013-01-13 17:42 ` [PATCH 4/9] arm-mmu: remove semicolon in arm mmu.c Alexander Aring
2013-01-13 17:42 ` [PATCH 5/9] mmu: make remap_range global accessable Alexander Aring
2013-01-13 17:42 ` [PATCH 6/9] memory: add function address_in_sdram_regions Alexander Aring
2013-01-13 17:42 ` [PATCH 7/9] barebox-data: add barebox-data sections Alexander Aring
2013-01-14  9:51   ` Sascha Hauer
2013-01-14 10:39     ` Alexander Aring [this message]
2013-01-13 17:42 ` [PATCH 8/9] memtest: remove memtest command Alexander Aring
2013-01-13 17:42 ` [PATCH 9/9] memtest: add rewritten " Alexander Aring
2013-01-14 13:11 ` [PATCH 0/9] reimplement " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAB_54W4SYhtjcBgCdt20S7gACPXRn9a0Ogb1YO8R0By8skmq2w@mail.gmail.com \
    --to=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=marc@cpdesign.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox