mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Raphaël Poggi" <raphio98@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mtd: atmel_nand: add SOFT_BCH support
Date: Thu, 17 Jul 2014 08:53:41 +0200	[thread overview]
Message-ID: <CACqcpZAN8dfmGMu0+G34a5j2+hhi2vju=Fm--eayTaKDqNkzzg@mail.gmail.com> (raw)
In-Reply-To: <20140717053050.GH23235@pengutronix.de>

Hi,

Thanks for applied, yes I changed the 20us to 40us for handle 8k page
NAND. I will send patchs about that.

2014-07-17 7:30 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> On Tue, Jul 15, 2014 at 11:16:40AM +0200, Raphael Poggi wrote:
>> To use soft ecc with nand with 8k page, we need the BCH support.
>> This commit adds the possibilty for atmel_nand to enable SOFT_BCH.
>>
>> Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
>> ---
>>  drivers/mtd/nand/atmel_nand.c |    5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
>> index e9b2af7..d542a83 100644
>> --- a/drivers/mtd/nand/atmel_nand.c
>> +++ b/drivers/mtd/nand/atmel_nand.c
>> @@ -1164,6 +1164,11 @@ static int __init atmel_nand_probe(struct device_d *dev)
>>               nand_chip->ecc.mode = NAND_ECC_HW;
>>       }
>>
>> +     if (IS_ENABLED(CONFIG_NAND_ECC_BCH) &&
>> +             pdata->ecc_mode == NAND_ECC_SOFT_BCH) {
>> +             nand_chip->ecc.mode = NAND_ECC_SOFT_BCH;
>> +     }
>> +
>>       nand_chip->chip_delay = 40;             /* 40us command delay time */
>
> The mainline code has 20us here. Do you need that change?
>
> Anyway, applied this patch.
>
> Sascha
>
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2014-07-17  6:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15  9:16 Raphael Poggi
2014-07-17  5:30 ` Sascha Hauer
2014-07-17  6:53   ` Raphaël Poggi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACqcpZAN8dfmGMu0+G34a5j2+hhi2vju=Fm--eayTaKDqNkzzg@mail.gmail.com' \
    --to=raphio98@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox