mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Raphaël Poggi" <poggi.raph@gmail.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] arm: at91: fix ecc_mode on non atmel boards
Date: Tue, 6 Jan 2015 13:36:09 +0100	[thread overview]
Message-ID: <CACqcpZAs1bB9KQ7qkLwLg_wmE21Q3=Cj0JNP9XPVyqDNqFD8+Q@mail.gmail.com> (raw)
In-Reply-To: <1420544226-30497-1-git-send-email-plagnioj@jcrosoft.com>

Good catch, I ACK this patch.

2015-01-06 12:37 GMT+01:00 Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com>:
> since
> commit 54bccadddd52cb4cbbecd1403b9091fe651bd0fd
> Author: Raphaël Poggi <poggi.raph@gmail.com>
>
>     mtd: atmel_nand: retrieve ecc_mode from pdata
>
> break most of the non atmel AT91 boards that did not provide a ecc_mode
> params in the nand pdata
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Raphaël Poggi <poggi.raph@gmail.com>
> ---
>  arch/arm/boards/animeo_ip/init.c      | 1 +
>  arch/arm/boards/pm9261/init.c         | 1 +
>  arch/arm/boards/pm9263/init.c         | 1 +
>  arch/arm/boards/pm9g45/init.c         | 1 +
>  arch/arm/boards/qil-a926x/init.c      | 1 +
>  arch/arm/boards/telit-evk-pro3/init.c | 2 ++
>  arch/arm/boards/tny-a926x/init.c      | 1 +
>  arch/arm/boards/usb-a926x/init.c      | 1 +
>  8 files changed, 9 insertions(+)
>
> diff --git a/arch/arm/boards/animeo_ip/init.c b/arch/arm/boards/animeo_ip/init.c
> index ca64d6d..495dc18 100644
> --- a/arch/arm/boards/animeo_ip/init.c
> +++ b/arch/arm/boards/animeo_ip/init.c
> @@ -93,6 +93,7 @@ static struct atmel_nand_data nand_pdata = {
>         .det_pin        = -EINVAL,
>         .rdy_pin        = AT91_PIN_PC13,
>         .enable_pin     = AT91_PIN_PC14,
> +       .ecc_mode       = NAND_ECC_SOFT,
>         .bus_width_16   = 0,
>         .on_flash_bbt   = 1,
>  };
> diff --git a/arch/arm/boards/pm9261/init.c b/arch/arm/boards/pm9261/init.c
> index 09d7f80..63f4f19 100644
> --- a/arch/arm/boards/pm9261/init.c
> +++ b/arch/arm/boards/pm9261/init.c
> @@ -50,6 +50,7 @@ static struct atmel_nand_data nand_pdata = {
>         .det_pin        = -EINVAL,
>         .rdy_pin        = AT91_PIN_PA16,
>         .enable_pin     = AT91_PIN_PC14,
> +       .ecc_mode       = NAND_ECC_SOFT,
>  #if defined(CONFIG_MTD_NAND_ATMEL_BUSWIDTH_16)
>         .bus_width_16   = 1,
>  #else
> diff --git a/arch/arm/boards/pm9263/init.c b/arch/arm/boards/pm9263/init.c
> index 3dca9e4..2b6b089 100644
> --- a/arch/arm/boards/pm9263/init.c
> +++ b/arch/arm/boards/pm9263/init.c
> @@ -50,6 +50,7 @@ static struct atmel_nand_data nand_pdata = {
>         .det_pin        = -EINVAL,
>         .rdy_pin        = AT91_PIN_PB30,
>         .enable_pin     = AT91_PIN_PD15,
> +       .ecc_mode       = NAND_ECC_SOFT,
>  #if defined(CONFIG_MTD_NAND_ATMEL_BUSWIDTH_16)
>         .bus_width_16   = 1,
>  #else
> diff --git a/arch/arm/boards/pm9g45/init.c b/arch/arm/boards/pm9g45/init.c
> index 1e43be5..524fe53 100644
> --- a/arch/arm/boards/pm9g45/init.c
> +++ b/arch/arm/boards/pm9g45/init.c
> @@ -49,6 +49,7 @@ static struct atmel_nand_data nand_pdata = {
>         .det_pin        = -EINVAL,
>         .rdy_pin        = AT91_PIN_PD3,
>         .enable_pin     = AT91_PIN_PC14,
> +       .ecc_mode       = NAND_ECC_SOFT,
>         .bus_width_16   = 0,
>         .on_flash_bbt   = 1,
>  };
> diff --git a/arch/arm/boards/qil-a926x/init.c b/arch/arm/boards/qil-a926x/init.c
> index 99a9604..4f01e2d 100644
> --- a/arch/arm/boards/qil-a926x/init.c
> +++ b/arch/arm/boards/qil-a926x/init.c
> @@ -43,6 +43,7 @@ static struct atmel_nand_data nand_pdata = {
>         .det_pin        = -EINVAL,
>         .rdy_pin        = AT91_PIN_PC13,
>         .enable_pin     = AT91_PIN_PC14,
> +       .ecc_mode       = NAND_ECC_SOFT,
>         .on_flash_bbt   = 1,
>  };
>
> diff --git a/arch/arm/boards/telit-evk-pro3/init.c b/arch/arm/boards/telit-evk-pro3/init.c
> index e094ea7..ea63b1a 100644
> --- a/arch/arm/boards/telit-evk-pro3/init.c
> +++ b/arch/arm/boards/telit-evk-pro3/init.c
> @@ -18,6 +18,7 @@
>  #include <gpio.h>
>  #include <init.h>
>  #include <linux/clk.h>
> +#include <linux/mtd/nand.h>
>  #include <mach/at91_rstc.h>
>  #include <mach/at91sam9_smc.h>
>  #include <mach/board.h>
> @@ -33,6 +34,7 @@ static struct atmel_nand_data nand_pdata = {
>         .det_pin        = -EINVAL,
>         .rdy_pin        = AT91_PIN_PC13,
>         .enable_pin     = AT91_PIN_PC14,
> +       .ecc_mode       = NAND_ECC_SOFT,
>         .on_flash_bbt   = 1,
>  };
>
> diff --git a/arch/arm/boards/tny-a926x/init.c b/arch/arm/boards/tny-a926x/init.c
> index ac86457..256f8ba 100644
> --- a/arch/arm/boards/tny-a926x/init.c
> +++ b/arch/arm/boards/tny-a926x/init.c
> @@ -55,6 +55,7 @@ static struct atmel_nand_data nand_pdata = {
>         .det_pin        = -EINVAL,
>         .rdy_pin        = AT91_PIN_PC13,
>         .enable_pin     = AT91_PIN_PC14,
> +       .ecc_mode       = NAND_ECC_SOFT,
>         .on_flash_bbt   = 1,
>  };
>
> diff --git a/arch/arm/boards/usb-a926x/init.c b/arch/arm/boards/usb-a926x/init.c
> index 4a28af0..f0e1157 100644
> --- a/arch/arm/boards/usb-a926x/init.c
> +++ b/arch/arm/boards/usb-a926x/init.c
> @@ -59,6 +59,7 @@ static struct atmel_nand_data nand_pdata = {
>         .det_pin        = -EINVAL,
>         .rdy_pin        = AT91_PIN_PC13,
>         .enable_pin     = AT91_PIN_PC14,
> +       .ecc_mode       = NAND_ECC_SOFT,
>         .on_flash_bbt   = 1,
>  };
>
> --
> 2.1.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2015-01-06 12:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-26  9:51 [REGRESSION BUG] at91 is broken on barebox Jean-Christophe PLAGNIOL-VILLARD
2015-01-05 10:23 ` Sascha Hauer
2015-01-05 11:51   ` Simon Aittamaa
2015-01-06 11:32 ` [PATCH 0/2] FIX AT91 support Jean-Christophe PLAGNIOL-VILLARD
2015-01-06 11:37   ` [PATCH 1/2] arm: at91: fix ecc_mode on non atmel boards Jean-Christophe PLAGNIOL-VILLARD
2015-01-06 11:37     ` [PATCH 2/2] driver: workarroud resource request that conflist with errno PTR Jean-Christophe PLAGNIOL-VILLARD
2015-01-06 12:44       ` Sascha Hauer
2015-01-07  3:14         ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-07  7:34           ` Sascha Hauer
2015-01-08  7:11       ` Sascha Hauer
2015-01-06 12:36     ` Raphaël Poggi [this message]
2015-01-06 12:59     ` [PATCH 1/2] arm: at91: fix ecc_mode on non atmel boards Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACqcpZAs1bB9KQ7qkLwLg_wmE21Q3=Cj0JNP9XPVyqDNqFD8+Q@mail.gmail.com' \
    --to=poggi.raph@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox