mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Raphaël Poggi" <poggi.raph@gmail.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 12/12] arm: boards: add virt board
Date: Tue, 7 Jun 2016 15:16:44 +0200	[thread overview]
Message-ID: <CACqcpZBf5mW+h-w9WxbOyuRNuC=gF_a3EY9o=Zmpyt=D7D9nrQ@mail.gmail.com> (raw)
In-Reply-To: <20160607155951.20226a685e377ba8ba7d78d4@gmail.com>

2016-06-07 14:59 GMT+02:00 Antony Pavlov <antonynpavlov@gmail.com>:
> On Tue, 7 Jun 2016 13:53:49 +0200
> Raphaël Poggi <poggi.raph@gmail.com> wrote:
>
>> 2016-06-07 13:00 GMT+02:00 Antony Pavlov <antonynpavlov@gmail.com>:
>> > On Thu,  2 Jun 2016 10:06:58 +0200
>> > Raphael Poggi <poggi.raph@gmail.com> wrote:
>> >
>> >> Add qemu virt board which emulates arm64 board.
>> >>
>> >> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
>> >> ---
>> >>  arch/arm/Kconfig                           |  9 ++++
>> >>  arch/arm/boards/Makefile                   |  1 +
>> >>  arch/arm/boards/virt/Kconfig               |  8 ++++
>> >
>> > Can we use a more descriptive 'qemu-virt' name for this machine/board instead of 'virt'?
>>
>> Qemu virt machine support armv7 and armv8 cpu, maybe we can use the
>> name "mach-qemu" for the machine and "qemu-virt64" for the board.
>>
>> With this approach we use a generic name for the machine (since qemu
>> virt machine support armv7/armv8, we do not need to distinguish
>> between arm/arm64),
>> and made the distinction arm/arm64 only in board name.
>>
>> This also lets the possibility, for someone who wants to add support
>> for qemu virt arm32 board, to not create another machine folder.
>>
>> What do you think about that ?
>
> So you are proposing to introduce these directories:
>
>   arch/arm/boards/qemu-virt64/
>   arch/arm/mach-qemu/

Yes, exactly.

>
> I propose to use 'arch/arm/mach-qemu-virt' for machine dir,
> because qemu supports several arm-based machines, not only the virt machine.
>
> On the other hand the 'mach-qemu-virt' name is too long
> and 'mach-qemu' may be is a better solution.

"mach-qemu-virt" seems too long.

Another proposition:  we can choose "mach-qemu", and to distinguish
qemu machine use the same way as mach-at91, ie:

arch/arm/mach-qemu/
  --> virt_devices.c
  --> virt_lowlevel.c
  --> etc...

This also implies to add some Kconfig entries to handle the multiple
qemu machines.

>
>
>> >
>> >>  arch/arm/boards/virt/Makefile              |  1 +
>> >>  arch/arm/boards/virt/env/bin/_update       | 36 ++++++++++++++++
>> >>  arch/arm/boards/virt/env/bin/boot          | 38 +++++++++++++++++
>> >
>> > ... skipped ...
>> >
>> > --
>> > Best regards,
>> >   Antony Pavlov
>> >
>> > _______________________________________________
>> > barebox mailing list
>> > barebox@lists.infradead.org
>> > http://lists.infradead.org/mailman/listinfo/barebox
>
>
> --
> --
> Best regards,
>   Antony Pavlov
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-06-07 13:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02  8:06 [PATCH 0/12] Add basic support for arm64 Raphael Poggi
2016-06-02  8:06 ` [PATCH 01/12] arm: add armv8 Kconfig entries Raphael Poggi
2016-06-02  8:06 ` [PATCH 02/12] arm: Makefile: rework makefile to handle armv8 Raphael Poggi
2016-06-03  7:27   ` Sascha Hauer
2016-06-03  7:33     ` Raphaël Poggi
2016-06-02  8:06 ` [PATCH 03/12] arm: introduce lib64 for arm64 related stuff Raphael Poggi
2016-06-03  8:01   ` Sascha Hauer
2016-06-02  8:06 ` [PATCH 04/12] arm: cpu: add arm64 specific code Raphael Poggi
2016-06-03  8:07   ` Sascha Hauer
2016-06-02  8:06 ` [PATCH 05/12] arm: include: system: add arm64 helper functions Raphael Poggi
2016-06-02  8:06 ` [PATCH 06/12] arm: cpu: start: arm64 does not support relocation Raphael Poggi
2016-06-02  8:06 ` [PATCH 07/12] arm: include: bitops: arm64 use generic __fls Raphael Poggi
2016-06-02  8:06 ` [PATCH 08/12] arm: include: system_info: add armv8 identification Raphael Poggi
2016-06-02  8:06 ` [PATCH 09/12] arm: cpu: cpuinfo: add armv8 support Raphael Poggi
2016-06-02  8:06 ` [PATCH 10/12] arm: cpu: disable code portion in armv8 case Raphael Poggi
2016-06-02  8:06 ` [PATCH 11/12] arm: cpu: add basic arm64 mmu support Raphael Poggi
2016-06-03  8:30   ` Sascha Hauer
2016-06-02  8:06 ` [PATCH 12/12] arm: boards: add virt board Raphael Poggi
2016-06-03  8:50   ` Sascha Hauer
2016-06-07  7:13     ` Raphaël Poggi
2016-06-07 11:00   ` Antony Pavlov
2016-06-07 11:53     ` Raphaël Poggi
2016-06-07 12:59       ` Antony Pavlov
2016-06-07 13:16         ` Raphaël Poggi [this message]
2016-06-03  9:16 ` [PATCH 0/12] Add basic support for arm64 Sascha Hauer
2016-06-03  9:25   ` Raphaël Poggi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACqcpZBf5mW+h-w9WxbOyuRNuC=gF_a3EY9o=Zmpyt=D7D9nrQ@mail.gmail.com' \
    --to=poggi.raph@gmail.com \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox