From: Cameron Ferguson <cameron.bare86@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: Small tweak to get ACPI watchdog working (iTCO)
Date: Wed, 29 Jan 2020 17:55:28 +0000 [thread overview]
Message-ID: <CAEKVsgbBXKcmg2rRFZ16VSNLnu+7C+pJH-GomExFxz9o_+bqdA@mail.gmail.com> (raw)
In-Reply-To: <fead3df7-e831-8ff2-3f62-801ead7eda7b@pengutronix.de>
> In the code you sent last time, it said that your addresses
> are IORESOURCE_IO. These are I/O ports, not memory-mapped ports,
> so you can't dereference a pointer and access them, but instead you
> have to use port I/O instruction, which in barebox and Linux is
> the out[bwl] family of functions.
I got it working.
I included the header file "arch/x86/include/asm/io.h" and so I
thought I was using the right functions for IO operations on ports,
however it turns out that "linux/io.h" was being included before the
aforementioned header file, and so "inl" and outl" were already
defined with generic implementations instead of as specific to x86.
It's working. The watchdog will reboot if the Linux kernel freezes on boot up.
Thank you for your help, Ahmad, I wouldn't have looked further into
the IO headers if you hadn't pointed me in the right direction.
Cameron
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-01-29 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEKVsgZHZR2b28wcMcpac4Qa3KebrXMRf14STZ8GCum0NmnLgg@mail.gmail.com>
2020-01-28 15:19 ` Cameron Ferguson
2020-01-29 8:36 ` Cameron Ferguson
2020-01-29 11:20 ` Ahmad Fatoum
2020-01-29 16:07 ` Cameron Ferguson
2020-01-29 16:57 ` Cameron Ferguson
2020-01-29 16:57 ` Ahmad Fatoum
2020-01-29 17:55 ` Cameron Ferguson [this message]
2020-01-29 18:00 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEKVsgbBXKcmg2rRFZ16VSNLnu+7C+pJH-GomExFxz9o_+bqdA@mail.gmail.com \
--to=cameron.bare86@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox