From: Hubert Feurstein <h.feurstein@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] net fec_imx: add support for i.MX6 1000Mbps mode
Date: Fri, 8 Feb 2013 17:47:06 +0100 [thread overview]
Message-ID: <CAFfN3gUJiZ=NNxNJaL4rchWfHwOS9gjM-O_EEPUCK0JToqx5=A@mail.gmail.com> (raw)
In-Reply-To: <1360231566-9514-1-git-send-email-h.feurstein@gmail.com>
Any comments on this?
2013/2/7 Hubert Feurstein <h.feurstein@gmail.com>:
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> ---
> drivers/net/fec_imx.c | 14 ++++++++++----
> drivers/net/fec_imx.h | 1 +
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
> index 2378a19..7320f07 100644
> --- a/drivers/net/fec_imx.c
> +++ b/drivers/net/fec_imx.c
> @@ -361,12 +361,18 @@ static int fec_init(struct eth_device *dev)
> static void fec_update_linkspeed(struct eth_device *edev)
> {
> struct fec_priv *fec = (struct fec_priv *)edev->priv;
> + int speed = edev->phydev->speed;
> + u32 rcntl = readl(fec->regs + FEC_R_CNTRL) & ~FEC_R_CNTRL_RMII_10T;
> + u32 ecntl = readl(fec->regs + FEC_ECNTRL) & ~FEC_ECNTRL_SPEED;
>
> - if (edev->phydev->speed == SPEED_10) {
> - u32 rcntl = readl(fec->regs + FEC_R_CNTRL);
> + if (speed == SPEED_10)
> rcntl |= FEC_R_CNTRL_RMII_10T;
> - writel(rcntl, fec->regs + FEC_R_CNTRL);
> - }
> +
> + if (speed == SPEED_1000)
> + ecntl |= FEC_ECNTRL_SPEED;
> +
> + writel(rcntl, fec->regs + FEC_R_CNTRL);
> + writel(ecntl, fec->regs + FEC_ECNTRL);
> }
>
> /**
> diff --git a/drivers/net/fec_imx.h b/drivers/net/fec_imx.h
> index 1eb1eba..29aea85 100644
> --- a/drivers/net/fec_imx.h
> +++ b/drivers/net/fec_imx.h
> @@ -92,6 +92,7 @@
>
> #define FEC_ECNTRL_RESET 0x00000001 /**< reset the FEC */
> #define FEC_ECNTRL_ETHER_EN 0x00000002 /**< enable the FEC */
> +#define FEC_ECNTRL_SPEED 0x00000020 /**< i.MX6: enable 1000Mbps mode */
>
> /**
> * @brief Descriptor buffer alignment
> --
> 1.8.1
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-02-08 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 10:06 Hubert Feurstein
2013-02-08 16:47 ` Hubert Feurstein [this message]
2013-02-09 11:46 ` Daniel Mierswa
2013-02-11 8:51 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFfN3gUJiZ=NNxNJaL4rchWfHwOS9gjM-O_EEPUCK0JToqx5=A@mail.gmail.com' \
--to=h.feurstein@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox