Re: [RFC PATCH] ARM i.MX6: Add support for SabreSD board

[Hubert Feurstein <h.feurstein@gmail.com>]

Hi Steffen,

2013/2/5 Steffen Trumtrar <s.trumtrar@pengutronix.de>:
>> +static int sabresd_devices_init(void)
>> +{
>> +     imx6_add_mmc1(&sabresd_sd2_data);
>> +     imx6_add_mmc2(&sabresd_sd3_data);
>> +     imx6_add_mmc3(&sabresd_sd4_data);
>> +
>> +     sabresd_enet_setup();
>
> I think this is not necessary. The SabreSD ethernet works without this
> and you can merge the two pinmuxings. On the SabreLite this was necessary
> because of remuxing.
OK

> The rest of the ethernet looks okay though and should work. I have a v2012.08.0
> barebox for the SabreSD that only does ethernet (Forgot to mainline the patches
> :-( ). The pinctrl and the rest is almost the same. The only difference is the
> rgmii_rework.
> I have
>         imx6_add_fec(&fec_info);
>         mx6_rgmii_rework();
I recognized, that my rework code is the same as for the Arm2-board.
But ethernet is still not working yet.
Btw, what are your clock settings? I'm also a little bit confused
about that fec_imx.c requests
the 'ipg' clock (is this the correct one, btw? shouldn't it be
'enet_ref' ?), but then the clock
is not enabled. Looks like a bug. But even with enabled clocks it does
not work ...

Here's the boot log:

barebox 2013.01.0-00346-g8aa2579-dirty #112 Wed Feb 6 16:23:37 CET 2013
Board: SabreSD
[...]
fec clock ipg
mdio_bus: miibus0: probed
fec probed
eth0: got preset MAC address: 00:04:9F:02:6F:1C
malloc space: 0x13800000 -> 0x177fffff (size 64 MiB)
stack space:  0x137f8000 -> 0x137fffff (size 32 KiB)
Open /dev/env0 No such file or directory
no valid environment found on /dev/env0. Using default environment
running /env/bin/init...

Hit m for menu or any other key to stop autoboot:  3

type exit to get to the menu
barebox@SabreSD:/
barebox@SabreSD:/ dhcp
1000Mbps full duplex link detected
T T T T T T T T T T T T T T T T T T T T dhcp failed: Connection timed out
dhcp: Connection timed out
barebox@SabreSD:/

[...]

>
> If I see this right, it is not _based_ on freescale-mx6-sabrelite/flash_header.c,
> but is the SAME file and therefore the same as freescale-mx6-arm2/flash_header.c
In fact it is the same file as for SabreLite, the Arm2 is slightly
different. But maybe they
can be consolidated.

[...]

Regards,
Hubert

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox