mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Çağlar Kilimci" <ckilimci@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: State Framework and dtb
Date: Mon, 3 Apr 2017 23:59:50 +0300	[thread overview]
Message-ID: <CAGUZs0=zmi+GciKgtSRUe8sT=_SXNBGH4p5jXqk8MogyQ5MMwA@mail.gmail.com> (raw)
In-Reply-To: <20170331130058.y6prkk3xsys2ypg5@pengutronix.de>

Hello,

2017-03-31 16:00 GMT+03:00 Sascha Hauer <s.hauer@pengutronix.de>:
> On Fri, Mar 31, 2017 at 02:41:19PM +0300, Çağlar Kilimci wrote:
>> Hey,
>>
>>
>> I tried but got the same result and then I would like to apply your
>> serious patch series of the state framework but release that our
>> working branch is 2016.07 so could not apply patches. Let me update
>> barebox and apply those patches. Are those based on master branch
>> right?  Or, which branch do you recommend to work on?
>
> The patches are based on master, yes. Anyway, you seem to have a problem
> in getting your changes in the dts file to the running barebox. Please
> try to add some nodes/properties to your dts file and verify that a
> of_dump shows these nodes. Before that is the case it's not worth to
> look any further.

Finally, I updated and patched the code and now I can see state@0
device in the of_dump:
        state@0 {
                magic = <0x27031977>;
                compatible = "barebox,state";
                backend-type = "raw";
                backend = <0x42>;
                foo {
                        reg = <0x0 0x4>;
                        type = "uint32";
                        default = <0x0>;
                };
                bar {
                        reg = <0x10 0x4>;
                        type = "enum32";
                        names = "baz", "qux";
                        default = <0x1>;
                };
        };
I can see in the eeprom section, too:
barebox@Phytec phyCORE AM335x:/ of_dump i2c0
i2c@44e0b000 {
        compatible = "ti,omap4-i2c";
        #address-cells = <0x1>;
        #size-cells = <0x0>;
        ti,hwmods = "i2c1";
        reg = <0x44e0b000 0x1000>;
        interrupts = <0x46>;
        status = "okay";
        pinctrl-names = "default";
        pinctrl-0 = <0x2c>;
        clock-frequency = <0x61a80>;
        eeprom@52 {
                status = "okay";
                compatible = "atmel,24c32";
                pagesize = <0x20>;
                reg = <0x52>;
                state@1000 {
                        label = "state";
                        reg = <0x1000 0x1000>;
                        linux,phandle = <0x42>;
                        phandle = <0x42>;
                };
        };
};

But still state command does not show any state device:
barebox@Phytec phyCORE AM335x:/ state
registered state instances:

Here is my diff for the dts:
diff --git a/arch/arm/dts/am335x-phytec-phycore-som.dtsi
b/arch/arm/dts/am335x-phytec-phycore-som.dtsi
index 0b8c454..0d71e8b 100644
--- a/arch/arm/dts/am335x-phytec-phycore-som.dtsi
+++ b/arch/arm/dts/am335x-phytec-phycore-som.dtsi
@@ -14,6 +14,26 @@
                        status = "disabled";
                };
        };
+
+       state: state@0 {
+               magic = <0x27031977>;
+               compatible = "barebox,state";
+               backend-type = "raw";
+               backend = <&state_part>;
+
+               foo {
+                     reg = <0x00 0x4>;
+                     type = "uint32";
+                     default = <0x0>;
+               };
+
+               bar {
+                     reg = <0x10 0x4>;
+                     type = "enum32";
+                     names = "baz", "qux";
+                     default = <1>;
+               };
+       };
 };

 &am33xx_pinmux {
@@ -148,6 +168,10 @@
                compatible = "atmel,24c32";
                pagesize = <32>;
                reg = <0x52>;
+               state_part: state@1000 {
+                       label = "state";
+                       reg = <0x1000 0x1000>;
+               };
        };
 };

So, why does not state framework catch my state device?

Sincerely,
-- 
Çağlar Kilimci

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-04-03 21:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29 13:24 Çağlar Kilimci
2017-03-30  6:31 ` Sascha Hauer
2017-03-30 10:33   ` Çağlar Kilimci
2017-03-31  6:21     ` Sascha Hauer
2017-03-31  6:54       ` Çağlar Kilimci
2017-03-31  7:02         ` Sascha Hauer
2017-03-31  7:18           ` Çağlar Kilimci
2017-03-31  7:23             ` Sascha Hauer
2017-03-31 11:41               ` Çağlar Kilimci
2017-03-31 13:00                 ` Sascha Hauer
2017-04-03 20:59                   ` Çağlar Kilimci [this message]
2017-04-04  6:22                     ` Sascha Hauer
2017-04-04  6:49                       ` Çağlar Kilimci
2017-04-04  8:04                     ` Jan Remmet
     [not found]                     ` <58e3539f.0582540a.1e64d.751fSMTPIN_ADDED_BROKEN@mx.google.com>
2017-04-04 10:27                       ` Çağlar Kilimci
2017-04-04 10:48                         ` Ian Abbott
2017-04-05  6:01                           ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGUZs0=zmi+GciKgtSRUe8sT=_SXNBGH4p5jXqk8MogyQ5MMwA@mail.gmail.com' \
    --to=ckilimci@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox