mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Yegor Yefremov <yegorslists@googlemail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] fixup! USB: MUSB: defer driver probes where necessary
Date: Fri, 28 Feb 2020 11:27:21 +0100	[thread overview]
Message-ID: <CAGm1_kspuhkcK7sa4uOT0rUjgf-UG1Of13ukSkKXiF0KkEt=wg@mail.gmail.com> (raw)
In-Reply-To: <20200226104806.9498-1-a.fatoum@pengutronix.de>

Hi Ahmad,

On Wed, Feb 26, 2020 at 11:48 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
> The NULL assignment is a left over from when it was a global variable.
> am_usbphy is local now and is just going out of scope, so need to NULL
> it.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/usb/musb/phy-am335x.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/musb/phy-am335x.c b/drivers/usb/musb/phy-am335x.c
> index 7dda8caf2a3c..f2e870d7ee61 100644
> --- a/drivers/usb/musb/phy-am335x.c
> +++ b/drivers/usb/musb/phy-am335x.c
> @@ -60,7 +60,6 @@ err_release:
>         release_region(iores);
>  err_free:
>         free(am_usbphy);
> -       am_usbphy = NULL;
>
>         return ret;
>  };

Do you want me to test this fixup as well or are you going to post v2?

Yegor

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-02-28 10:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 16:57 [PATCH 1/2] USB: MUSB: PHY: scrap singleton am335x_get_usb_phy() Ahmad Fatoum
2020-02-25 16:57 ` [PATCH 2/2] USB: MUSB: defer driver probes where necessary Ahmad Fatoum
2020-02-26  7:26   ` Yegor Yefremov
2020-02-26 10:48   ` [PATCH] fixup! " Ahmad Fatoum
2020-02-28 10:27     ` Yegor Yefremov [this message]
2020-02-28 10:30       ` Ahmad Fatoum
2020-02-26  7:26 ` [PATCH 1/2] USB: MUSB: PHY: scrap singleton am335x_get_usb_phy() Yegor Yefremov
2020-03-02  8:12 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGm1_kspuhkcK7sa4uOT0rUjgf-UG1Of13ukSkKXiF0KkEt=wg@mail.gmail.com' \
    --to=yegorslists@googlemail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox