From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cgUHd-0000TX-3b for barebox@lists.infradead.org; Wed, 22 Feb 2017 10:36:30 +0000 Received: by mail-wr0-x244.google.com with SMTP id z61so923914wrc.3 for ; Wed, 22 Feb 2017 02:36:08 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170222102149.anazwahf4adk2zai@pengutronix.de> References: <20170221144751.27760-1-yegorslists@googlemail.com> <0CEC428C-E1EE-48A7-85CF-6FC90A22F47C@jcrosoft.com> <20170222100350.anjucafhspmwsa2c@pengutronix.de> <20170222102149.anazwahf4adk2zai@pengutronix.de> From: Yegor Yefremov Date: Wed, 22 Feb 2017 11:35:46 +0100 Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] lib: xz: add support for bcj filters To: Sascha Hauer Cc: Falco Hyfing , barebox On Wed, Feb 22, 2017 at 11:21 AM, Sascha Hauer wrote: > On Wed, Feb 22, 2017 at 11:10:36AM +0100, Yegor Yefremov wrote: >> On Wed, Feb 22, 2017 at 11:03 AM, Sascha Hauer wrote: >> > On Wed, Feb 22, 2017 at 09:15:36AM +0100, Yegor Yefremov wrote: >> >> On Wed, Feb 22, 2017 at 5:29 AM, Jean-Christophe PLAGNIOL-VILLARD >> >> wrote: >> >> > >> >> >> On Feb 21, 2017, at 10:47 PM, yegorslists@googlemail.com wrote: >> >> >> >> >> >> From: Yegor Yefremov >> >> >> >> >> >> Add missing configuration options for various bcj filters. Without >> >> >> these options the lib/xz/xz_dec_bcj.c file will be compiled, but all >> >> >> filters will be disabled. >> >> >> >> >> >> Signed-off-by: Yegor Yefremov >> >> >> --- >> >> >> lib/Kconfig | 28 ++++++++++++++++++++++++++++ >> >> >> 1 file changed, 28 insertions(+) >> >> >> >> >> >> diff --git a/lib/Kconfig b/lib/Kconfig >> >> >> index f9f25bdef..83dd8e0a4 100644 >> >> >> --- a/lib/Kconfig >> >> >> +++ b/lib/Kconfig >> >> >> @@ -22,6 +22,34 @@ config XZ_DECOMPRESS >> >> >> bool "include xz uncompression support" >> >> >> select UNCOMPRESS >> >> >> >> >> >> +if XZ_DECOMPRESS >> >> >> + >> >> >> +config XZ_DEC_X86 >> >> >> + bool "x86 BCJ filter decoder" >> >> >> + default y >> >> > this need to be ARCH dependant >> >> >> >> Why? In Linux kernel it is not arch dependent, because AFAIK it >> >> describes only compression particularities. This way you can extract >> >> sqaushfs images on your ARM machine, that were compressed on SPARK >> >> etc. >> > >> > So xz uses the Sparc bcj filter even when compressing ARM binaries? That >> > doesn't sound very mature to me. >> >> This is just an xz command line option. So it is completely in the >> user responsibility. > > I see. What's the default for this option? The architecture xz is > running on? > > Otherwise we could do a: > > config XZ_DEC_ARM > bool "ARM BCJ filter decoder" > default y if ARCH_ARM > > On the other hand I'm not sure if the potential image size gain for > disabling the unused bcj filters is even worth thinking about the > problem... My barebox images without filters: 4668516 barebox 640752 barebox.bin with all filters: 4679592 barebox 642632 barebox.bin Yegor _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox