Re: [RFC 0/4] FIT Support

[Yegor Yefremov <yegorslists@googlemail.com>]

On Fri, Nov 13, 2015 at 1:54 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Wed, Nov 11, 2015 at 12:39:14PM +0100, Yegor Yefremov wrote:
>> On Thu, Mar 12, 2015 at 3:39 PM, Jan Luebbe <jlu@pengutronix.de> wrote:
>> > Hi,
>> >
>> > this is the current work-in-progress state of my FIT support patches.
>> > The FIT loading code has basically been rewritten from scratch, as the
>> > original U-Boot code uses libfdt and barebox's DT support works on an
>> > in-memory tree.
>> >
>> > These patches apply on v2015.03.0.
>> > The two patches from Sascha are required for the basic RSA support.
>> > The third patch adds FIT support.
>> > The fourth patch contains some test data to use in the sandbox.
>> >
>> > $ ./barebox -i key.dtb -i sign-configs.itb
>> > add file key.dtb()
>> > add file sign-configs.itb()
>> >
>> > barebox 2015.03.0-00005-g574d35e191f7-dirty #81 Thu Mar 12 14:57:13 CET 2015
>> >
>> > Board: barebox sandbox
>> > ...
>> > Hit any key to stop autoboot:  3
>> > barebox@barebox sandbox:/ oftree -l /dev/fd0
>> > barebox@barebox sandbox:/ bootm /dev/fd1
>> >
>> > Loading open firmware Device Tree flattened Binary '/dev/fd1'
>> > FIT '/dev/fd1': 'Chrome OS kernel image with one or more FDT blobs'
>> > FIT configuration 'conf@1' (no description)
>> > sig OK
>> > FIT image 'kernel@1' (no description)
>> > hash OK
>> > FIT image 'fdt@1': 'snow'
>> > hash OK
>> >
>> > Jan Luebbe (2):
>> >   FIT: add FIT image support
>> >   FIT: add test config and data [do not merge]
>> >
>> > Sascha Hauer (2):
>> >   digest: Make filename arguments const
>> >   Add rsa support
>> >
>> >  arch/arm/lib/bootm.c                   |  74 +++++
>> >  arch/sandbox/configs/sandbox_defconfig |  33 +-
>> >  commands/Kconfig                       |   8 +
>> >  common/Kconfig                         |   7 +
>> >  common/Makefile                        |   1 +
>> >  common/digest.c                        |   8 +-
>> >  common/image-fit.c                     | 585 +++++++++++++++++++++++++++++++++
>> >  crypto/Kconfig                         |   3 +
>> >  crypto/Makefile                        |   1 +
>> >  crypto/rsa.c                           | 411 +++++++++++++++++++++++
>> >  include/asm-generic/errno.h            |   5 +
>> >  include/digest.h                       |   8 +-
>> >  include/image-fit.h                    |  42 +++
>> >  include/rsa.h                          |  54 +++
>> >  key.dtb                                | Bin 0 -> 1023 bytes
>> >  key.dts                                |  27 ++
>> >  sign-configs.itb                       | Bin 0 -> 2453 bytes
>> >  17 files changed, 1247 insertions(+), 20 deletions(-)
>> >  create mode 100644 common/image-fit.c
>> >  create mode 100644 crypto/rsa.c
>> >  create mode 100644 include/image-fit.h
>> >  create mode 100644 include/rsa.h
>> >  create mode 100644 key.dtb
>> >  create mode 100644 key.dts
>> >  create mode 100644 sign-configs.itb
>> >
>> > --
>> > 2.1.4
>>
>> What the state of FIT support in Barebox?
>
> The state is: We have and use these patches, the newest version is based
> on v2015.09. I don't know what's different in our current version
> compared to this posted version.

I'm trying to apply/compile the patches from march and there are many
places, where the patches fail to apply or fail to compile as digest
structure has changed a lot. Do you have a newer version meanwhile?

> I think we should mainline them quite soon, they are more helpful
> in-tree.
>
> Steffen, Marc, Markus? Any volunteers to resend them?
>
> Sascha
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox