mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Yegor Yefremov <yegorslists@googlemail.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org, Oleksij Rempel <linux@rempel-privat.de>
Subject: Re: [PATCH 1/3] MIPS: pbl: add pbl_blt macro
Date: Wed, 11 Nov 2015 08:41:45 +0100	[thread overview]
Message-ID: <CAGm1_kvygnRWeY=JJ2eAYPoZSynq5JRS05weqjO6ko9NKPX2aQ@mail.gmail.com> (raw)
In-Reply-To: <1447204155-16773-2-git-send-email-antonynpavlov@gmail.com>

On Wed, Nov 11, 2015 at 2:09 AM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> From: Oleksij Rempel <linux@rempel-privat.de>
>
> Barebox' PBL can initialize memory controller of the board.
> But we can use memory controller initialization routine
> only if PBL runs from ROM or on-chip SRAM.
> MIPS architecture standard boot vector is 0xbfc00000
> so on most MIPS SoCs all addresses higher than 0xbfc00000
> belong to boot ROM or on-chip SRAM. Well then we have
> simple criterion to check if PBL run from ROM: just
> check if current PC is higher than 0xbfc00000.
> Some MIPS boards have ROM start address lower than 0xbfc00000
> so it's reasonable we have to make ROM start address
> board dependend.
>
> The pbl_blt macro checks if current pc is lower than
> the first argument (ROM start address). If so then
> next instruction executed is defined by the second argument
> of the macro.
>
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  arch/mips/include/asm/pbl_macros.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/mips/include/asm/pbl_macros.h b/arch/mips/include/asm/pbl_macros.h
> index c4ae6a2..dbe3410 100644
> --- a/arch/mips/include/asm/pbl_macros.h
> +++ b/arch/mips/include/asm/pbl_macros.h
> @@ -60,6 +60,18 @@
>         .set    pop
>         .endm
>
> +       .macro  pbl_blt addr label tmp
> +       .set    push
> +       .set    noreorder
> +       move    \tmp, ra                        # preserve ra beforehand
> +       bal     253f
> +        nop
> +253:
> +       bltu    ra, \addr, \label
> +        move   ra, \tmp                        # restore ra
> +       .set    pop
> +       .endm
> +
>         .macro  pbl_sleep reg count
>         .set push
>         .set noreorder
> --
> 2.6.2

Loaded barebox.bin via OpenOCD and successfully started

Tested-by: Yegor Yefremov <yegorslists@googlemail.com>

Yegor

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-11-11  7:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11  1:09 [PATCH 0/3] MIPS: ath79: skip pbl lowlevel init if running from RAM Antony Pavlov
2015-11-11  1:09 ` [PATCH 1/3] MIPS: pbl: add pbl_blt macro Antony Pavlov
2015-11-11  7:41   ` Yegor Yefremov [this message]
2015-11-11  1:09 ` [PATCH 2/3] MIPS: black-swift: skip pbl lowlevel init if running from RAM Antony Pavlov
2015-11-11  7:42   ` Yegor Yefremov
2015-11-11  1:09 ` [PATCH 3/3] MIPS: tplink-mr3020: " Antony Pavlov
2015-11-11  8:45 ` [PATCH 0/3] MIPS: ath79: " Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGm1_kvygnRWeY=JJ2eAYPoZSynq5JRS05weqjO6ko9NKPX2aQ@mail.gmail.com' \
    --to=yegorslists@googlemail.com \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=linux@rempel-privat.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox