From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fJPOb-0006lR-U6 for barebox@lists.infradead.org; Thu, 17 May 2018 20:21:22 +0000 Received: by mail-io0-x244.google.com with SMTP id e12-v6so3571023iob.8 for ; Thu, 17 May 2018 13:20:54 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180517095212.dnb5kvhcb4wm25qi@pengutronix.de> References: <20180516201827.6430-1-andrew.smirnov@gmail.com> <20180516201827.6430-4-andrew.smirnov@gmail.com> <20180517095212.dnb5kvhcb4wm25qi@pengutronix.de> From: Andrey Smirnov Date: Thu, 17 May 2018 13:20:53 -0700 Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 3/4] common: oftree: Pass bootsource and bootsource instance to kernel To: Sascha Hauer Cc: Barebox List On Thu, May 17, 2018 at 2:52 AM, Sascha Hauer wrote: > On Wed, May 16, 2018 at 01:18:26PM -0700, Andrey Smirnov wrote: >> Pass barebox-detected bootsource to Linux to make it availible to >> Linux userspace. That information is passed as full path to the node >> corresponding to the bootsource and is placed under /chosen/bootsource >> and it can be read under Linux in >> >> /sys/firmware/devicetree/base/chosen/bootsource >> >> Signed-off-by: Andrey Smirnov >> --- >> common/oftree.c | 46 +++++++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 45 insertions(+), 1 deletion(-) >> >> diff --git a/common/oftree.c b/common/oftree.c >> index 8a2ede4c6..5ab6bf089 100644 >> --- a/common/oftree.c >> +++ b/common/oftree.c >> @@ -11,6 +11,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> #define MAX_LEVEL 32 /* how deeply nested we will go */ >> @@ -114,6 +115,47 @@ void of_print_cmdline(struct device_node *root) >> printf("commandline: %s\n", cmdline); >> } >> >> +static int of_fixup_bootargs_bootsource(struct device_node *root, >> + struct device_node *chosen) >> +{ >> + char *alias_name = bootsource_get_alias_name(); >> + struct device_node *bootsource; >> + struct device_node *aliasnp; >> + struct property *p; >> + int ret; >> + >> + if (!alias_name) >> + return 0; >> + >> + bootsource = of_find_node_by_alias(root, alias_name); >> + /* >> + * If kerenel DTB doesn't have the appropriate alias set up, >> + * give up and exit early. No error is reported. >> + */ > > s/kerenel/kernel/ > Will fix in v3. >> + if (!bootsource) { >> + ret = 0; >> + goto exit; >> + } >> + >> + aliasnp = of_find_node_by_path_from(root, "/aliases"); >> + if (!aliasnp) { >> + ret = -ENOENT; >> + goto exit; >> + } >> + >> + p = of_find_property(aliasnp, alias_name, NULL); >> + if (!p) { >> + ret = -ENOENT; >> + goto exit; >> + } > > This seems unnecessary. Pass bootsource->full_name to of_set_property > below. > Haven't thought about doing that. Will do in v3. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox