mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] version_string: Add toolchain and build host info
Date: Mon, 7 Oct 2019 22:14:41 -0700	[thread overview]
Message-ID: <CAHQ1cqEKP4KPRLy+XTbQzeDB9ucisP95LdS84ZpfkdBT4hZxTA@mail.gmail.com> (raw)
In-Reply-To: <20191001090331.81644cde6b0b9efd04a8a7a7@gmail.com>

On Mon, Sep 30, 2019 at 11:03 PM Antony Pavlov <antonynpavlov@gmail.com> wrote:
>
> On Mon, 30 Sep 2019 17:57:18 -0700
> Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
>
> Hi!
>
> > Linux kernel reports the version of toolchain it was built with as a
> > part of its version string, which can be extremely useful when
> > debugging toolchain related issues. Make Barebox version string, mimic
> > that of Linux to get the same level of information in Barebox.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > ---
> >  common/version.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/common/version.c b/common/version.c
> > index 8b1fd4dbe7..5f57022dac 100644
> > --- a/common/version.c
> > +++ b/common/version.c
> > @@ -3,7 +3,8 @@
> >  #include <generated/utsrelease.h>
> >
> >  const char version_string[] =
> > -     "barebox " UTS_RELEASE " " UTS_VERSION "\n";
> > +     "barebox " UTS_RELEASE " (" BAREBOX_COMPILE_BY "@"
> > +     BAREBOX_COMPILE_HOST ") (" BAREBOX_COMPILER ") " UTS_VERSION "\n";
> >  EXPORT_SYMBOL(version_string);
>
>
> Can we keep COMPILE_BY and COMPILE_HOST in one line (as linux does)?

I don't understand. This line already follows formatting found in
Linux, e. g. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/init/version.c?h=v5.4-rc2#n46

I have no preference how this is going to be formatted, really. Can
you just take this patch reformat it the way you want to see it and
submit it?

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-10-08  5:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01  0:57 Andrey Smirnov
2019-10-01  6:03 ` Antony Pavlov
2019-10-08  5:14   ` Andrey Smirnov [this message]
2019-10-08  8:14     ` Antony Pavlov
2019-10-14 12:00 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqEKP4KPRLy+XTbQzeDB9ucisP95LdS84ZpfkdBT4hZxTA@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox