mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Trent Piepho <tpiepho@kymetacorp.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH v2] i2c: Add support for DesignWare controllers
Date: Wed, 18 Nov 2015 20:09:05 -0800	[thread overview]
Message-ID: <CAHQ1cqEcG+omZDR+M01ONoPGzGEB3qvFddM5UdcVmojaw_Wh=g@mail.gmail.com> (raw)
In-Reply-To: <1447896407.4553.181.camel@rtred1test09.kymeta.local>

On Wed, Nov 18, 2015 at 5:26 PM, Trent Piepho <tpiepho@kymetacorp.com> wrote:
> On Mon, 2015-11-09 at 07:20 +0100, Sascha Hauer wrote:
>> On Sun, Nov 08, 2015 at 04:18:46PM -0800, Andrey Smirnov wrote:
>> > Add a driver for DesignWare I2C controller IP block found on several
>> > SoCs including Altera SoC products
>> >
>> > Tested using Terrasic SoCKit board and GPIO expander board with I2C
>> > EEPROM on it
>> >
>> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>
>> > +   uint32_t ic_con, ic_comp_type_value;
>> > +
>> > +   pdata = pdev->platform_data;
>> > +
>> > +   dw = xzalloc(sizeof(*dw), GFP_KERNEL);
>> > +
>
> Doesn't compile, xzalloc() has one argument, no page flags.

*Sigh* Looks like I didn't do a good job testing v2 patchset, my bad,
sorry. I'll submit a patch to fix this, unless either of you guys
already did so.

Once again, I apologize for making such an obvious mistake.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-11-19  4:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09  0:18 Andrey Smirnov
2015-11-09  0:18 ` [PATCH] i2c-imx: Use xzalloc instead of kzalloc Andrey Smirnov
2015-11-09  6:20 ` [PATCH v2] i2c: Add support for DesignWare controllers Sascha Hauer
2015-11-19  1:26   ` Trent Piepho
2015-11-19  4:09     ` Andrey Smirnov [this message]
2015-11-19  7:59       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHQ1cqEcG+omZDR+M01ONoPGzGEB3qvFddM5UdcVmojaw_Wh=g@mail.gmail.com' \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=tpiepho@kymetacorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox