mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] miitool: Fix inconsistent spacing
Date: Fri, 26 Oct 2018 18:34:02 -0700	[thread overview]
Message-ID: <CAHQ1cqEv33CahZA5YsQZy_FQq41nrx9pz79duFcrxrLO9wq9ZA@mail.gmail.com> (raw)
In-Reply-To: <20181027013127.22163-3-andrew.smirnov@gmail.com>

On Fri, Oct 26, 2018 at 6:31 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
>
> Make sure that there's a space between device name and it's status
> string regardless if if device is using "id" field or not.
>
> Before:
>
> barebox@ZII RDU2 Board:/ miitool
> mdio0-phy00: mdio:no link
> mdio1-phy15: 2188000.ethernet@2188000:10 Mbit, half duplex, no link
> mdio1-phy16: 2188000.ethernet@2188000:10 Mbit, half duplex, no link
> mdio2-phy00: 2188000.ethernet@2188000:mdio:switch@0:no link
> mdio2-phy01: 2188000.ethernet@2188000:mdio:switch@0:no link
> mdio2-phy02: 2188000.ethernet@2188000:mdio:switch@0:negotiated 100baseTx-FD, link ok
> mdio2-phy03: 2188000.ethernet@2188000:mdio:switch@0:no link
> mdio2-phy04: 2188000.ethernet@2188000:mdio:switch@0:no link
> mdio3-phy01: eth1: negotiated 1000baseT-FD flow-control, link ok
>
> After:
>
> barebox@ZII RDU2 Board:/ miitool
> mdio0-phy00: mdio: no link
> mdio1-phy15: 2188000.ethernet@2188000: 10 Mbit, half duplex, no link
> mdio1-phy16: 2188000.ethernet@2188000: 10 Mbit, half duplex, no link
> mdio2-phy00: 2188000.ethernet@2188000:mdio:switch@0: no link
> mdio2-phy01: 2188000.ethernet@2188000:mdio:switch@0: no link
> mdio2-phy02: 2188000.ethernet@2188000:mdio:switch@0: no link
> mdio2-phy03: 2188000.ethernet@2188000:mdio:switch@0: no link
> mdio2-phy04: 2188000.ethernet@2188000:mdio:switch@0: no link
> mdio3-phy01: eth1: no link
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>

Ugh, didn't mean to send this patch out. Sorry for the noise.

Thanks,
Andrey Smirnov


> ---
>  commands/miitool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commands/miitool.c b/commands/miitool.c
> index dea4f853c..acf61421b 100644
> --- a/commands/miitool.c
> +++ b/commands/miitool.c
> @@ -115,7 +115,7 @@ static int show_basic_mii(struct mii_bus *mii, struct phy_device *phydev,
>         for (i = 0; i < 32; i++)
>                 mii_val[i] = mii->read(mii, phydev->addr, i);
>
> -       printf((mii->parent->id) < 0 ? "%s: %s:" : "%s: %s%d: ",
> +       printf((mii->parent->id) < 0 ? "%s: %s: " : "%s: %s%d: ",
>                phydev->cdev.name, mii->parent->name, mii->parent->id);
>
>
> --
> 2.17.1
>

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-10-27  1:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-27  1:31 [PATCH 0/6] Switch EEPROM aliases to ZII boards Andrey Smirnov
2018-10-27  1:31 ` [PATCH 1/6] ARM: rdu2: Add switch EEPROM alias Andrey Smirnov
2018-10-27  1:31 ` [PATCH] miitool: Fix inconsistent spacing Andrey Smirnov
2018-10-27  1:34   ` Andrey Smirnov [this message]
2018-10-27  1:31 ` [PATCH 2/6] ARM: rdu1: Add switch EEPROM alias Andrey Smirnov
2018-10-27  1:31 ` [PATCH 3/6] ARM: vf610-zii-dev-rev-c: " Andrey Smirnov
2018-10-27  1:31 ` [PATCH 4/6] ARM: vf610-zii-cfu1: " Andrey Smirnov
2018-10-27  1:31 ` [PATCH 5/6] ARM: vf610-zii-ssmb-spu3: " Andrey Smirnov
2018-10-27  1:31 ` [PATCH 6/6] ARM: imx7d-zii-rpu2: " Andrey Smirnov
2018-10-29  7:50 ` [PATCH 0/6] Switch EEPROM aliases to ZII boards Sascha Hauer
  -- strict thread matches above, loose matches on Subject: below --
2018-10-16  0:38 [PATCH] miitool: Fix inconsistent spacing Andrey Smirnov
2018-10-16  6:15 ` Uwe Kleine-König
2018-10-16  7:06 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqEv33CahZA5YsQZy_FQq41nrx9pz79duFcrxrLO9wq9ZA@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox