mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] i.MX: vf610: Add support for ZII VF610 Dev Family
Date: Fri, 3 Feb 2017 07:27:13 -0800	[thread overview]
Message-ID: <CAHQ1cqEyYiM4ypzAshv_d4g6-oDjYQaN3qNjD2ND6zmnYRboXw@mail.gmail.com> (raw)
In-Reply-To: <20170130070527.plrwfdzhj2ejmvl3@pengutronix.de>

On Sun, Jan 29, 2017 at 11:05 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Thu, Jan 26, 2017 at 02:38:12PM -0800, Andrey Smirnov wrote:
>> On Tue, Jan 24, 2017 at 12:09 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>> > Hi Andrey,
>> >
>> > On Sun, Jan 22, 2017 at 09:57:34PM -0800, Andrey Smirnov wrote:
>> >> Add support for ZII VF610 Dev based designs such as:
>> >>
>> >>     - VF610 Dev, revision B
>> >>     - VF610 Dev, revision C
>> >>     - CFU1, revision A
>> >>     - SPU3, revision A
>> >>     - SCU4 AIB, revision C
>> >>
>> >> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>> >> ---
>> >>
>> >> Sascha, this patch is rebased on 'next' instead of 'master' so that
>> >> you won't have to resolve conflicts with RDU2 patches in 'next'. Let
>> >> me know if you'd rather have it rebased on 'master'.
>> >
>> > It's fine to base on next in this case.
>> >
>> >> +struct named_signal {
>> >> +     unsigned int gpio;
>> >> +     const char *name;
>> >> +     int value;
>> >> +};
>> >> +
>> >> +static int expose_signals(const struct named_signal *signals,
>> >> +                           size_t signal_num)
>> >> +{
>> >> +     int ret, i;
>> >> +
>> >> +     for (i = 0; i < signal_num; i++) {
>> >> +             const struct named_signal *signal = &signals[i];
>> >> +
>> >> +             if (signal->value < 0)
>> >> +                     ret = gpio_direction_input(signal->gpio);
>> >> +             else
>> >> +                     ret = gpio_direction_output(signal->gpio, signal->value);
>> >> +
>> >> +             if (ret) {
>> >> +                     pr_err("Failed to configure \"%s\"\n", signal->name);
>> >> +                     return ret;
>> >> +             }
>> >
>> > This looks like gpio_request_array(). Could you use this instead?
>>
>> Almost. Unfortunately, gpio_request_array doesn't do much with "label'
>> portion of a descriptor, except to use it when displaying information
>> about GPIOs.
>>
>> What I am doing here as well is exposing those GPIO in a very
>> primitive way by calling
>>
>> export_env_ull(signal->name, signal->gpio);
>
> What I meant was something like:
>
> static int expose_signals(const struct gpio *array, size_t num)
> {
>         int ret;
>
>         ret = gpio_request_array(gpios);
>         if (ret)
>                 returen ret;
>
>         for (i = 0; i < num; i++) {
>                 const struct gpio *gpio = &array[i];
>                 export_env_ull(gpio->label, gpio->gpio);
>         }
> }

Doh, I completely missed the fact that I can avoid declaring a
pointless custom type if I do this. Good idea, will fix in v2.

Thanks,
Andrey

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2017-02-03 15:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23  5:57 Andrey Smirnov
2017-01-23  5:57 ` [PATCH] spi: i.MX: Add driver for DSPI Andrey Smirnov
2017-01-24  8:26   ` Sascha Hauer
2017-01-26 22:24     ` Andrey Smirnov
2017-01-24  8:09 ` [PATCH] i.MX: vf610: Add support for ZII VF610 Dev Family Sascha Hauer
2017-01-26 22:38   ` Andrey Smirnov
2017-01-30  7:05     ` Sascha Hauer
2017-02-03 15:27       ` Andrey Smirnov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqEyYiM4ypzAshv_d4g6-oDjYQaN3qNjD2ND6zmnYRboXw@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox