mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: memcmp command is broken
Date: Mon, 8 Jul 2019 22:15:32 -0700	[thread overview]
Message-ID: <CAHQ1cqF+ort2dL7j1vj4UasQ--fecV3Whq40Wvi0Zq_2n9tCjw@mail.gmail.com> (raw)
In-Reply-To: <20190704165617.cvdb34k5mi35jtwa@localhost.localdomain>

On Thu, Jul 4, 2019 at 9:56 AM Peter Mamonov <pmamonov@gmail.com> wrote:
>
> Hi, Andrey,
>
> Current `memcmp` command implementation is broken and fails with the error
> message "read: Bad file number" when calls `read_full(destfd, ...)`. Guess this
> is because `memcpy_parse_options()` opens `destfd` with `O_WRONLY` flag. Anyway
> reverting "ddf4cca339 commands: Introduce memcpy_parse_options()" fixes the
> problem.
>

Yeah, you are right, sorry about that. I'll submit a fix shortly.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2019-07-09  5:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 16:56 Peter Mamonov
2019-07-09  5:15 ` Andrey Smirnov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqF+ort2dL7j1vj4UasQ--fecV3Whq40Wvi0Zq_2n9tCjw@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=pmamonov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox