mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] scripts: imx-image: fix first instruction in i.MX8MQ header
Date: Tue, 6 Nov 2018 12:54:48 -0800	[thread overview]
Message-ID: <CAHQ1cqF1JKPm3tstZrB0oWdjF0xxhFPU86g_twnuCKLctrRhCQ@mail.gmail.com> (raw)
In-Reply-To: <20181106143605.29820-1-l.stach@pengutronix.de>

On Tue, Nov 6, 2018 at 6:36 AM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> The instruction being patched in was a branch to 0x24000, instead of
> the intended 0x9000. This doesn't matter when starting the image from
> a regular boot source, but breaks starting the image via bootm, as we
> rely on the jump in the first header instruction taking us to the
> actual code.
>

For some reason I thought I submitted a patch fixing this, but
apparently not. Did you have a chance to run this fix with and without
signed HDMI firmware blob? AFAIR, adding it shifts entry point from
0x9000 to 0x28000 (don't quote me on this), so it's possible that some
code around imx-image.c:894 might have to be added to handle this
problem. This can be a subject for another patch, though.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-11-06 20:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 14:36 Lucas Stach
2018-11-06 20:54 ` Andrey Smirnov [this message]
2018-11-07  9:21   ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqF1JKPm3tstZrB0oWdjF0xxhFPU86g_twnuCKLctrRhCQ@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox