mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 6/8] ARM: nxp-imx8mq-evk: Add FEC's PHY configuration code
Date: Wed, 19 Sep 2018 07:57:38 -0700	[thread overview]
Message-ID: <CAHQ1cqFK4P-1wSWU5CZhE7TMjBXa8CQ4DkUr4n2YuVJRoahWZA@mail.gmail.com> (raw)
In-Reply-To: <20180919074844.GN4097@pengutronix.de>

On Wed, Sep 19, 2018 at 12:48 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> On Mon, Sep 17, 2018 at 10:41:46PM -0700, Andrey Smirnov wrote:
> > Add appropriate DT node and a fixup routine needed for i.MX8MQ EVK
> > board.
> >
> > diff --git a/arch/arm/dts/imx8mq-evk.dts b/arch/arm/dts/imx8mq-evk.dts
> > index 3ac13baa1..bdc340a8b 100644
> > --- a/arch/arm/dts/imx8mq-evk.dts
> > +++ b/arch/arm/dts/imx8mq-evk.dts
> > @@ -43,7 +43,18 @@
> >                   <&pinctrl_fec1_data_tx>, <&pinctrl_fec1_data_rx>,
> >                   <&pinctrl_fec1_phy_reset>;
> >       phy-mode = "rgmii-id";
> > +     phy-handle = <&fec_phy>;
> > +     phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
> >       status = "okay";
> > +
> > +     mdio {
> > +             #address-cells = <1>;
> > +             #size-cells = <0>;
> > +
> > +             fec_phy: ethernet-phy@1 {
> > +                     reg = <1>;
> > +             };
> > +     };
>
> What's the reason for adding a phy node here? It shouldn't be needed.
>

Yeah, I think I added it mistakenly thinking it was needed and never
re-check the correctness of that assumption. Will remove in v2.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-09-19 14:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18  5:41 [PATCH 0/8] i.MX8MQ EVK miscellanea Andrey Smirnov
2018-09-18  5:41 ` [PATCH 1/8] clk: i.MX8MQ: Bump refcounters of various important clocks Andrey Smirnov
2018-09-18  5:41 ` [PATCH 2/8] ARM: i.MX8MQ: Add missing node for ECSPI1 Andrey Smirnov
2018-09-18  5:41 ` [PATCH 3/8] ARM: i.MX8MQ: Configure USDHC1,2 clocks Andrey Smirnov
2018-09-18  5:41 ` [PATCH 4/8] ARM: i.MX8MQ: Configure FEC1 clocks Andrey Smirnov
2018-09-18  5:41 ` [PATCH 5/8] ARM: nxp-imx8mq-evk: Add missing compatibility check Andrey Smirnov
2018-09-18  5:41 ` [PATCH 6/8] ARM: nxp-imx8mq-evk: Add FEC's PHY configuration code Andrey Smirnov
2018-09-19  7:48   ` Sascha Hauer
2018-09-19 14:57     ` Andrey Smirnov [this message]
2018-09-18  5:41 ` [PATCH 7/8] ARM: i.MX: esdctl: Add memory size detection for i.MX8MQ Andrey Smirnov
2018-09-18  5:41 ` [PATCH 8/8] ARM: nxp-imx8mq-evk: Make use of memory size detection code Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqFK4P-1wSWU5CZhE7TMjBXa8CQ4DkUr4n2YuVJRoahWZA@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox