* [PATCH] ARM: i.MX: freescale-mx6sx-sabresdb: Make ar8031_phy_fixup static @ 2018-08-10 18:50 Andrey Smirnov 2018-08-13 6:34 ` Sascha Hauer 0 siblings, 1 reply; 5+ messages in thread From: Andrey Smirnov @ 2018-08-10 18:50 UTC (permalink / raw) To: barebox; +Cc: Andrey Smirnov Declare ar8031_phy_fixup as static since it is not being exported to any other users. --- arch/arm/boards/freescale-mx6sx-sabresdb/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boards/freescale-mx6sx-sabresdb/board.c b/arch/arm/boards/freescale-mx6sx-sabresdb/board.c index 028b1dddb..0fd9af80c 100644 --- a/arch/arm/boards/freescale-mx6sx-sabresdb/board.c +++ b/arch/arm/boards/freescale-mx6sx-sabresdb/board.c @@ -161,7 +161,7 @@ err_out: } fs_initcall(imx6sx_sdb_setup_pmic_voltages); -int ar8031_phy_fixup(struct phy_device *phydev) +static int ar8031_phy_fixup(struct phy_device *phydev) { /* * Enable 1.8V(SEL_1P5_1P8_POS_REG) on -- 2.17.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: i.MX: freescale-mx6sx-sabresdb: Make ar8031_phy_fixup static 2018-08-10 18:50 [PATCH] ARM: i.MX: freescale-mx6sx-sabresdb: Make ar8031_phy_fixup static Andrey Smirnov @ 2018-08-13 6:34 ` Sascha Hauer 2018-08-13 21:23 ` Robert Schwebel 0 siblings, 1 reply; 5+ messages in thread From: Sascha Hauer @ 2018-08-13 6:34 UTC (permalink / raw) To: Andrey Smirnov; +Cc: barebox On Fri, Aug 10, 2018 at 11:50:33AM -0700, Andrey Smirnov wrote: > Declare ar8031_phy_fixup as static since it is not being exported to > any other users. > --- > arch/arm/boards/freescale-mx6sx-sabresdb/board.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks Sascha > > diff --git a/arch/arm/boards/freescale-mx6sx-sabresdb/board.c b/arch/arm/boards/freescale-mx6sx-sabresdb/board.c > index 028b1dddb..0fd9af80c 100644 > --- a/arch/arm/boards/freescale-mx6sx-sabresdb/board.c > +++ b/arch/arm/boards/freescale-mx6sx-sabresdb/board.c > @@ -161,7 +161,7 @@ err_out: > } > fs_initcall(imx6sx_sdb_setup_pmic_voltages); > > -int ar8031_phy_fixup(struct phy_device *phydev) > +static int ar8031_phy_fixup(struct phy_device *phydev) > { > /* > * Enable 1.8V(SEL_1P5_1P8_POS_REG) on > -- > 2.17.1 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: i.MX: freescale-mx6sx-sabresdb: Make ar8031_phy_fixup static 2018-08-13 6:34 ` Sascha Hauer @ 2018-08-13 21:23 ` Robert Schwebel 2018-08-13 23:20 ` Andrey Smirnov 0 siblings, 1 reply; 5+ messages in thread From: Robert Schwebel @ 2018-08-13 21:23 UTC (permalink / raw) To: Sascha Hauer; +Cc: Andrey Smirnov, barebox On Mon, Aug 13, 2018 at 08:34:05AM +0200, Sascha Hauer wrote: > On Fri, Aug 10, 2018 at 11:50:33AM -0700, Andrey Smirnov wrote: > > Declare ar8031_phy_fixup as static since it is not being exported to > > any other users. > > --- > > arch/arm/boards/freescale-mx6sx-sabresdb/board.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied, thanks Signed-off is missing. rsc -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Industrial Linux Solutions | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: i.MX: freescale-mx6sx-sabresdb: Make ar8031_phy_fixup static 2018-08-13 21:23 ` Robert Schwebel @ 2018-08-13 23:20 ` Andrey Smirnov 2018-08-14 6:50 ` Sascha Hauer 0 siblings, 1 reply; 5+ messages in thread From: Andrey Smirnov @ 2018-08-13 23:20 UTC (permalink / raw) To: Robert Schwebel; +Cc: Barebox List On Mon, Aug 13, 2018 at 2:23 PM Robert Schwebel <r.schwebel@pengutronix.de> wrote: > > On Mon, Aug 13, 2018 at 08:34:05AM +0200, Sascha Hauer wrote: > > On Fri, Aug 10, 2018 at 11:50:33AM -0700, Andrey Smirnov wrote: > > > Declare ar8031_phy_fixup as static since it is not being exported to > > > any other users. > > > --- > > > arch/arm/boards/freescale-mx6sx-sabresdb/board.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Applied, thanks > > Signed-off is missing. > Ugh, sorry about that. Sascha, let me know if I should submit v2 with my Signed-off added. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: i.MX: freescale-mx6sx-sabresdb: Make ar8031_phy_fixup static 2018-08-13 23:20 ` Andrey Smirnov @ 2018-08-14 6:50 ` Sascha Hauer 0 siblings, 0 replies; 5+ messages in thread From: Sascha Hauer @ 2018-08-14 6:50 UTC (permalink / raw) To: Andrey Smirnov; +Cc: Barebox List On Mon, Aug 13, 2018 at 04:20:48PM -0700, Andrey Smirnov wrote: > On Mon, Aug 13, 2018 at 2:23 PM Robert Schwebel > <r.schwebel@pengutronix.de> wrote: > > > > On Mon, Aug 13, 2018 at 08:34:05AM +0200, Sascha Hauer wrote: > > > On Fri, Aug 10, 2018 at 11:50:33AM -0700, Andrey Smirnov wrote: > > > > Declare ar8031_phy_fixup as static since it is not being exported to > > > > any other users. > > > > --- > > > > arch/arm/boards/freescale-mx6sx-sabresdb/board.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Applied, thanks > > > > Signed-off is missing. > > > > Ugh, sorry about that. Sascha, let me know if I should submit v2 with > my Signed-off added. Hm, no. It's already in master so I think we have to live with it. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-14 6:51 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-08-10 18:50 [PATCH] ARM: i.MX: freescale-mx6sx-sabresdb: Make ar8031_phy_fixup static Andrey Smirnov 2018-08-13 6:34 ` Sascha Hauer 2018-08-13 21:23 ` Robert Schwebel 2018-08-13 23:20 ` Andrey Smirnov 2018-08-14 6:50 ` Sascha Hauer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox