From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH RFC] ARM: imx8: fix discrepancy between comment and code
Date: Fri, 31 May 2019 00:55:10 -0700 [thread overview]
Message-ID: <CAHQ1cqFMjDBVdBEoRyxRPJ6YS9wOJnfA8-W8RjOL=CMTB7zhAw@mail.gmail.com> (raw)
In-Reply-To: <20190531074102.28035-1-a.fatoum@pengutronix.de>
On Fri, May 31, 2019 at 12:41 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
> The comment speaks of a one second polling timeout, while the polling
> is indefinite with timeout not accounted for. Thus change the comment
> to reflect the actual behavior.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Ugh, my bad, not sure where I got that comment from, I am guessing
some version of old U-Boot code that actually implemented that timeout
properly. Definitely should be fixed.
Acked-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Thanks,
Andrey Smirnov
> ---
> arch/arm/mach-imx/imx8-ddrc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/imx8-ddrc.c b/arch/arm/mach-imx/imx8-ddrc.c
> index 18454a91533b..736865eb6f12 100644
> --- a/arch/arm/mach-imx/imx8-ddrc.c
> +++ b/arch/arm/mach-imx/imx8-ddrc.c
> @@ -29,7 +29,7 @@ static u32 ddrc_phy_get_message(void __iomem *phy, int type)
>
> /*
> * When BIT0 set to 0, the PMU has a message for the user
> - * 10ms seems not enough for poll message, so use 1s here.
> + * Wait for it indefinitely.
> */
> readl_poll_timeout(phy + DDRC_PHY_REG(0xd0004),
> r, !(r & BIT(0)), 0);
> @@ -104,4 +104,4 @@ void ddrc_phy_wait_training_complete(void __iomem *phy)
> putc_ll('\r');
> putc_ll('\n');
> }
> -}
> \ No newline at end of file
> +}
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-05-31 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 7:41 Ahmad Fatoum
2019-05-31 7:55 ` Andrey Smirnov [this message]
2019-06-04 6:51 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQ1cqFMjDBVdBEoRyxRPJ6YS9wOJnfA8-W8RjOL=CMTB7zhAw@mail.gmail.com' \
--to=andrew.smirnov@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox