From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-io0-x242.google.com ([2607:f8b0:4001:c06::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fKqEP-0007nr-Mc for barebox@lists.infradead.org; Mon, 21 May 2018 19:12:31 +0000 Received: by mail-io0-x242.google.com with SMTP id d11-v6so15576267iof.11 for ; Mon, 21 May 2018 12:12:18 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180518202315.GB26895@ravnborg.org> References: <20180517205837.32421-1-andrew.smirnov@gmail.com> <20180517205837.32421-24-andrew.smirnov@gmail.com> <20180518202315.GB26895@ravnborg.org> From: Andrey Smirnov Date: Mon, 21 May 2018 12:12:16 -0700 Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v3 23/28] ARM: mmu: Make sure that address is 1M aligned in arm_create_pte() To: Sam Ravnborg Cc: Barebox List On Fri, May 18, 2018 at 1:23 PM, Sam Ravnborg wrote: > On Thu, May 17, 2018 at 01:58:32PM -0700, Andrey Smirnov wrote: >> If address passed arm_create_pte() is not 1M (PGDIR_SIZE) aligned, >> page table that is created will end up having unexpected mapping >> offset, breaking "1:1 mapping" assumption and leading to bugs that are >> not immediately obvious in their nature. >> >> To prevent this and because all of the callers already do said >> alignement in-place, move the alignment code to be a part of > alignment > >> are_create_pte(). > arm_create_pte() > > > It is so easy to spot spelling errors made by others, > so why is it that one so often fails to find spelling > errors made by one self :-( > My bad, will fix in v4. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox