mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] lib/xymodem: Decrease read block timeout
Date: Mon, 10 Dec 2018 18:14:33 -0800	[thread overview]
Message-ID: <CAHQ1cqFqwp0GeuXCaKOf8Rg63HaBWm5_8xNcLekWgZaDJ1Cu=g@mail.gmail.com> (raw)
In-Reply-To: <20181210132719.15419-1-l.stach@pengutronix.de>

On Mon, Dec 10, 2018 at 5:27 AM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> From: Andrey Smirnov <andrew.smirnov@gmail.com>
>
> When operating at hight baudrates (> 1Mbaud) on a system that perfoms
> several polling tasks, it is often the case that xy_read_block()
> errors out due to the fact that incoming data overran serial FIFO and
> some of the payload got lost. For those kind of situations it is not
> very beneficital to wait for 3 seconds for every block lost this way,
> and decreasing it in order to force a quick NAK to the host is
> beneficial to overall throughput.
>
> This patch changes the timeout to be the bigger of 50ms or 10 times
> the about of time it'd take to transfer a single payload block for a
> given baudrate.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

I don't think this patch is really needed anymore. It was initially
created to alleviate problems there were encountered when doing X/Y
modem transfers on a system with a serdev driver running, but the
final version of the serdev code that landed in the tree allows
polling to be temporarily disabled by setting polling interval to 0:

https://git.pengutronix.de/cgit/barebox/tree/common/serdev.c#n78

IMHO, in light of that, a user would be better off disabling polling,
performing X/Y modem and re-enabling polling back rather than relying
on a faster failed transfer recovery due to this patch.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-12-11  2:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 13:27 Lucas Stach
2018-12-11  2:14 ` Andrey Smirnov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHQ1cqFqwp0GeuXCaKOf8Rg63HaBWm5_8xNcLekWgZaDJ1Cu=g@mail.gmail.com' \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox