mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 5/5] eeprom: at24: Convert the driver to NVMEM
Date: Thu, 5 Sep 2019 22:23:42 -0700	[thread overview]
Message-ID: <CAHQ1cqFtwrxRXSEMdWRGSMFFj3YC8zSGdKOhDYn+sJ94V7LdHA@mail.gmail.com> (raw)
In-Reply-To: <20190906013829.6a4c13a0dc780639b0b484b7@gmail.com>

On Thu, Sep 5, 2019 at 3:38 PM Antony Pavlov <antonynpavlov@gmail.com> wrote:
>
> On Mon, 12 Aug 2019 13:19:15 -0700
> Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
>
> Hi!
>
> Could you please test this patch with disabled NVMEM?
>
> I see that this patch leads to barebox crash in memory allocation code
> if CONFIG_NVMEM is not set.
>

Hmm, I think driver should just select CONFIG_NVMEM since it seems
pretty pointless without it. Totally missed that in my original patch,
sorry.
Will submit a fix for this shortly.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-09-06  5:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 20:19 [PATCH 1/5] nvmem: Use helper variable in nvmem_register_cdev() Andrey Smirnov
2019-08-12 20:19 ` [PATCH 2/5] nvmem: Use already existing dev pointer " Andrey Smirnov
2019-08-12 20:19 ` [PATCH 3/5] nvmem: Parse partitions information Andrey Smirnov
2019-08-12 20:19 ` [PATCH 4/5] eeprom: at24: Drop at24_cdev_protect() Andrey Smirnov
2019-08-12 20:19 ` [PATCH 5/5] eeprom: at24: Convert the driver to NVMEM Andrey Smirnov
2019-09-05 22:38   ` Antony Pavlov
2019-09-06  5:23     ` Andrey Smirnov [this message]
2019-08-16 11:43 ` [PATCH 1/5] nvmem: Use helper variable in nvmem_register_cdev() Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqFtwrxRXSEMdWRGSMFFj3YC8zSGdKOhDYn+sJ94V7LdHA@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox