From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fT4u0-0001XH-Aq for barebox@lists.infradead.org; Wed, 13 Jun 2018 12:29:29 +0000 Received: by mail-io0-x244.google.com with SMTP id f1-v6so3222066ioh.6 for ; Wed, 13 Jun 2018 05:29:18 -0700 (PDT) MIME-Version: 1.0 References: <20180612205310.25745-1-andrew.smirnov@gmail.com> <20180612205310.25745-32-andrew.smirnov@gmail.com> <20180613081237.mcer7kopptxx4t57@pengutronix.de> In-Reply-To: <20180613081237.mcer7kopptxx4t57@pengutronix.de> From: Andrey Smirnov Date: Wed, 13 Jun 2018 05:29:05 -0700 Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v5 31/54] Port from U-Boot To: Sascha Hauer Cc: Barebox List On Wed, Jun 13, 2018 at 1:12 AM Sascha Hauer wrote: > > On Tue, Jun 12, 2018 at 01:52:47PM -0700, Andrey Smirnov wrote: > > Signed-off-by: Andrey Smirnov > > --- > > include/linux/iopoll.h | 69 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 69 insertions(+) > > create mode 100644 include/linux/iopoll.h > > > > diff --git a/include/linux/iopoll.h b/include/linux/iopoll.h > > new file mode 100644 > > index 000000000..6e8a6fd71 > > --- /dev/null > > +++ b/include/linux/iopoll.h > > @@ -0,0 +1,69 @@ > > +/* > > + * Copyright (c) 2012-2014 The Linux Foundation. All rights reserved. > > + * > > + * SPDX-License-Identifier: GPL-2.0 > > + */ > > + > > +#ifndef _LINUX_IOPOLL_H > > +#define _LINUX_IOPOLL_H > > + > > +#include > > +#include > > +#include > > + > > +/** > > + * readx_poll_timeout - Periodically poll an address until a condition is met or a timeout occurs > > + * @op: accessor function (takes @addr as its only argument) > > + * @addr: Address to poll > > + * @val: Variable to read the value into > > + * @cond: Break condition (usually involving @val) > > + * @timeout_ns: Timeout in ns, 0 means never timeout > > nanoseconds here, > > > + * > > + * Returns 0 on success and -ETIMEDOUT upon a timeout. In either > > + * case, the last read value at @addr is stored in @val. > > + * > > + * When available, you'll probably want to use one of the specialized > > + * macros defined below rather than this macro directly. > > + */ > > +#define readx_poll_timeout(op, addr, val, cond, timeout_ns) \ > > and here, > > > +({ \ > > + uint64_t start = get_time_ns(); \ > > + for (;;) { \ > > + (val) = op(addr); \ > > + if (cond) \ > > + break; \ > > + if (timeout_ns && \ > > + is_timeout(start, (timeout_ns))) { \ > > + (val) = op(addr); \ > > + break; \ > > + } \ > > + } \ > > + (cond) ? 0 : -ETIMEDOUT; \ > > +}) > > + > > + > > +#define readb_poll_timeout(addr, val, cond, timeout_us) \ > > + readx_poll_timeout(readb, addr, val, cond, timeout_us) > > but microseconds here? > > We should be consistent to the kernel API here, it's too easy to just > copy Linux code without noticing that the units are different. > OK, I'll change the patch to match kernel API and use microseconds everywhere in v6. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox