mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH 7/7] commands: Add mdio_read and mdio_write
Date: Thu, 28 Jan 2016 10:00:00 -0800	[thread overview]
Message-ID: <CAHQ1cqG9YZbwE2CwD2c5T5F+LUOAuXbdEjT-fruTQ=yVSp52CQ@mail.gmail.com> (raw)
In-Reply-To: <20160127072629.GG13058@pengutronix.de>

On Tue, Jan 26, 2016 at 11:26 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Tue, Jan 26, 2016 at 06:09:00PM -0800, Andrey Smirnov wrote:
>> On Tue, Jan 26, 2016 at 1:55 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>> > On Mon, Jan 25, 2016 at 09:55:58PM -0800, Andrey Smirnov wrote:
>> >> Add commands for low-level access to MDIO bus.
>> >
>> > Do we really need this? We can already read/write phy registers using
>> > /dev/phyx which imo is quite convenient since it can be accessed with
>> > regular md/mw commands.
>> >
>> > This of course is currently limited to the phys that are actually
>> > registered, you can't just bang on MDIO addresses on which no phys are
>> > registered. Maybe we could register all phys on a MDIO bus instead of
>> > only the used ones?
>>
>> Just to explain the purpose of this patch -- there are number of
>> reasons we might want to be able to access "unregistered" PHYs:
>>
>> - Not all MDIO attached devices would have PHYSID1,2 registers
>> available which might cause mdiobus_scan() to not detect those PHYs
>>
>> - MDIO bus troubleshooting
>>
>> As for registering all PHYs on a bus, correct me if I am wrong but
>> that would result in 32*N number of entries in /dev, where N is number
>> of MDIO buses in the system. The device I am working with right now
>> has 3 MDIO buses which would mean that I'd end up with 96 additional
>> entries in /dev, which might be a little bit overwhelming from UI
>> point of view. The other UI problem with that approach is that
>> /dev/phy's are numbered linearly so in order to figure out how to
>> access device on bus N at address M, user would have to perform N*32 +
>> M in their head.
>
> We could register the phys with name like:
>
>         "mdio%d-phy%02x", dev->bus->dev.id, mdev->addr
>
> That would make it clear which phy belongs to which bus.
>

Fair enough, I'll update the v2 to implement your and Trent's suggestions.

Thank you,
Andrey

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2016-01-28 18:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26  5:55 [PATCH 1/7] include/linux/phy.h: Add MII_ADDR_C45 Andrey Smirnov
2016-01-26  5:55 ` [PATCH 2/7] net: Port bitbanged MDIO code from Linux kernel Andrey Smirnov
2016-01-26  5:55 ` [PATCH 3/7] miitool: Fix PHY argument handling Andrey Smirnov
2016-01-26  5:55 ` [PATCH 4/7] mdio_bus: Change dev_info to dev_dbg Andrey Smirnov
2016-01-26  5:55 ` [PATCH 5/7] mdio_bus: Add mdiobus_get_bus() function Andrey Smirnov
2016-01-26  5:55 ` [PATCH 6/7] miitool: Don't print negative parent IDs Andrey Smirnov
2016-01-26  5:55 ` [PATCH 7/7] commands: Add mdio_read and mdio_write Andrey Smirnov
2016-01-26 21:55   ` Sascha Hauer
2016-01-27  2:09     ` Andrey Smirnov
2016-01-27  2:29       ` Trent Piepho
2016-01-27  7:19         ` Sascha Hauer
2016-01-27  7:26       ` Sascha Hauer
2016-01-28 18:00         ` Andrey Smirnov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHQ1cqG9YZbwE2CwD2c5T5F+LUOAuXbdEjT-fruTQ=yVSp52CQ@mail.gmail.com' \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox