From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1giPL2-0001j2-2p for barebox@lists.infradead.org; Sat, 12 Jan 2019 19:53:01 +0000 Received: by mail-wr1-x442.google.com with SMTP id r10so18671057wrs.10 for ; Sat, 12 Jan 2019 11:52:59 -0800 (PST) MIME-Version: 1.0 References: <20190112072234.21878-1-andrew.smirnov@gmail.com> <20190112072234.21878-8-andrew.smirnov@gmail.com> <20190112110400.GE14273@ravnborg.org> In-Reply-To: <20190112110400.GE14273@ravnborg.org> From: Andrey Smirnov Date: Sat, 12 Jan 2019 11:52:47 -0800 Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 07/16] PCI: Make pci_scan_bus static To: Sam Ravnborg Cc: Barebox List On Sat, Jan 12, 2019 at 3:04 AM Sam Ravnborg wrote: > > On Fri, Jan 11, 2019 at 11:22:25PM -0800, Andrey Smirnov wrote: > > Pci_scan_bus is not used anyhwere outside pci.c. Mark in static to > > reflect that. No functional change intended. > > > > Signed-off-by: Andrey Smirnov > > --- > > drivers/pci/pci.c | 4 +++- > > include/linux/pci.h | 1 - > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index 198ec9e995..b0f5ac1b15 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -4,6 +4,8 @@ > > #include > > #include > > > > +static unsigned int pci_scan_bus(struct pci_bus *bus); > > Move function to avoid this forward? > I'd rather keep the diff to a minimum, I'll leave it up to Sascha if he wants to do what you suggest instead. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox