mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 14/27] console: Consolidate DEBUG_LL and CONSOLE_* puts() implementations
Date: Mon, 18 Jun 2018 13:26:17 -0700	[thread overview]
Message-ID: <CAHQ1cqGDP=-9m0bCWRdig==3Pp-Q86OGo+Axre0WDBV1KLks_Q@mail.gmail.com> (raw)
In-Reply-To: <20180618202237.pxfxnmp2eb2mp62o@pengutronix.de>

On Mon, Jun 18, 2018 at 1:22 PM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> On Thu, Jun 14, 2018 at 09:11:23PM -0700, Andrey Smirnov wrote:
> > Similar to previous commit, consolidate DEBUG_LL and CONSOLE_* puts()
> > implementations by putting them into a shared macro.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > ---
> >  include/debug_ll.h | 23 +++++++++++++++++++----
> >  lib/console.c      | 13 ++++++-------
> >  2 files changed, 25 insertions(+), 11 deletions(-)
> >
> > diff --git a/include/debug_ll.h b/include/debug_ll.h
> > index 4032ced95..4dcbd0434 100644
> > --- a/include/debug_ll.h
> > +++ b/include/debug_ll.h
> > @@ -54,6 +54,24 @@
> >               __n;                            \
> >       })
> >
> > +/**
> > + * __do_puts - Macro implementing puts()
> > + *
> > + * @__putc:  Single argument or a macro that implements putc()
> > + * @___s:    String to print
> > + *
> > + * Internal macro used to implement puts_ll() and __console_puts()
> > + */
> > +#define __do_puts(__putc, ___s)                      \
> > +     ({                                      \
> > +             const char *__s = (___s);       \
> > +             int __n = 0;                    \
> > +                                             \
> > +             while (*__s)                    \
> > +                     __n += __putc(*__s++);  \
> > +             __n;                            \
> > +     })
>
> I don't like this. It's a simple loop and there's nothing bad with it
> when the same loop is present twice in barebox. No need to dig into
> CPP here.
>

OK, will drop in v2.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-06-18 20:26 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15  4:11 [PATCH 00/27] Console code consolidation Andrey Smirnov
2018-06-15  4:11 ` [PATCH 01/27] pbl: console: Introduce putc_func_t Andrey Smirnov
2018-06-15  4:11 ` [PATCH 02/27] console: Unify console_simple.c and pbl/console.c Andrey Smirnov
2018-06-15  4:49   ` Sam Ravnborg
2018-06-15 12:22     ` Andrey Smirnov
2018-06-15  4:58   ` Sam Ravnborg
2018-06-15  7:26     ` Sascha Hauer
2018-06-15 11:36       ` Andrey Smirnov
2018-06-15 12:18     ` Andrey Smirnov
2018-06-15  4:11 ` [PATCH 03/27] pbl: console: Move '\n' handling into console_putc() Andrey Smirnov
2018-06-15  4:11 ` [PATCH 04/27] console: Reconcile 3 different puts() implementations Andrey Smirnov
2018-06-15  7:37   ` Sascha Hauer
2018-06-15 11:33     ` Andrey Smirnov
2018-06-15  4:11 ` [PATCH 05/27] ratp: Add dependency on CONSOLE_FULL Andrey Smirnov
2018-06-15  4:11 ` [PATCH 06/27] netconsole: " Andrey Smirnov
2018-06-15  4:11 ` [PATCH 07/27] input: " Andrey Smirnov
2018-06-15  4:11 ` [PATCH 08/27] console: Make use of __console_putc() Andrey Smirnov
2018-06-15  4:11 ` [PATCH 09/27] console: Fix console_get_first_active() Andrey Smirnov
2018-06-15  4:11 ` [PATCH 10/27] console: Simplify early console code Andrey Smirnov
2018-06-15  4:11 ` [PATCH 11/27] console: Consolidate all implemenatations of ctrlc() Andrey Smirnov
2018-06-15  4:11 ` [PATCH 12/27] console: Drop ARCH_HAS_CTRLC Andrey Smirnov
2018-06-15  4:11 ` [PATCH 13/27] console: Consolidate DEBUG_LL and CONSOLE_* '\n' -> '\n\r' code Andrey Smirnov
2018-06-18 20:18   ` Sascha Hauer
2018-06-18 20:25     ` Andrey Smirnov
2018-06-15  4:11 ` [PATCH 14/27] console: Consolidate DEBUG_LL and CONSOLE_* puts() implementations Andrey Smirnov
2018-06-18 20:22   ` Sascha Hauer
2018-06-18 20:26     ` Andrey Smirnov [this message]
2018-06-15  4:11 ` [PATCH 15/27] console_simple: Use console_flush() from CONSOLE_FULL Andrey Smirnov
2018-06-15  4:11 ` [PATCH 16/27] console_simple: Use tstc_raw() as tstc() Andrey Smirnov
2018-06-15  4:11 ` [PATCH 17/27] console_simple: Use getc_raw() as getchar() Andrey Smirnov
2018-06-15  4:11 ` [PATCH 18/27] console_simple: Get rid of global console pointer Andrey Smirnov
2018-06-15  4:11 ` [PATCH 19/27] console_simple: Make use of list_add_tail() Andrey Smirnov
2018-06-15  4:11 ` [PATCH 20/27] console: Share definition for printf with PBL Andrey Smirnov
2018-06-15  4:11 ` [PATCH 21/27] pbl: console: Convert pr_print into a single line #define Andrey Smirnov
2018-06-15  4:11 ` [PATCH 22/27] " Andrey Smirnov
2018-06-15  4:11 ` [PATCH 23/27] console: Remove dputc() Andrey Smirnov
2018-06-15  4:11 ` [PATCH 24/27] console: Simplify dputs() Andrey Smirnov
2018-06-15  4:11 ` [PATCH 25/27] console: Introduce dvprintf() Andrey Smirnov
2018-06-15  4:11 ` [PATCH 26/27] console: Convert printf() into a single line #define Andrey Smirnov
2018-06-15  4:11 ` [PATCH 27/27] psci: console: Convert to use lib/console.c Andrey Smirnov
2018-06-15  9:28 ` [PATCH 00/27] Console code consolidation Sascha Hauer
2018-06-15 12:11   ` Andrey Smirnov
2018-06-18 20:49     ` Sascha Hauer
2018-06-18 23:26       ` Andrey Smirnov
2018-06-19  6:44         ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHQ1cqGDP=-9m0bCWRdig==3Pp-Q86OGo+Axre0WDBV1KLks_Q@mail.gmail.com' \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox