From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH 0/9] i.MX7 SabreSD support
Date: Mon, 24 Jul 2017 12:29:00 -0700 [thread overview]
Message-ID: <CAHQ1cqGbTRq_a=rM0Dq=yw8w+By7n=oFHxvRs4Damy7oX9vi0g@mail.gmail.com> (raw)
In-Reply-To: <20170724160158.GC18294@ravnborg.org>
On Mon, Jul 24, 2017 at 9:01 AM, Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Andrey.
>
>> Also, note, that for a reason I haven't been able to track down yet,
>> compiling Barebox + this patchset without support for FEC will cause
>> upstream kernel (at least 4.12-rc1) to hang during boot while trying
>> to access FEC's register file. I suspect clock initialization issue,
>> but, as I said, I did not find that out conclusively.
> Maybe you should include this explanation in the patch that
> enables this option?
>
I seemed like a kernel problem, so there's no code in the patchset
that reflects this "limitation", meaning FEC driver is not
automatically enabled if i.MX7 SabreSD is selected, so I don't know if
there's a better place to put this note.
>>
>> Anyway, as usual, any feedback is wellcome.
>
> I have browsed the patches, and provided a little feedback.
> Apart form this the series looks good to me.
>
> But then for most parts I am not intiminate with the
> code so do not assume too much based on this.
>
Regardless, it was still useful feedback.
Thanks!
Andrey Smirnov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-07-24 19:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 14:53 Andrey Smirnov
2017-07-24 14:53 ` [PATCH 1/9] gpiolib: Fix buggy flag detection code Andrey Smirnov
2017-07-24 15:36 ` Sam Ravnborg
2017-07-24 19:30 ` Andrey Smirnov
2017-07-24 14:53 ` [PATCH 2/9] clk: i.MX7: Remove unused UART clocks array Andrey Smirnov
2017-07-24 14:53 ` [PATCH 3/9] ARM: i.MX: Import mx7d_pins.h from U-Boot Andrey Smirnov
2017-07-24 14:53 ` [PATCH 4/9] ARM: i.MX: Add mx7_setup_pad() Andrey Smirnov
2017-07-24 14:53 ` [PATCH 5/9] ARM: i.MX: Add imx7_uart_setup_ll() Andrey Smirnov
2017-07-24 14:53 ` [PATCH 6/9] ARM: i.MX: Add minimal imx7-ccm-regs.h Andrey Smirnov
2017-07-24 14:53 ` [PATCH 7/9] ARM: i.MX: Add ARCH_HAD_FEC_IMX to ARCH_IMX7 Andrey Smirnov
2017-07-24 14:53 ` [PATCH 8/9] ARM: i.MX: Import imx7-iomuxc-gpr.h from Linux kernel Andrey Smirnov
2017-07-24 14:54 ` [PATCH 9/9] ARM: i.MX: Add support for NXP i.MX7 SABRESD board Andrey Smirnov
2017-07-24 15:59 ` Sam Ravnborg
2017-07-24 19:20 ` Andrey Smirnov
2017-07-24 19:03 ` Stefan Lengfeld
2017-07-24 19:23 ` Andrey Smirnov
2017-07-24 16:01 ` [PATCH 0/9] i.MX7 SabreSD support Sam Ravnborg
2017-07-24 19:29 ` Andrey Smirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQ1cqGbTRq_a=rM0Dq=yw8w+By7n=oFHxvRs4Damy7oX9vi0g@mail.gmail.com' \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox