mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [RFC, PATCH] i.MX6: phytec: Do not hardcode default environment
Date: Tue, 6 Jan 2015 12:15:05 -0800	[thread overview]
Message-ID: <CAHQ1cqH+z2uBW7BtiFfcOio9KyH9Bis3gFzKgiN4Qme10tCR+A@mail.gmail.com> (raw)
In-Reply-To: <20150105090651.GD30369@pengutronix.de>

> Looking at it you should rather replace the compatible checks in
> phytec_pfla02_init with their baseboards, so instead of:
>
>         if (!of_machine_is_compatible("phytec,imx6q-pfla02") &&
>                         !of_machine_is_compatible("phytec,imx6dl-pfla02") &&
>                         !of_machine_is_compatible("phytec,imx6s-pfla02"))
>                 return 0;
>
> do a:
>
>         if (!of_machine_is_compatible("phytec,imx6x-pbab01") &&
>                         !of_machine_is_compatible("phytec,imx6dl-pbab05") &&
>                         !of_machine_is_compatible("phytec,imx6q-pbab02"))
>                 return 0;
>
> Then the phytec default env will only be added for the phytec baseboards
> and not for your custom one. Note phyflex_err006282_workaround() won't
> be called either then, you may need your own version of this then.
>

Good point. I'll look into it.

Thanks,
Andrey

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-01-06 20:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-31 16:49 Andrey Smirnov
2014-12-31 17:37 ` Alexander Aring
2015-01-05  9:06 ` Sascha Hauer
2015-01-06 20:15   ` Andrey Smirnov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ1cqH+z2uBW7BtiFfcOio9KyH9Bis3gFzKgiN4Qme10tCR+A@mail.gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox