From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH 3/5] net: phy: Port MDIO bus miltiplexer framework from Linux kernel
Date: Mon, 4 Dec 2017 07:13:08 -0800 [thread overview]
Message-ID: <CAHQ1cqHQbMoz4Ab66ENvO-440oPJbOAyi+qUsOEerRMa2U4Edw@mail.gmail.com> (raw)
In-Reply-To: <20171201111210.3t2xzyrpfrzvkp72@pengutronix.de>
On Fri, Dec 1, 2017 at 3:12 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Tue, Nov 28, 2017 at 08:55:04PM -0800, Andrey Smirnov wrote:
>> Port mdio-mux.c from Linux kernel to Barebox, to support adding
>> dirvers that rely on that infrastructure/API.
>>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>> ---
>> drivers/net/phy/Kconfig | 8 +++
>> drivers/net/phy/Makefile | 2 +
>> drivers/net/phy/mdio-mux.c | 145 +++++++++++++++++++++++++++++++++++++++++++++
>> include/linux/mdio-mux.h | 30 ++++++++++
>> 4 files changed, 185 insertions(+)
>> create mode 100644 drivers/net/phy/mdio-mux.c
>> create mode 100644 include/linux/mdio-mux.h
>>
>> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
>> index ea2e06265..f423d9ba3 100644
>> --- a/drivers/net/phy/Kconfig
>> +++ b/drivers/net/phy/Kconfig
>> @@ -66,6 +66,14 @@ config MDIO_GPIO
>> ---help---
>> Supports GPIO lib-based MDIO busses.
>>
>> +config MDIO_BUS_MUX
>> + bool
>
> Indentation gone wrong here.
>
Missed that. Will fix in v2.
>> + help
>> + This module provides a driver framework for MDIO bus
>> + multiplexers which connect one of several child MDIO busses
>> + to a parent bus. Switching between child busses is done by
>> + device specific drivers.
>> +
>
> ...
>
>> + for_each_available_child_of_node(mux_node, child_bus_node) {
>> + int v;
>> +
>> + r = of_property_read_u32(child_bus_node, "reg", &v);
>> + if (r) {
>> + dev_err(dev,
>> + "Error: Failed to find reg for child %pOF\n",
>> + child_bus_node);
>> + continue;
>> + }
>> +
>> + /*
>> + FIXME:
>> + */
>
> What do you have to fix here?
>
That's a leftover from earlier version of the code that I forgot to
remove. Will do in v2.
Thanks,
Andrey Smirnov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-12-04 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 4:55 [PATCH 1/5] ARM: vybrid: zii: Make use of DT code " Andrey Smirnov
2017-11-29 4:55 ` [PATCH 2/5] mdio_bus: Port of_mdio_find_bus() " Andrey Smirnov
2017-11-29 4:55 ` [PATCH 3/5] net: phy: Port MDIO bus miltiplexer framework " Andrey Smirnov
2017-12-01 11:12 ` Sascha Hauer
2017-12-04 15:13 ` Andrey Smirnov [this message]
2017-11-29 4:55 ` [PATCH 4/5] net: phy: Port GPIO controlled MDIO multiplexer driver Andrey Smirnov
2017-11-29 4:55 ` [PATCH 5/5] net: mdio-mux: Avoid probing multiplexed busses Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHQ1cqHQbMoz4Ab66ENvO-440oPJbOAyi+qUsOEerRMa2U4Edw@mail.gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox