From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] bbu: Look for default handler in barebox_update_handler_exists()
Date: Thu, 30 Aug 2018 22:23:12 -0700 [thread overview]
Message-ID: <CAHQ1cqHU+9HkpOKQTrgasO8X=6stVxy63LZ6wdHAYLKisjkqaw@mail.gmail.com> (raw)
In-Reply-To: <20180829075844.xbolj65w3vksngvu@pengutronix.de>
On Wed, Aug 29, 2018 at 12:58 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> On Wed, Aug 29, 2018 at 12:21:52AM -0700, Andrey Smirnov wrote:
> > Convert barebox_update_handler_exists() to treat struct bbu_data with
> > both "handler_name" and "devicefile" set to NULL as a specifier for
> > default update handler in order to support such use-case for
> > "barebox_update" and fix a recent regression.
> >
> > This change shouldn't affect another user of
> > barebox_update_handler_exists(), cb_flash() in
> > drivers/usb/gadget/f_fastboot.c, since that function explicitly
> > specifies "devicefile".
> >
> > Fixes 0ac96ab6e ("bbu: command: Make sure specified update handler exists")
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > ---
> > common/bbu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/common/bbu.c b/common/bbu.c
> > index 3974bf672..ffe5e15a2 100644
> > --- a/common/bbu.c
> > +++ b/common/bbu.c
> > @@ -148,7 +148,7 @@ bool barebox_update_handler_exists(struct bbu_data *data)
> > if (handler)
> > return true;
> >
> > - if (!data->handler_name)
> > + if (!data->handler_name && data->devicefile)
> > return false;
> >
> > return bbu_find_handler(data->handler_name) != NULL;
>
> This function is confusing. We should split this up into two functions:
> barebox_update_handler_exists_for_name() and
> barebox_update_handler_exists_for_devpath() *). Fastboot would only need
> the latter and the barebox_update command would use both, possibly
> barking when both a name and a device is given (as otherwise we would
> have to check for name <-> devpath conflicts)
>
What if we just expose already existing bbu_find_handler (potentially
renaming it to bbu_find_handler_by_name()) and
bbu_find_handler_by_device() instead and use them as you propose?
Thanks,
Andrey Smirnov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-08-31 5:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:21 Andrey Smirnov
2018-08-29 7:21 ` [PATCH 2/2] commands: barebox-update: Improve nonexistent handler reporting Andrey Smirnov
2018-08-29 7:58 ` [PATCH 1/2] bbu: Look for default handler in barebox_update_handler_exists() Sascha Hauer
2018-08-31 5:23 ` Andrey Smirnov [this message]
2018-08-31 6:40 ` Sascha Hauer
2018-09-04 6:35 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQ1cqHU+9HkpOKQTrgasO8X=6stVxy63LZ6wdHAYLKisjkqaw@mail.gmail.com' \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox