From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH 4/4] usb-nop-xceiv: Add support for 'reset-gpios' binding
Date: Tue, 23 May 2017 17:17:45 -0700 [thread overview]
Message-ID: <CAHQ1cqHtZ6O3fNzfy39z_HQqfYsyYgybiKZYwdKMX45EHw94=Q@mail.gmail.com> (raw)
In-Reply-To: <402515be-7bed-cbad-449d-907747f0b513@cogentembedded.com>
On Mon, May 22, 2017 at 11:55 PM, Nikita Yushchenko
<nikita.yoush@cogentembedded.com> wrote:
>> +
>> + if (gpio_is_valid(nopphy->reset)) {
>> + /*
>> + * Let's wait for 100 ms before deasserting reset line
>> + */
>> + mdelay(100);
>> + gpio_direction_output(nopphy->reset, 0);
>> + }
>
> Why not gpio_set_value() here? Direction is already configured at this
> stage.
No reason, really. I'll fix it in v2.
Thanks,
Andrey Smirnov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-05-24 0:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 15:24 [PATCH 1/4] gpio-imx: Do not use gpio_set_value() Andrey Smirnov
2017-05-22 15:24 ` [PATCH 2/4] gpiolib: Add code to support "active low" GPIOs Andrey Smirnov
2017-05-23 6:30 ` Nikita Yushchenko
2017-05-23 8:33 ` Sascha Hauer
2017-05-24 0:16 ` Andrey Smirnov
2017-05-24 0:14 ` Andrey Smirnov
2017-05-24 7:26 ` Nikita Yushchenko
2017-05-24 18:16 ` Trent Piepho
2017-05-24 20:36 ` Andrey Smirnov
2017-05-25 6:36 ` Nikita Yushchenko
2017-05-25 17:10 ` Andrey Smirnov
2017-05-25 17:45 ` Sascha Hauer
2017-05-22 15:24 ` [PATCH 3/4] gpiolib: Add support for GPIO "hog" nodes Andrey Smirnov
2017-05-23 6:52 ` Nikita Yushchenko
2017-05-23 23:25 ` Andrey Smirnov
2017-05-24 6:43 ` Nikita Yushchenko
2017-05-30 14:38 ` Andrey Smirnov
2017-05-24 7:26 ` Sascha Hauer
2017-05-22 15:24 ` [PATCH 4/4] usb-nop-xceiv: Add support for 'reset-gpios' binding Andrey Smirnov
2017-05-23 6:55 ` Nikita Yushchenko
2017-05-24 0:17 ` Andrey Smirnov [this message]
2017-05-23 6:08 ` [PATCH 1/4] gpio-imx: Do not use gpio_set_value() Nikita Yushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQ1cqHtZ6O3fNzfy39z_HQqfYsyYgybiKZYwdKMX45EHw94=Q@mail.gmail.com' \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=cphealy@gmail.com \
--cc=nikita.yoush@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox