mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Fabio Porcedda <fabio.porcedda@gmail.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] at91sam9260/9g20ek: remove #ifdef for ek_usb_add_device_mci()
Date: Fri, 15 Feb 2013 12:14:29 +0100	[thread overview]
Message-ID: <CAHkwnC8_Kszke2aCfViNsCuS2+TtK3wXAG5LkuZQ5qFRKVyxYw@mail.gmail.com> (raw)
In-Reply-To: <CAHkwnC_-nyVTh_R_7P0dBPFA-c9rjG8j2UtsCT8+OJEk+0NM7A@mail.gmail.com>

On Fri, Feb 15, 2013 at 11:52 AM, Fabio Porcedda
<fabio.porcedda@gmail.com> wrote:
> On Fri, Feb 15, 2013 at 11:44 AM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
>> On 11:41 Fri 15 Feb     , Fabio Porcedda wrote:
>>> Remove #ifdef for ek_usb_add_device_mci() because there is already
>>> the #ifdef inside at91_add_device_mci(), this way the compiler can check
>>> always the code without any penality.
>>  it's not the struct will be keep
>
> The struct isn't keep
> without this patch:
>   text       data        bss        dec        hex    filename
>     877        192          0       1069        42d
> arch/arm/boards/at91sam9260ek/init.o
> with this patch:
>  text       data        bss        dec        hex    filename
>     877        192          0       1069        42d
> arch/arm/boards/at91sam9260ek/init.o


I'm sorry, you are right, i've made i mistake when checking.

  text       data        bss        dec        hex    filename
    861        176          0       1037        40d
arch/arm/boards/at91sam9260ek/init.o

  text       data        bss        dec        hex    filename
    877        192          0       1069        42d
arch/arm/boards/at91sam9260ek/init.o


>>  keep the ifdef
>> Best Regards,
>> J.
>
> Best regards
> --
> Fabio Porcedda



--
Fabio Porcedda

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2013-02-15 11:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15 10:41 [PATCH 0/2] at91sam9260/9g20ek: cleanup and optimization Fabio Porcedda
2013-02-15 10:41 ` [PATCH 1/2] at91sam9260/9g20ek: use IS_ENABLED instead of #if/#ifdef Fabio Porcedda
2013-02-15 10:47   ` Fabio Porcedda
2013-02-15 10:41 ` [PATCH 2/2] at91sam9260/9g20ek: remove #ifdef for ek_usb_add_device_mci() Fabio Porcedda
2013-02-15 10:44   ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-15 10:52     ` Fabio Porcedda
2013-02-15 11:14       ` Fabio Porcedda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHkwnC8_Kszke2aCfViNsCuS2+TtK3wXAG5LkuZQ5qFRKVyxYw@mail.gmail.com \
    --to=fabio.porcedda@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox