Re: [PATCH] fix compiler warnings: use puts() instead of printf()

[Fabio Porcedda <fabio.porcedda@gmail.com>]

On Mon, Feb 25, 2013 at 2:16 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
> On 13:23 Mon 25 Feb     , Fabio Porcedda wrote:
>> On Mon, Feb 25, 2013 at 1:02 PM, Jean-Christophe PLAGNIOL-VILLARD
>> <plagnioj@jcrosoft.com> wrote:
>> > On 09:31 Thu 21 Feb     , Fabio Porcedda wrote:
>> >> Use puts() because printf() isn't necessary,
>> >> to fix the following compiler warnings:
>> >>
>> >> /barebox/common/menu.c: In function ‘menu_show’:
>> >> /barebox/common/menu.c:277:4: warning: format not a string literal and no format arguments [-Wformat-security]
>> >>
>> >> /barebox/scripts/omap4_usbboot.c: In function ‘read_asic_id’:
>> >> /barebox/scripts/omap4_usbboot.c:101:3: warning: format not a string literal and no format arguments [-Wformat-security]
>> >
>> > Sascha revert this please this add a "\n" that we do not want
>> > specially on the menu
>>
>> I've already sent a patch to fix the newline problem and the warning too.
>> Reverting the patch doesn't fix the warning.
> the patch is wrong we revert you send the write one

I understand that the patch is wrong but the patch cannot be simply
reverted because in master there is already a partial fix for it:
"OMAP4 USB BOOT: remove double line endings".

Only half of the patch can be reverted but instead of reverting it we
can fix it.
I've already sent the patch to fix the remaining part:
" menu: fix remove superfluous newline: change puts() -> printf("%s, )"

What do you think about that patch?

Best regards
Fabio Porcedda

> Best Regards,
> J.
>>
>> Best regards
>> Fabio Porcedda
>>
>> > Best Regards,
>> > J.
>> >>
>> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> >> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>> >> Cc: Vicente <vicencb@gmail.com>
>> >> ---
>> >>  common/menu.c           | 2 +-
>> >>  scripts/omap4_usbboot.c | 2 +-
>> >>  2 files changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >> diff --git a/common/menu.c b/common/menu.c
>> >> index ce93838..30dced7 100644
>> >> --- a/common/menu.c
>> >> +++ b/common/menu.c
>> >> @@ -274,7 +274,7 @@ int menu_show(struct menu *m)
>> >>                       printf("Auto Select in");
>> >>               } else {
>> >>                       auto_display_len = strlen(m->auto_display);
>> >> -                     printf(m->auto_display);
>> >> +                     puts(m->auto_display);
>> >>               }
>> >>               printf(" %2d", countdown--);
>> >>       }
>> >> diff --git a/scripts/omap4_usbboot.c b/scripts/omap4_usbboot.c
>> >> index 8c5775d..34e53c0 100644
>> >> --- a/scripts/omap4_usbboot.c
>> >> +++ b/scripts/omap4_usbboot.c
>> >> @@ -98,7 +98,7 @@ int read_asic_id(struct usb_handle *usb)
>> >>                       sprintf(line+4+j*3, "%02X ", id[i+j]);
>> >>               line[4+j*3+0] = '\n';
>> >>               line[4+j*3+1] = 0;
>> >> -             printf(line);
>> >> +             puts(line);
>> >>       }
>> >>       ret = 0;
>> >>       for (i = 1, j = 0; i < sizeof(id) && j < id[0]; i += 2+id[i+1], j++) {
>> >> --
>> >> 1.8.1.1
>> >>
>>
>>
>>
>> --
>> Fabio Porcedda



--
Fabio Porcedda

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox