[PATCH v2 next 0/2] defenv2: complete move config-board out of /env/init

[PATCH v2 next 0/2] defenv2: complete move config-board out of /env/init

[Fabio Porcedda]

v2:
 - add patch 2/2 for telit-evk-pro3

Fabio Porcedda (2):
  defenv2: comment setting default values in /env/config
  ARM at91 telit-evk-pro3: move config-board out of /env/init

 arch/arm/boards/telit-evk-pro3/env/config-board      | 8 ++++++++
 arch/arm/boards/telit-evk-pro3/env/init/config-board | 8 --------
 defaultenv-2/base/config                             | 8 ++++----
 3 files changed, 12 insertions(+), 12 deletions(-)
 create mode 100644 arch/arm/boards/telit-evk-pro3/env/config-board
 delete mode 100644 arch/arm/boards/telit-evk-pro3/env/init/config-board

-- 
1.8.1.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH v2 next 1/2] defenv2: comment setting default values in /env/config

[Fabio Porcedda]

There is no need to set againg deafult values in /env/config
because they are already setted in /env/bin/init,
that allow /env/config-board to change those default values
without being overwritten by /env/config.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 defaultenv-2/base/config | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/defaultenv-2/base/config b/defaultenv-2/base/config
index 189e5a6..dec0595 100644
--- a/defaultenv-2/base/config
+++ b/defaultenv-2/base/config
@@ -6,16 +6,16 @@
 #global.hostname=
 
 # set to false if you do not want to have colors
-global.allow_color=true
+#global.allow_color=true
 
 # user (used for network filenames)
-global.user=none
+#global.user=none
 
 # timeout in seconds before the default boot entry is started
-global.autoboot_timeout=3
+#global.autoboot_timeout=3
 
 # default boot entry (one of /env/boot/*)
-global.boot.default=net
+#global.boot.default=net
 
 # base bootargs
 #global.linux.bootargs.base="console=ttyS0,115200"
-- 
1.8.1.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH v2 next 2/2] ARM at91 telit-evk-pro3: move config-board out of /env/init

[Fabio Porcedda]

This is to complete the work of two recent commits:
- defenv2: move config-board out of /env/init
- defenv2: comment setting default values in /env/config

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 arch/arm/boards/telit-evk-pro3/env/config-board      | 8 ++++++++
 arch/arm/boards/telit-evk-pro3/env/init/config-board | 8 --------
 2 files changed, 8 insertions(+), 8 deletions(-)
 create mode 100644 arch/arm/boards/telit-evk-pro3/env/config-board
 delete mode 100644 arch/arm/boards/telit-evk-pro3/env/init/config-board

diff --git a/arch/arm/boards/telit-evk-pro3/env/config-board b/arch/arm/boards/telit-evk-pro3/env/config-board
new file mode 100644
index 0000000..741b902
--- /dev/null
+++ b/arch/arm/boards/telit-evk-pro3/env/config-board
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+# board defaults, do not change in running system. Change /env/config
+# instead
+
+global.hostname=evk-pro3
+global.linux.bootargs.base="console=ttyS0,115200"
+global.boot.default=nand-ubi
diff --git a/arch/arm/boards/telit-evk-pro3/env/init/config-board b/arch/arm/boards/telit-evk-pro3/env/init/config-board
deleted file mode 100644
index 741b902..0000000
--- a/arch/arm/boards/telit-evk-pro3/env/init/config-board
+++ /dev/null
@@ -1,8 +0,0 @@
-#!/bin/sh
-
-# board defaults, do not change in running system. Change /env/config
-# instead
-
-global.hostname=evk-pro3
-global.linux.bootargs.base="console=ttyS0,115200"
-global.boot.default=nand-ubi
-- 
1.8.1.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 next 1/2] defenv2: comment setting default values in /env/config

[Fabio Porcedda]

On Fri, Feb 22, 2013 at 11:10 AM, Fabio Porcedda
<fabio.porcedda@gmail.com> wrote:
> There is no need to set againg deafult values in /env/config
> because they are already setted in /env/bin/init,
> that allow /env/config-board to change those default values
> without being overwritten by /env/config.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  defaultenv-2/base/config | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/defaultenv-2/base/config b/defaultenv-2/base/config
> index 189e5a6..dec0595 100644
> --- a/defaultenv-2/base/config
> +++ b/defaultenv-2/base/config
> @@ -6,16 +6,16 @@
>  #global.hostname=
>
>  # set to false if you do not want to have colors
> -global.allow_color=true
> +#global.allow_color=true
>
>  # user (used for network filenames)
> -global.user=none
> +#global.user=none
>
>  # timeout in seconds before the default boot entry is started
> -global.autoboot_timeout=3
> +#global.autoboot_timeout=3
>
>  # default boot entry (one of /env/boot/*)
> -global.boot.default=net
> +#global.boot.default=net
>
>  # base bootargs
>  #global.linux.bootargs.base="console=ttyS0,115200"
> --
> 1.8.1.1
>

This patch works fine on master too.

Best regards
-- 
Fabio Porcedda

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 next 0/2] defenv2: complete move config-board out of /env/init

[Sascha Hauer]

On Fri, Feb 22, 2013 at 11:10:40AM +0100, Fabio Porcedda wrote:
> v2:
>  - add patch 2/2 for telit-evk-pro3
> 
> Fabio Porcedda (2):
>   defenv2: comment setting default values in /env/config
>   ARM at91 telit-evk-pro3: move config-board out of /env/init
> 
>  arch/arm/boards/telit-evk-pro3/env/config-board      | 8 ++++++++
>  arch/arm/boards/telit-evk-pro3/env/init/config-board | 8 --------
>  defaultenv-2/base/config                             | 8 ++++----
>  3 files changed, 12 insertions(+), 12 deletions(-)
>  create mode 100644 arch/arm/boards/telit-evk-pro3/env/config-board
>  delete mode 100644 arch/arm/boards/telit-evk-pro3/env/init/config-board

Applied, thanks. I decided to apply it to next though as I tend to be
careful with changes to master.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 next 1/2] defenv2: comment setting default values in /env/config

[Alexander Aring]

Hi,

too late for this correction :(

On Fri, Feb 22, 2013 at 11:10:41AM +0100, Fabio Porcedda wrote:
> There is no need to set againg deafult values in /env/config

s/deafult/default/

> because they are already setted in /env/bin/init,
> that allow /env/config-board to change those default values
> without being overwritten by /env/config.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  defaultenv-2/base/config | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/defaultenv-2/base/config b/defaultenv-2/base/config
> index 189e5a6..dec0595 100644
> --- a/defaultenv-2/base/config
> +++ b/defaultenv-2/base/config
> @@ -6,16 +6,16 @@
>  #global.hostname=
>  
>  # set to false if you do not want to have colors
> -global.allow_color=true
> +#global.allow_color=true
>  
>  # user (used for network filenames)
> -global.user=none
> +#global.user=none
>  
>  # timeout in seconds before the default boot entry is started
> -global.autoboot_timeout=3
> +#global.autoboot_timeout=3
>  
>  # default boot entry (one of /env/boot/*)
> -global.boot.default=net
> +#global.boot.default=net
>  
>  # base bootargs
>  #global.linux.bootargs.base="console=ttyS0,115200"
> -- 
> 1.8.1.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 next 1/2] defenv2: comment setting default values in /env/config

[Fabio Porcedda]

On Sat, Feb 23, 2013 at 2:26 PM, Alexander Aring <alex.aring@gmail.com> wrote:
> Hi,
>
> too late for this correction :(
>
> On Fri, Feb 22, 2013 at 11:10:41AM +0100, Fabio Porcedda wrote:
>> There is no need to set againg deafult values in /env/config
>
> s/deafult/default/

Thanks for catching the typo.

>> because they are already setted in /env/bin/init,
>> that allow /env/config-board to change those default values
>> without being overwritten by /env/config.
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> ---
>>  defaultenv-2/base/config | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/defaultenv-2/base/config b/defaultenv-2/base/config
>> index 189e5a6..dec0595 100644
>> --- a/defaultenv-2/base/config
>> +++ b/defaultenv-2/base/config
>> @@ -6,16 +6,16 @@
>>  #global.hostname=
>>
>>  # set to false if you do not want to have colors
>> -global.allow_color=true
>> +#global.allow_color=true
>>
>>  # user (used for network filenames)
>> -global.user=none
>> +#global.user=none
>>
>>  # timeout in seconds before the default boot entry is started
>> -global.autoboot_timeout=3
>> +#global.autoboot_timeout=3
>>
>>  # default boot entry (one of /env/boot/*)
>> -global.boot.default=net
>> +#global.boot.default=net
>>
>>  # base bootargs
>>  #global.linux.bootargs.base="console=ttyS0,115200"
>> --
>> 1.8.1.1
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox



--
Fabio Porcedda

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 next 0/2] defenv2: complete move config-board out of /env/init

[Fabio Porcedda]

On Sat, Feb 23, 2013 at 2:01 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Fri, Feb 22, 2013 at 11:10:40AM +0100, Fabio Porcedda wrote:
>> v2:
>>  - add patch 2/2 for telit-evk-pro3
>>
>> Fabio Porcedda (2):
>>   defenv2: comment setting default values in /env/config
>>   ARM at91 telit-evk-pro3: move config-board out of /env/init
>>
>>  arch/arm/boards/telit-evk-pro3/env/config-board      | 8 ++++++++
>>  arch/arm/boards/telit-evk-pro3/env/init/config-board | 8 --------
>>  defaultenv-2/base/config                             | 8 ++++----
>>  3 files changed, 12 insertions(+), 12 deletions(-)
>>  create mode 100644 arch/arm/boards/telit-evk-pro3/env/config-board
>>  delete mode 100644 arch/arm/boards/telit-evk-pro3/env/init/config-board
>
> Applied, thanks. I decided to apply it to next though as I tend to be
> careful with changes to master.

Thanks, it's fine like that.

> Sascha
>
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
Fabio Porcedda

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 next 1/2] defenv2: comment setting default values in /env/config

[Sascha Hauer]

On Sat, Feb 23, 2013 at 02:26:29PM +0100, Alexander Aring wrote:
> Hi,
> 
> too late for this correction :(

We can still fixup things in -next and I just did that.

Sascha

> 
> On Fri, Feb 22, 2013 at 11:10:41AM +0100, Fabio Porcedda wrote:
> > There is no need to set againg deafult values in /env/config
> 
> s/deafult/default/
> 
> > because they are already setted in /env/bin/init,
> > that allow /env/config-board to change those default values
> > without being overwritten by /env/config.
> > 
> > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> > ---
> >  defaultenv-2/base/config | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/defaultenv-2/base/config b/defaultenv-2/base/config
> > index 189e5a6..dec0595 100644
> > --- a/defaultenv-2/base/config
> > +++ b/defaultenv-2/base/config
> > @@ -6,16 +6,16 @@
> >  #global.hostname=
> >  
> >  # set to false if you do not want to have colors
> > -global.allow_color=true
> > +#global.allow_color=true
> >  
> >  # user (used for network filenames)
> > -global.user=none
> > +#global.user=none
> >  
> >  # timeout in seconds before the default boot entry is started
> > -global.autoboot_timeout=3
> > +#global.autoboot_timeout=3
> >  
> >  # default boot entry (one of /env/boot/*)
> > -global.boot.default=net
> > +#global.boot.default=net
> >  
> >  # base bootargs
> >  #global.linux.bootargs.base="console=ttyS0,115200"
> > -- 
> > 1.8.1.1
> > 
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 next 1/2] defenv2: comment setting default values in /env/config

[Alexander Aring]

Hi,

On Sat, Feb 23, 2013 at 03:37:56PM +0100, Sascha Hauer wrote:
> On Sat, Feb 23, 2013 at 02:26:29PM +0100, Alexander Aring wrote:
> > Hi,
> > 
> > too late for this correction :(
> 
> We can still fixup things in -next and I just did that.

Ok, that's cool. It's not only deafult to default. There is another typo with
againg and again.

Thanks

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 next 1/2] defenv2: comment setting default values in /env/config

[Fabio Porcedda]

On Sat, Feb 23, 2013 at 3:37 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Sat, Feb 23, 2013 at 02:26:29PM +0100, Alexander Aring wrote:
>> Hi,
>>
>> too late for this correction :(
>
> We can still fixup things in -next and I just did that.

Thanks for fixing it.

> Sascha
>
>>
>> On Fri, Feb 22, 2013 at 11:10:41AM +0100, Fabio Porcedda wrote:
>> > There is no need to set againg deafult values in /env/config
>>
>> s/deafult/default/
>>
>> > because they are already setted in /env/bin/init,
>> > that allow /env/config-board to change those default values
>> > without being overwritten by /env/config.
>> >
>> > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> > ---
>> >  defaultenv-2/base/config | 8 ++++----
>> >  1 file changed, 4 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/defaultenv-2/base/config b/defaultenv-2/base/config
>> > index 189e5a6..dec0595 100644
>> > --- a/defaultenv-2/base/config
>> > +++ b/defaultenv-2/base/config
>> > @@ -6,16 +6,16 @@
>> >  #global.hostname=
>> >
>> >  # set to false if you do not want to have colors
>> > -global.allow_color=true
>> > +#global.allow_color=true
>> >
>> >  # user (used for network filenames)
>> > -global.user=none
>> > +#global.user=none
>> >
>> >  # timeout in seconds before the default boot entry is started
>> > -global.autoboot_timeout=3
>> > +#global.autoboot_timeout=3
>> >
>> >  # default boot entry (one of /env/boot/*)
>> > -global.boot.default=net
>> > +#global.boot.default=net
>> >
>> >  # base bootargs
>> >  #global.linux.bootargs.base="console=ttyS0,115200"
>> > --
>> > 1.8.1.1
>> >
>> >
>> > _______________________________________________
>> > barebox mailing list
>> > barebox@lists.infradead.org
>> > http://lists.infradead.org/mailman/listinfo/barebox
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



-- 
Fabio Porcedda

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox