Re: [PATCH 2/3] Refactor malloc.h.

[Masaki Muranaka <monaka@monami-ya.jp>]

Hello,

My wish is to use POSIX/ISO-C-hosted way in commands/ and lib/
They are similar to user-land in Unix.

But I'm not sure if it's better replacing all malloc.h to stdlib.h.
common/, fs/ and some places are equivalent to kernel inside.
There are not always required to confirm to POSIX/ISO-C-hosted.



2013/6/3 Sascha Hauer <s.hauer@pengutronix.de>:
> On Sun, Jun 02, 2013 at 11:53:48PM +0900, Masaki Muranaka wrote:
>>  Some functions should be defined in stdlib.h or unistd.h.
>> ---
>>  include/malloc.h       |  8 +++-----
>>  include/malloc_isoc.h  | 11 +++++++++++
>>  include/malloc_posix.h |  8 ++++++++
>>  include/stdlib.h       |  1 +
>>  include/unistd.h       |  6 ++++++
>>  5 files changed, 29 insertions(+), 5 deletions(-)
>>  create mode 100644 include/malloc_isoc.h
>>  create mode 100644 include/malloc_posix.h
>>  create mode 100644 include/unistd.h
>>
>> diff --git a/include/malloc.h b/include/malloc.h
>> index 7b9b062..9554597 100644
>> --- a/include/malloc.h
>> +++ b/include/malloc.h
>> @@ -5,20 +5,18 @@
>>
>>  /* Public routines */
>>
>> -void* malloc(size_t);
>> -void free(void*);
>> -void* realloc(void*, size_t);
>> +#include <malloc_isoc.h>
>> +#include <malloc_posix.h>
>> +
>>  void* memalign(size_t, size_t);
>>  void* vallocc(size_t);
>>  void* pvalloc(size_t);
>> -void* calloc(size_t, size_t);
>>  void cfree(void*);
>>  int malloc_trim(size_t);
>>  size_t malloc_usable_size(void*);
>>  void malloc_stats(void);
>>  int mallopt(int, int);
>>  struct mallinfo mallinfo(void);
>> -void *sbrk(ptrdiff_t increment);
>
> Wouldn't it be nicer to move the prototypes to unistd.h / stdlib.h
> instead of adding new files?
>
> Sascha
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



-- 
--
Masaki Muranaka
Monami-ya LLC, Japan.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox