From: Franck JULLIEN <franck.jullien@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/4] nios2/altera_tse.c: switch to ressources
Date: Tue, 26 Jul 2011 13:41:06 +0200 [thread overview]
Message-ID: <CAJfOKBweX-C3DP3=Q4kU+g0GGUkVTMvy8ywBxwn2zAHw9cZy_w@mail.gmail.com> (raw)
In-Reply-To: <20110726064858.GC20587@pengutronix.de>
Hi Sascha,
2011/7/26 Sascha Hauer <s.hauer@pengutronix.de>:
> Hi Franck,
>
> On Mon, Jul 25, 2011 at 09:50:18PM +0200, franck.jullien@gmail.com wrote:
>> From: Franck Jullien <franck.jullien@gmail.com>
>>
>> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
>> ---
>> drivers/net/altera_tse.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/altera_tse.c b/drivers/net/altera_tse.c
>> index ac8cd2d..4298739 100644
>> --- a/drivers/net/altera_tse.c
>> +++ b/drivers/net/altera_tse.c
>> @@ -510,7 +510,7 @@ static int tse_probe(struct device_d *dev)
>> dev->type_data = edev;
>> edev->priv = (struct altera_tse_priv *)(edev + 1);
>>
>> - edev->iobase = dev->map_base;
>> + edev->iobase = (int)dev_request_mem_region(dev, 0);
>
> Damned. I wasn't aware that struct eth_device has an int iobase.
> Can you please move your iobase to edev->priv (as a void __iomem *)?
>
No problem. I'll also use resources for sgdma_tx and sgdma_rx. I'll resend the
patch tonight.
> Then we can remove this otherwise unused field from eth_device.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-07-26 11:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 19:50 [PATCH] Switch Nios2 devices to ressource usage franck.jullien
2011-07-25 19:50 ` [PATCH 1/4] nios2/generic.c: use add_generic_device helper franck.jullien
2011-07-25 19:50 ` [PATCH 2/4] nios2/altera_tse.c: switch to ressources franck.jullien
2011-07-26 6:48 ` Sascha Hauer
2011-07-26 11:41 ` Franck JULLIEN [this message]
2011-07-25 19:50 ` [PATCH 3/4] nios2/serial_altera.c: " franck.jullien
2011-07-26 6:52 ` Sascha Hauer
2011-07-25 19:50 ` [PATCH 4/4] nios2/serial_altera_jtag.c: " franck.jullien
2011-07-26 6:53 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfOKBweX-C3DP3=Q4kU+g0GGUkVTMvy8ywBxwn2zAHw9cZy_w@mail.gmail.com' \
--to=franck.jullien@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox