From: Franck Jullien <franck.jullien@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] [OpenRISC] Add __ashrdi3 and remove link to libgcc
Date: Thu, 6 Sep 2012 09:28:05 +0200 [thread overview]
Message-ID: <CAJfOKBxOs5oaj5-_LHiZprTf383YLd9H2sddgCiW43FFrUsXRA@mail.gmail.com> (raw)
In-Reply-To: <20120906065544.GK26594@pengutronix.de>
2012/9/6 Sascha Hauer <s.hauer@pengutronix.de>:
> Hi Franck,
>
> On Wed, Sep 05, 2012 at 10:37:26PM +0200, Franck Jullien wrote:
>> In a previous patch, Sascha needed to add __ashrdi3 and then linked to
>> libgcc. This patch add the ashrdi3 function in the arch/openrisc/lib
>> directory and remove the libgcc link.
>
> Does this fix any regressions or is it just a do-the-right-thing patch?
>
No, it doesn't fix anything. I just did the same thing I did for
others libgcc functions.
>>
>> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
>> ---
>> arch/openrisc/Makefile | 4 +-
>> arch/openrisc/lib/Makefile | 1 +
>> arch/openrisc/lib/ashrdi3.S | 59 +++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 62 insertions(+), 2 deletions(-)
>> create mode 100644 arch/openrisc/lib/ashrdi3.S
>>
>> diff --git a/arch/openrisc/Makefile b/arch/openrisc/Makefile
>> index 1f4b175..9e88a51 100644
>> --- a/arch/openrisc/Makefile
>> +++ b/arch/openrisc/Makefile
>> @@ -1,6 +1,6 @@
>> CPPFLAGS += -D__OR1K__ -ffixed-r10 -mhard-mul -mhard-div
>>
>> -LIBGCC := $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
>> +#LIBGCC := $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
>
> Can we remove the line instead?
I wanted to keep it in case we have the problem again (need to link to
libgcc).....
>
>>
>> board-$(CONFIG_GENERIC) := generic
>>
>> @@ -20,6 +20,6 @@ common-y += $(BOARD)
>> common-y += arch/openrisc/lib/
>> common-y += arch/openrisc/cpu/
>>
>> -common-y += $(LIBGCC)
>> +#common-y += $(LIBGCC)
>
> ditto.
But I could remove it of course.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-09-06 7:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 12:44 [PATCH] provide ffs and __ashrdi3 for all architectures Sascha Hauer
2012-06-25 12:44 ` [PATCH 1/5] blackfin: add __ashrdi3 Sascha Hauer
2012-06-25 12:44 ` [PATCH 2/5] openrisc: link to libgcc Sascha Hauer
2012-06-25 13:00 ` Sascha Hauer
2012-06-25 12:44 ` [PATCH 3/5] mips: Add missing ffs include Sascha Hauer
2012-06-25 12:44 ` [PATCH 4/5] nios2: " Sascha Hauer
2012-06-25 12:44 ` [PATCH 5/5] x86: " Sascha Hauer
2012-09-05 20:37 ` [PATCH] [OpenRISC] Add __ashrdi3 and remove link to libgcc Franck Jullien
2012-09-06 6:55 ` Sascha Hauer
2012-09-06 7:28 ` Franck Jullien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfOKBxOs5oaj5-_LHiZprTf383YLd9H2sddgCiW43FFrUsXRA@mail.gmail.com \
--to=franck.jullien@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox