mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] Kconfig: Fix menuconfig build
@ 2014-05-10 22:36 Franck Jullien
  2014-05-12  4:39 ` Sascha Hauer
  0 siblings, 1 reply; 3+ messages in thread
From: Franck Jullien @ 2014-05-10 22:36 UTC (permalink / raw)
  To: barebox

Using Centos 6.5 with x86_64 architecture, "make menuconfig" commands
results in the following:

  HOSTLD  scripts/kconfig/mconf
/opt/centos/devtoolset-1.1/root/usr/libexec/gcc/x86_64-redhat-linux/4.7.2/ld:
scripts/kconfig/lxdialog/checklist.o: undefined reference to symbol
'acs_map'
/opt/centos/devtoolset-1.1/root/usr/libexec/gcc/x86_64-redhat-linux/4.7.2/ld:
note: 'acs_map' is defined in DSO /lib64/libtinfo.so.5 so try adding it
to the linker command line
/lib64/libtinfo.so.5: could not read symbols: invalid operation
collect2: error: ld returned 1 exit status
make[1]: *** [scripts/kconfig/mconf] Error 1
make: *** [menuconfig] Error 2

When "-ltinfo" is added to the LDFLAGS symbol as suggested by the linker,
it builds and runs correctly.

Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
---
 scripts/kconfig/Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 844bc9d..8bdd7bc 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -218,6 +218,7 @@ HOSTCFLAGS_gconf.o	= `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \
                           -Wno-missing-prototypes
 
 HOSTLOADLIBES_mconf   = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
+HOSTLOADLIBES_mconf += -ltinfo
 
 HOSTLOADLIBES_nconf	= $(shell \
 				pkg-config --libs menu panel ncurses 2>/dev/null \
-- 
1.7.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] Kconfig: Fix menuconfig build
  2014-05-10 22:36 [PATCH] Kconfig: Fix menuconfig build Franck Jullien
@ 2014-05-12  4:39 ` Sascha Hauer
  2014-05-12  6:49   ` Franck Jullien
  0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2014-05-12  4:39 UTC (permalink / raw)
  To: Franck Jullien; +Cc: barebox

Hi Franck,

On Sun, May 11, 2014 at 12:36:28AM +0200, Franck Jullien wrote:
> Using Centos 6.5 with x86_64 architecture, "make menuconfig" commands
> results in the following:
> 
>   HOSTLD  scripts/kconfig/mconf
> /opt/centos/devtoolset-1.1/root/usr/libexec/gcc/x86_64-redhat-linux/4.7.2/ld:
> scripts/kconfig/lxdialog/checklist.o: undefined reference to symbol
> 'acs_map'
> /opt/centos/devtoolset-1.1/root/usr/libexec/gcc/x86_64-redhat-linux/4.7.2/ld:
> note: 'acs_map' is defined in DSO /lib64/libtinfo.so.5 so try adding it
> to the linker command line
> /lib64/libtinfo.so.5: could not read symbols: invalid operation
> collect2: error: ld returned 1 exit status
> make[1]: *** [scripts/kconfig/mconf] Error 1
> make: *** [menuconfig] Error 2
> 
> When "-ltinfo" is added to the LDFLAGS symbol as suggested by the linker,
> it builds and runs correctly.

This issue came up over a year ago and the patch is still not upstream
in Linux. Do you have the same issue when compiling Linux aswell?

I could apply this, but it may happen that the change gets lost with the
next Kconfig update. So it's good when the issue is fixed upstream.

Sascha

> 
> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
> ---
>  scripts/kconfig/Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> index 844bc9d..8bdd7bc 100644
> --- a/scripts/kconfig/Makefile
> +++ b/scripts/kconfig/Makefile
> @@ -218,6 +218,7 @@ HOSTCFLAGS_gconf.o	= `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \
>                            -Wno-missing-prototypes
>  
>  HOSTLOADLIBES_mconf   = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
> +HOSTLOADLIBES_mconf += -ltinfo
>  
>  HOSTLOADLIBES_nconf	= $(shell \
>  				pkg-config --libs menu panel ncurses 2>/dev/null \
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] Kconfig: Fix menuconfig build
  2014-05-12  4:39 ` Sascha Hauer
@ 2014-05-12  6:49   ` Franck Jullien
  0 siblings, 0 replies; 3+ messages in thread
From: Franck Jullien @ 2014-05-12  6:49 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

2014-05-12 6:39 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> Hi Franck,
>
> On Sun, May 11, 2014 at 12:36:28AM +0200, Franck Jullien wrote:
>> Using Centos 6.5 with x86_64 architecture, "make menuconfig" commands
>> results in the following:
>>
>>   HOSTLD  scripts/kconfig/mconf
>> /opt/centos/devtoolset-1.1/root/usr/libexec/gcc/x86_64-redhat-linux/4.7.2/ld:
>> scripts/kconfig/lxdialog/checklist.o: undefined reference to symbol
>> 'acs_map'
>> /opt/centos/devtoolset-1.1/root/usr/libexec/gcc/x86_64-redhat-linux/4.7.2/ld:
>> note: 'acs_map' is defined in DSO /lib64/libtinfo.so.5 so try adding it
>> to the linker command line
>> /lib64/libtinfo.so.5: could not read symbols: invalid operation
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [scripts/kconfig/mconf] Error 1
>> make: *** [menuconfig] Error 2
>>
>> When "-ltinfo" is added to the LDFLAGS symbol as suggested by the linker,
>> it builds and runs correctly.
>
> This issue came up over a year ago and the patch is still not upstream
> in Linux.

I know and I just stole this patch from google search ;)

Do you have the same issue when compiling Linux aswell?
>
> I could apply this, but it may happen that the change gets lost with the
> next Kconfig update. So it's good when the issue is fixed upstream.
>
> Sascha
>

It does work with Linux and kconfig Makefiles are identical (?!).
So drop this patch and I'll try to do some more dig up.

Franck.

>>
>> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
>> ---
>>  scripts/kconfig/Makefile |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
>> index 844bc9d..8bdd7bc 100644
>> --- a/scripts/kconfig/Makefile
>> +++ b/scripts/kconfig/Makefile
>> @@ -218,6 +218,7 @@ HOSTCFLAGS_gconf.o        = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \
>>                            -Wno-missing-prototypes
>>
>>  HOSTLOADLIBES_mconf   = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
>> +HOSTLOADLIBES_mconf += -ltinfo
>>
>>  HOSTLOADLIBES_nconf  = $(shell \
>>                               pkg-config --libs menu panel ncurses 2>/dev/null \
>> --
>> 1.7.1
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-12  6:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-10 22:36 [PATCH] Kconfig: Fix menuconfig build Franck Jullien
2014-05-12  4:39 ` Sascha Hauer
2014-05-12  6:49   ` Franck Jullien

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox