Re: [PATCH v2 1/2] debug_ll.h: add PUTS_LL() function

From: Franck JULLIEN <franck.jullien@gmail.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/2] debug_ll.h: add PUTS_LL() function
Date: Mon, 18 Jul 2011 15:26:33 +0200	[thread overview]
Message-ID: <CAJfOKByNkqH8UKB6OU_rh67oG3c43=fW_7wRa=+Lc0Rf7HrcBw@mail.gmail.com> (raw)
In-Reply-To: <1310994370-28444-1-git-send-email-antonynpavlov@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1369 bytes --]

2011/7/18 Antony Pavlov <antonynpavlov@gmail.com>

> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  include/debug_ll.h |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/include/debug_ll.h b/include/debug_ll.h
> index e99ae7d..6b1b174 100644
> --- a/include/debug_ll.h
> +++ b/include/debug_ll.h
> @@ -35,9 +35,22 @@
>                             ch = ((v >> (i*4)) & 0xf);\
>                             ch += (ch >= 10) ? 'a' - 10 : '0';\
>                             PUTC_LL (ch); }})
> +
> +static __inline__ void PUTS_LL(char * str)
> +{
> +       while (*str) {
> +               if (*str == '\n') {
> +                       PUTC_LL('\r');
> +               }
> +               PUTC_LL(*str);
> +               str++;
> +       }
> +}
> +
>  #else
>  # define PUTC_LL(c) do {} while (0)
>  # define PUTHEX_LL(v) do {} while (0)
> +# define PUTS_LL(c) do {} while (0)
>
>  #endif
>
> --
> 1.7.5.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

Hello,

Could we add an entry for CONFIG_DEBUG_LL in the debugging menu
(common/Kconfig) ?
This file makes barebox not compile if we are not on arm arch due to the
<mach/debug_ll.h> inclusion.

I know it's not related to your patch :)

Franck.

[-- Attachment #1.2: Type: text/html, Size: 2119 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox