From: Franck Jullien <franck.jullien@gmail.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [RFC][FAT] Handle MBR on the first sector
Date: Fri, 14 Sep 2012 11:02:05 +0200 [thread overview]
Message-ID: <CAJfOKBydgM3oTtHM-J+0i6n4kCiEz1jxp+2FhYnn+fC2Mou5Tg@mail.gmail.com> (raw)
In-Reply-To: <20120914085001.GA25990@game.jcrosoft.org>
2012/9/14 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
>
> On 10:47 Fri 14 Sep , Franck Jullien wrote:
>>
>> 2012/9/14 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
>> >
>> > On 09:25 Fri 14 Sep , Sascha Hauer wrote:
>> >>
>> >> On Fri, Sep 14, 2012 at 09:22:07AM +0200, Franck Jullien wrote:
>> >> > 2012/9/14 Sascha Hauer <s.hauer@pengutronix.de>:
>> >> > > Hi Franck,
>> >> > >
>> >> > > On Thu, Sep 13, 2012 at 02:13:29PM +0200, Franck Jullien wrote:
>> >> > >> *** Did not send this email with git because it's no working where I am **
>> >> > >>
>> >> > >> We may have some disk with MBR as a first sector. In this case, the
>> >> > >> current FAT check returns an error. However, the FAT sector exist and
>> >> > >> the MBR can tell us where it is.
>> >> > >>
>> >> > >> This patch make the FAT fs try to find the FAT boot sector on the first
>> >> > >> sector of the first partition in case it is not on sector 0.
>> >> > >
>> >> > > The patch looks good. Not applying it because it's RFC, but I would if
>> >> > > you give your ok.
>> >> > >
>> >> >
>> >> > You have it.
>> >>
>> >> Thanks, applied
>> >
>> > Does this work with the fat autodetection
>> >
>> > Best Regards,
>> > J.
>>
>> What do you mean ?
>>
>> It works when you mount your device as FAT. The FAT fs check is the
>> first sector is FAT boot sector. If not, it suppose it is an MBR and
>> the FAT boot sector is in the first partition.
> check the the next branch
>
> I add the fs detection to do not specify the filesystem type anymore in mount
>
> Best Regards,
> J.
It won't. We need to check if it is an MBR here too (static int
is_fat(u8 *buf)) ....
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-09-14 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 12:13 Franck Jullien
2012-09-14 7:18 ` Sascha Hauer
2012-09-14 7:22 ` Franck Jullien
2012-09-14 7:25 ` Sascha Hauer
2012-09-14 7:44 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-14 8:47 ` Franck Jullien
2012-09-14 8:50 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-14 9:02 ` Franck Jullien [this message]
2012-09-14 9:04 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-14 9:06 ` Franck Jullien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfOKBydgM3oTtHM-J+0i6n4kCiEz1jxp+2FhYnn+fC2Mou5Tg@mail.gmail.com \
--to=franck.jullien@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox