mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Franck Jullien <franck.jullien@gmail.com>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] cfi_flash: show progress while during erase
Date: Mon, 26 May 2014 21:12:27 +0200	[thread overview]
Message-ID: <CAJfOKBzMSTNFDCZs34-cN_SDOemcB1Qpod3t=_uOz3VkdU=xkA@mail.gmail.com> (raw)
In-Reply-To: <CAOpc7mFb81QWXQg-iGvnNSqXoWiby4YqOGdOLGNpkBhdFtE5OQ@mail.gmail.com>

2014-05-26 21:04 GMT+02:00 Holger Schurig <holgerschurig@gmail.com>:
>> -       ret = cfi_erase(info, instr->len, instr->addr);
>> +       ret = cfi_erase(info, instr->len, instr->addr, 1);
>
> Hmm, why this parameter?  Basically, three things would be sane:
>

I copied the code that was here before (I know that's not a good reason).
Well, this "1" means: if you want to make verbose an option, implement
this and replace "1" by whatever it needs.

> * never output progress (no verbose parameter needed, obviously)
> * always output progress (again no parameter needed)
> * make it a command line option (parameter needed)
>
> What you have here (in the current form) is a needless parameter to cfi_erase().

What would you think if we had a command line option to make erase quiet (-q) ?
By default we would have a progress bar displayed.

Franck.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2014-05-26 19:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26 18:12 Franck Jullien
2014-05-26 18:20 ` Franck Jullien
2014-05-27  5:42   ` Sascha Hauer
2014-05-27  6:50     ` Franck Jullien
2014-05-27 18:24       ` Sascha Hauer
2014-05-26 19:04 ` Holger Schurig
2014-05-26 19:12   ` Franck Jullien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfOKBzMSTNFDCZs34-cN_SDOemcB1Qpod3t=_uOz3VkdU=xkA@mail.gmail.com' \
    --to=franck.jullien@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=holgerschurig@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox