[Question] device-tree-rebasing include path

[Question] device-tree-rebasing include path

[Masahiro Yamada]

Hi Sascha,

I have a question about the include path
of device-tree-rebasing.


When I saw scripts/Makefile.lib, I noticed that
"-I $(srctree)/dts/src" is included for pre-processor,
whereas "-i $(srctree)/dts/src/$(SRCARCH)" for DTC-native.

The root of device-tree-rebasing is dts/src/ when we use '#include',
but dts/src/$(SRCARCH) when we use '/include/'


Is this intentional?

In my opinion, #include and /include/
should be able to include files in the same way.


Here,

dtc_cpp_flags  = -Wp,-MD,$(depfile).pre -nostdinc  \
     -I$(srctree)/arch/$(SRCARCH)/dts/include      \
     -I$(srctree)/dts/include                      \
     -I$(srctree)/dts/src/                         \
     -undef -D__DTS__


cmd_dtc = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
      $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 \
      -i $(srctree)/arch/$(SRCARCH)/dts $(DTC_FLAGS) \
      -i $(srctree)/dts/src/$(SRCARCH) \
      -d $(depfile).dtc $(dtc-tmp) ; \
      cat $(depfile).pre $(depfile).dtc > $(depfile)






-- 
Best Regards
Masahiro Yamada

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [Question] device-tree-rebasing include path

[Sascha Hauer]

Hi Masahiro,

On Mon, Aug 10, 2015 at 08:05:59AM +0900, Masahiro Yamada wrote:
> Hi Sascha,
> 
> I have a question about the include path
> of device-tree-rebasing.
> 
> 
> When I saw scripts/Makefile.lib, I noticed that
> "-I $(srctree)/dts/src" is included for pre-processor,
> whereas "-i $(srctree)/dts/src/$(SRCARCH)" for DTC-native.
> 
> The root of device-tree-rebasing is dts/src/ when we use '#include',
> but dts/src/$(SRCARCH) when we use '/include/'
> 
> 
> Is this intentional?

Nope, this is not intentional. Currently there is no user for /include/ for
something in dts/, so we could change this to be consistent without
breaking anything.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [Question] device-tree-rebasing include path

[Masahiro Yamada]

Hi Sascha,


2015-08-19 23:36 GMT+09:00 Sascha Hauer <s.hauer@pengutronix.de>:
> Hi Masahiro,
>
> On Mon, Aug 10, 2015 at 08:05:59AM +0900, Masahiro Yamada wrote:
>> Hi Sascha,
>>
>> I have a question about the include path
>> of device-tree-rebasing.
>>
>>
>> When I saw scripts/Makefile.lib, I noticed that
>> "-I $(srctree)/dts/src" is included for pre-processor,
>> whereas "-i $(srctree)/dts/src/$(SRCARCH)" for DTC-native.
>>
>> The root of device-tree-rebasing is dts/src/ when we use '#include',
>> but dts/src/$(SRCARCH) when we use '/include/'
>>
>>
>> Is this intentional?
>
> Nope, this is not intentional. Currently there is no user for /include/ for
> something in dts/, so we could change this to be consistent without
> breaking anything.
>
> Sascha


OK, thanks.


I have sent a patch.



-- 
Best Regards
Masahiro Yamada

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox