mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] kbuild: Add missing semicolon
Date: Fri, 15 Feb 2019 10:53:28 +0900	[thread overview]
Message-ID: <CAK7LNAQmBjQN9ek5HTxjBV9zLwWG8faPpMkPTwrJdnULzhXqHw@mail.gmail.com> (raw)
In-Reply-To: <20190214082026.22614-1-s.hauer@pengutronix.de>

On Thu, Feb 14, 2019 at 5:20 PM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> Fixes: 4fafb35d925e5 ("kbuild: cherry-pick changes from Linux v5.0-rc3")
>
> The change cherry-picked from the Kernel commit 7d0ea2524202 ("kbuild: use
> 'else ifeq' for checksrc to improve readability") also removed the
> trailing semicolons from the cmd_*checksrc lines. These were removed in
> kernel commit e5d289100d ("kbuild: remove trailing semicolon from cmd_*
> passed to if_changed_rule"), but seems the barebox Kbuild version is not
> yet ready for this change. Without the semicolons a make C=1 build fails
> with:
>
> No such file: echo


My bad - this change accidentally slipped in.

It would be possible to sync if_changed* with latest Linux,
but I agree that we should revert the offending lines for now.


Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>



>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>  scripts/Makefile.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 2c45ea872f..db687d5f9e 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -86,10 +86,10 @@ __build: $(if $(KBUILD_BUILTIN),$(builtin-target) $(lib-target) $(pbl-target) $(
>  # Linus' kernel sanity checking tool
>  ifeq ($(KBUILD_CHECKSRC),1)
>    quiet_cmd_checksrc       = CHECK   $<
> -        cmd_checksrc       = $(CHECK) $(CHECKFLAGS) $(c_flags) $<
> +        cmd_checksrc       = $(CHECK) $(CHECKFLAGS) $(c_flags) $< ;
>  else ifeq ($(KBUILD_CHECKSRC),2)
>    quiet_cmd_force_checksrc = CHECK   $<
> -        cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $<
> +        cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< ;
>  endif
>
>  # Compile C sources (.c)
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox



-- 
Best Regards
Masahiro Yamada

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2019-02-15  1:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14  8:20 Sascha Hauer
2019-02-15  1:53 ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNAQmBjQN9ek5HTxjBV9zLwWG8faPpMkPTwrJdnULzhXqHw@mail.gmail.com \
    --to=yamada.masahiro@socionext.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox