From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from conssluserg-01.nifty.com ([210.131.2.80]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1guSi0-0003TL-Vf for barebox@lists.infradead.org; Fri, 15 Feb 2019 01:54:35 +0000 Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) (authenticated) by conssluserg-01.nifty.com with ESMTP id x1F1s57S016143 for ; Fri, 15 Feb 2019 10:54:05 +0900 Received: by mail-vk1-f181.google.com with SMTP id j68so1873571vke.13 for ; Thu, 14 Feb 2019 17:54:05 -0800 (PST) MIME-Version: 1.0 References: <20190214082026.22614-1-s.hauer@pengutronix.de> In-Reply-To: <20190214082026.22614-1-s.hauer@pengutronix.de> From: Masahiro Yamada Date: Fri, 15 Feb 2019 10:53:28 +0900 Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] kbuild: Add missing semicolon To: Sascha Hauer Cc: Barebox List On Thu, Feb 14, 2019 at 5:20 PM Sascha Hauer wrote: > > Fixes: 4fafb35d925e5 ("kbuild: cherry-pick changes from Linux v5.0-rc3") > > The change cherry-picked from the Kernel commit 7d0ea2524202 ("kbuild: use > 'else ifeq' for checksrc to improve readability") also removed the > trailing semicolons from the cmd_*checksrc lines. These were removed in > kernel commit e5d289100d ("kbuild: remove trailing semicolon from cmd_* > passed to if_changed_rule"), but seems the barebox Kbuild version is not > yet ready for this change. Without the semicolons a make C=1 build fails > with: > > No such file: echo My bad - this change accidentally slipped in. It would be possible to sync if_changed* with latest Linux, but I agree that we should revert the offending lines for now. Reviewed-by: Masahiro Yamada > > Signed-off-by: Sascha Hauer > Cc: Masahiro Yamada > --- > scripts/Makefile.build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 2c45ea872f..db687d5f9e 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -86,10 +86,10 @@ __build: $(if $(KBUILD_BUILTIN),$(builtin-target) $(lib-target) $(pbl-target) $( > # Linus' kernel sanity checking tool > ifeq ($(KBUILD_CHECKSRC),1) > quiet_cmd_checksrc = CHECK $< > - cmd_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< > + cmd_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< ; > else ifeq ($(KBUILD_CHECKSRC),2) > quiet_cmd_force_checksrc = CHECK $< > - cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< > + cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< ; > endif > > # Compile C sources (.c) > -- > 2.20.1 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox -- Best Regards Masahiro Yamada _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox