mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] libfdt: update <linux/libfdt.h> and <linux/libfdt_env.h> to Linux 5.7-rc1
Date: Wed, 15 Apr 2020 19:54:09 +0900	[thread overview]
Message-ID: <CAK7LNAR-tti5gXSbS3SpJ0Vurkcbv2naDE-J0TZL0EqNLFzbiA@mail.gmail.com> (raw)
In-Reply-To: <20200415094018.GL1694@pengutronix.de>

On Wed, Apr 15, 2020 at 6:40 PM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> On Wed, Apr 15, 2020 at 04:59:17PM +0900, Masahiro Yamada wrote:
> > Fix the relative include path in <linux/libfdt.h>
> >
> > Including <linux/kernel.h> is too much. <linux/limits.h> is enough
> > for INT_MAX.
> >
> > Define INT32_MAX and UINT32_MAX in the same way as Linux does.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  include/linux/libfdt.h     | 2 +-
> >  include/linux/libfdt_env.h | 7 ++++---
> >  2 files changed, 5 insertions(+), 4 deletions(-)
>
> Applied, thanks.
>
> >
> > diff --git a/include/linux/libfdt.h b/include/linux/libfdt.h
> > index ef2467213..90ed4ebfa 100644
> > --- a/include/linux/libfdt.h
> > +++ b/include/linux/libfdt.h
> > @@ -3,6 +3,6 @@
> >  #define _INCLUDE_LIBFDT_H_
> >
> >  #include <linux/libfdt_env.h>
> > -#include "../scripts/dtc/libfdt/libfdt.h"
> > +#include "../../scripts/dtc/libfdt/libfdt.h"
>
> I wonder why this obviously wrong path worked before.


This is because the $(srctree)/include/
is added to the header search paths.


The top Makefile defines it as follows:

LINUXINCLUDE    := -Iinclude -I$(srctree)/dts/include \
                   $(if $(KBUILD_SRC), -I$(srctree)/include) \
                   -I$(srctree)/arch/$(ARCH)/include \
                   -I$(objtree)/arch/$(ARCH)/include \
                   -include $(srctree)/include/linux/kconfig.h



The previous "../scripts/dtc/libfdt/libfdt.h"
works because it is relative to $(srctree)/include/


---
Best Regards
Masahiro Yamada

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-04-15 10:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15  7:59 Masahiro Yamada
2020-04-15  9:40 ` Sascha Hauer
2020-04-15 10:54   ` Masahiro Yamada [this message]
2020-04-16  6:35     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNAR-tti5gXSbS3SpJ0Vurkcbv2naDE-J0TZL0EqNLFzbiA@mail.gmail.com \
    --to=masahiroy@kernel.org \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox